Reviewed by Adam Roben.
authorap@webkit.org <ap@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 11 Jan 2008 21:04:36 +0000 (21:04 +0000)
committerap@webkit.org <ap@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 11 Jan 2008 21:04:36 +0000 (21:04 +0000)
        <rdar://problem/5667275> fast/dynamic/layer-hit-test-crash.html is failing

        * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ignore WM_MOUSELEAVE events,
        as these are only posted because the test window is not a normal visible one, and
        they confuse drag&drop machinery.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@29417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/win/Skipped
WebKitTools/ChangeLog
WebKitTools/DumpRenderTree/win/DumpRenderTree.cpp

index e1a4085..2248f03 100644 (file)
@@ -1,3 +1,11 @@
+2008-01-11  Alexey Proskuryakov  <ap@webkit.org>
+
+        Reviewed by Adam Roben.
+
+        <rdar://problem/5667275> fast/dynamic/layer-hit-test-crash.html is failing
+
+        * platform/win/Skipped: The test now passes.
+
 2008-01-11  Adam Roben  <aroben@apple.com>
 
         * platform/win/Skipped: Added some new failures.
index 1ad2007..f8ce3e8 100644 (file)
@@ -372,9 +372,6 @@ editing/selection/5131716-1.html
 # <rdar://5667273>
 editing/selection/fake-drag.html
 
-# <rdar://5667275>
-fast/dynamic/layer-hit-test-crash.html
-
 # <rdar://5667279> Undefined value exception
 http/tests/xmlhttprequest/XMLHttpRequestException.html
 
index f272fda..29350e5 100644 (file)
@@ -1,3 +1,13 @@
+2008-01-11  Alexey Proskuryakov  <ap@webkit.org>
+
+        Reviewed by Adam Roben.
+
+        <rdar://problem/5667275> fast/dynamic/layer-hit-test-crash.html is failing
+
+        * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ignore WM_MOUSELEAVE events,
+        as these are only posted because the test window is not a normal visible one, and
+        they confuse drag&drop machinery.
+
 2008-01-11  Adam Roben  <aroben@apple.com>
 
         Fix a crash when pathToLocalResource fails and a leak
index 9b8574f..0eac89c 100644 (file)
@@ -679,6 +679,11 @@ static void runTest(const char* pathOrURL)
 
     MSG msg;
     while (GetMessage(&msg, 0, 0, 0)) {
+        // We get spurious WM_MOUSELEAVE events which make event handling machinery think that mouse button
+        // is released during dragging (see e.g. fast\dynamic\layer-hit-test-crash.html).
+        // Mouse can never leave WebView during normal DumpRenderTree operation, so we just ignore all such events.
+        if (msg.message == WM_MOUSELEAVE)
+            continue;
         TranslateMessage(&msg);
         DispatchMessage(&msg);
     }