Analysis tasks page complains about missing repository but with a wrong name
authorrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 19 Feb 2016 21:12:40 +0000 (21:12 +0000)
committerrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 19 Feb 2016 21:12:40 +0000 (21:12 +0000)
https://bugs.webkit.org/show_bug.cgi?id=154468

Reviewed by Chris Dumez.

Fixed the bug by using the right variable in the template literal.

* public/v3/components/customizable-test-group-form.js:
(CustomizableTestGroupForm.prototype._computeRootSetMap): Use querySelector here since Chrome doesn't have
getElementsByClassName on ShadowRoot.
* public/v3/pages/analysis-task-page.js:
(AnalysisTaskPage.prototype._createTestGroupAfterVerifyingRootSetList): Use name which is the name of
repository here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Websites/perf.webkit.org/ChangeLog
Websites/perf.webkit.org/public/v3/components/customizable-test-group-form.js
Websites/perf.webkit.org/public/v3/pages/analysis-task-page.js

index 5de9ef6..843e682 100644 (file)
@@ -1,3 +1,19 @@
+2016-02-19  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Analysis tasks page complains about missing repository but with a wrong name
+        https://bugs.webkit.org/show_bug.cgi?id=154468
+
+        Reviewed by Chris Dumez.
+
+        Fixed the bug by using the right variable in the template literal.
+
+        * public/v3/components/customizable-test-group-form.js:
+        (CustomizableTestGroupForm.prototype._computeRootSetMap): Use querySelector here since Chrome doesn't have
+        getElementsByClassName on ShadowRoot.
+        * public/v3/pages/analysis-task-page.js:
+        (AnalysisTaskPage.prototype._createTestGroupAfterVerifyingRootSetList): Use name which is the name of
+        repository here.
+
 2016-02-18  Ryosuke Niwa  <rniwa@webkit.org>
 
         Revert an unintended change made in the previous commit.
index e3e60ef..b49e23d 100644 (file)
@@ -43,7 +43,7 @@ class CustomizableTestGroupForm extends TestGroupForm {
             var customRootSet = new CustomRootSet;
             for (var repository of this._renderedRepositorylist) {
                 var className = CustomizableTestGroupForm._classForLabelAndRepository(label, repository);
-                var revision = this.content().getElementsByClassName(className)[0].value;
+                var revision = this.content().querySelector('.' + className).value;
                 console.assert(revision);
                 if (revision)
                     customRootSet.setRevisionForRepository(repository, revision);
index 136c4d6..864e0e7 100644 (file)
@@ -534,7 +534,7 @@ class AnalysisTaskPage extends PageWithHeading {
             for (var name in rootSetsByName) {
                 var list = rootSetsByName[name];
                 if (list.length < setIndex) {
-                    alert(`Set ${firstLabel} specifies ${repository.label()} but set ${label} does not.`);
+                    alert(`Set ${firstLabel} specifies ${name} but set ${label} does not.`);
                     return null;
                 }
             }