+2016-02-19 Ryosuke Niwa <rniwa@webkit.org>
+
+ Analysis tasks page complains about missing repository but with a wrong name
+ https://bugs.webkit.org/show_bug.cgi?id=154468
+
+ Reviewed by Chris Dumez.
+
+ Fixed the bug by using the right variable in the template literal.
+
+ * public/v3/components/customizable-test-group-form.js:
+ (CustomizableTestGroupForm.prototype._computeRootSetMap): Use querySelector here since Chrome doesn't have
+ getElementsByClassName on ShadowRoot.
+ * public/v3/pages/analysis-task-page.js:
+ (AnalysisTaskPage.prototype._createTestGroupAfterVerifyingRootSetList): Use name which is the name of
+ repository here.
+
2016-02-18 Ryosuke Niwa <rniwa@webkit.org>
Revert an unintended change made in the previous commit.
var customRootSet = new CustomRootSet;
for (var repository of this._renderedRepositorylist) {
var className = CustomizableTestGroupForm._classForLabelAndRepository(label, repository);
- var revision = this.content().getElementsByClassName(className)[0].value;
+ var revision = this.content().querySelector('.' + className).value;
console.assert(revision);
if (revision)
customRootSet.setRevisionForRepository(repository, revision);
for (var name in rootSetsByName) {
var list = rootSetsByName[name];
if (list.length < setIndex) {
- alert(`Set ${firstLabel} specifies ${repository.label()} but set ${label} does not.`);
+ alert(`Set ${firstLabel} specifies ${name} but set ${label} does not.`);
return null;
}
}