Remove an invalid ASSERT that is seen intermittently.
authorbeidson@apple.com <beidson@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 3 Nov 2017 20:12:10 +0000 (20:12 +0000)
committerbeidson@apple.com <beidson@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 3 Nov 2017 20:12:10 +0000 (20:12 +0000)
https://bugs.webkit.org/show_bug.cgi?id=179186

Unreviewed.

* workers/service/server/SWServerRegistration.cpp:
(WebCore::SWServerRegistration::removeClientServiceWorkerRegistration): This is an invalid ASSERT,
  it's definitely racey over IPC.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/workers/service/server/SWServerRegistration.cpp

index 218ebc4..3dad716 100644 (file)
@@ -1,3 +1,14 @@
+2017-11-03  Brady Eidson  <beidson@apple.com>
+
+        Remove an invalid ASSERT that is seen intermittently.
+        https://bugs.webkit.org/show_bug.cgi?id=179186
+
+        Unreviewed.
+
+        * workers/service/server/SWServerRegistration.cpp:
+        (WebCore::SWServerRegistration::removeClientServiceWorkerRegistration): This is an invalid ASSERT,
+          it's definitely racey over IPC.
+
 2017-11-03  Michael Catanzaro  <mcatanzaro@igalia.com>
 
         [WPE] Remove unneeded USE(LIBEPOXY) guards
index 8cbe4af..10267cf 100644 (file)
@@ -104,7 +104,6 @@ void SWServerRegistration::removeClientServiceWorkerRegistration(uint64_t connec
     if (iterator == m_clientRegistrationsByConnection.end() || !iterator->value)
         return;
     
-    ASSERT(iterator->value->contains(clientRegistrationIdentifier));
     iterator->value->remove(clientRegistrationIdentifier);
     if (iterator->value->isEmpty())
         m_clientRegistrationsByConnection.remove(iterator);