build.webkit.org/dashboard can’t open different results in two new tabs
authortimothy_horton@apple.com <timothy_horton@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 14 Nov 2013 23:03:32 +0000 (23:03 +0000)
committertimothy_horton@apple.com <timothy_horton@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 14 Nov 2013 23:03:32 +0000 (23:03 +0000)
https://bugs.webkit.org/show_bug.cgi?id=124383

Reviewed by Alexey Proskuryakov.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
(BuildbotQueueView.prototype.revisionLinksForIteration):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
(StatusLineView.prototype._clicked):
Use _blank (which is effectively open-in-new-tab, in Safari) instead of _new (which isn't a
real pseudo-target and instead acts as a named target and will end up causing all link clicks
to open in the same secondary tab).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js
Tools/ChangeLog

index 21c6ec0..644b26a 100644 (file)
@@ -78,7 +78,7 @@ BuildbotQueueView.prototype = {
             var linkElement = document.createElement("a");
             linkElement.href = iteration.queue.buildbot.tracRevisionURL(revision, internal);
             linkElement.textContent = "r" + revision;
-            linkElement.target = "_new";
+            linkElement.target = "_blank";
             return linkElement;
         }
 
index bbdfb40..3dcbcb2 100644 (file)
@@ -162,7 +162,7 @@ StatusLineView.prototype = {
 
         var anchor = document.createElement("a");
         anchor.href = this.url;
-        anchor.target = "_new";
+        anchor.target = "_blank";
 
         anchor.click();
     }
index 0fe3a58..14e291f 100644 (file)
@@ -1,3 +1,18 @@
+2013-11-14  Tim Horton  <timothy_horton@apple.com>
+
+        build.webkit.org/dashboard can’t open different results in two new tabs
+        https://bugs.webkit.org/show_bug.cgi?id=124383
+
+        Reviewed by Alexey Proskuryakov.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
+        (BuildbotQueueView.prototype.revisionLinksForIteration):
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
+        (StatusLineView.prototype._clicked):
+        Use _blank (which is effectively open-in-new-tab, in Safari) instead of _new (which isn't a
+        real pseudo-target and instead acts as a named target and will end up causing all link clicks
+        to open in the same secondary tab).
+
 2013-11-14  Anders Carlsson  <andersca@apple.com>
 
         Remove duplicate entry.