REGRESSION: r149001 made proximity test fail.
authorkihong.kwon@samsung.com <kihong.kwon@samsung.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 7 Jun 2013 14:40:53 +0000 (14:40 +0000)
committerkihong.kwon@samsung.com <kihong.kwon@samsung.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 7 Jun 2013 14:40:53 +0000 (14:40 +0000)
https://bugs.webkit.org/show_bug.cgi?id=117343

Reviewed by Christophe Dumez.

Update window-property.html test cases for Device Proximity Event.
The global constructors are no longer enumerable after r149001.

* proximity/window-property-expected.txt:
* proximity/window-property.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@151317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/proximity/window-property-expected.txt
LayoutTests/proximity/window-property.html

index f01f98f..429ed30 100644 (file)
@@ -1,3 +1,16 @@
+2013-06-07  Kihong Kwon  <kihong.kwon@samsung.com>
+
+        REGRESSION: r149001 made proximity test fail.
+        https://bugs.webkit.org/show_bug.cgi?id=117343
+
+        Reviewed by Christophe Dumez.
+
+        Update window-property.html test cases for Device Proximity Event.
+        The global constructors are no longer enumerable after r149001.
+
+        * proximity/window-property-expected.txt:
+        * proximity/window-property.html:
+
 2013-06-07  Gabor Abraham  <abrhm@inf.u-szeged.hu>
 
         [Qt] Unreviewed gardening. Skipping failing tests.
index d3e75d8..0db35ef 100644 (file)
@@ -5,7 +5,7 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE
 
 PASS typeof window.DeviceProximityEvent == 'object' is true
 PASS typeof window.DeviceProximityEvent == 'function' is false
-PASS hasDeviceProximityEventProperty() is true
+PASS window.propertyIsEnumerable('DeviceProximityEvent') is false
 PASS 'DeviceProximityEvent' in window is true
 PASS window.hasOwnProperty('DeviceProximityEvent') is true
 PASS typeof window.onwebkitdeviceproximity == 'object' is true
index dc4cebe..4694422 100644 (file)
@@ -6,18 +6,9 @@
 <script>
 description('Tests that the window.DeviceProximityEvent and window.onwebkitdeviceproximity properties are present.');
 
-function hasDeviceProximityEventProperty()
-{
-    for (var property in window) {
-        if (property == 'DeviceProximityEvent')
-            return true;
-    }
-    return false;
-}
-
 shouldBeTrue("typeof window.DeviceProximityEvent == 'object'");
 shouldBeFalse("typeof window.DeviceProximityEvent == 'function'");
-shouldBeTrue("hasDeviceProximityEventProperty()");
+shouldBeFalse("window.propertyIsEnumerable('DeviceProximityEvent')");
 shouldBeTrue("'DeviceProximityEvent' in window");
 shouldBeTrue("window.hasOwnProperty('DeviceProximityEvent')");