All mouse events after a right click are ignored when they came from WebkitTestRunner
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 29 Feb 2012 00:37:05 +0000 (00:37 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 29 Feb 2012 00:37:05 +0000 (00:37 +0000)
https://bugs.webkit.org/show_bug.cgi?id=77350

Patch by Hugo Parente Lima <hugo.lima@openbossa.org> on 2012-02-28
Reviewed by Chang Shu.

Source/WebKit2:

Never ignore mouse events when using sync events, even if the context menu is being
show but the Ui did replied the ShowContextMenu event with a ContextMenuHidden.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::mouseEventSyncForTesting):

LayoutTests:

Unskip fast/events/mouse-click-events.html.

* platform/qt-5.0-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/qt-5.0-wk2/Skipped
Source/WebKit2/ChangeLog
Source/WebKit2/WebProcess/WebPage/WebPage.cpp

index d2c4c35..cea0e2b 100644 (file)
@@ -1,3 +1,14 @@
+2012-02-28  Hugo Parente Lima  <hugo.lima@openbossa.org>
+
+        All mouse events after a right click are ignored when they came from WebkitTestRunner
+        https://bugs.webkit.org/show_bug.cgi?id=77350
+
+        Reviewed by Chang Shu.
+
+        Unskip fast/events/mouse-click-events.html.
+
+        * platform/qt-5.0-wk2/Skipped:
+
 2012-02-28  Rafael Brandao  <rafael.lobo@openbossa.org>
 
         [Qt] Unskip compositing & 3d-rendering tests
index bcc1051..6984de3 100644 (file)
@@ -54,7 +54,6 @@ fast/events/context-onmousedown-event.html
 fast/events/contextmenu-scrolled-page-with-frame.html
 fast/events/continuous-platform-wheelevent-in-scrolling-div.html
 fast/events/fire-mousedown-while-pressing-mouse-button.html
-fast/events/mouse-click-events.html
 fast/events/mouseup-from-button2.html
 fast/events/open-window-from-another-frame.html
 fast/events/platform-wheelevent-in-scrolling-div.html
index d50b694..78052b8 100644 (file)
@@ -1,3 +1,16 @@
+2012-02-28  Hugo Parente Lima  <hugo.lima@openbossa.org>
+
+        All mouse events after a right click are ignored when they came from WebkitTestRunner
+        https://bugs.webkit.org/show_bug.cgi?id=77350
+
+        Reviewed by Chang Shu.
+
+        Never ignore mouse events when using sync events, even if the context menu is being
+        show but the Ui did replied the ShowContextMenu event with a ContextMenuHidden.
+
+        * WebProcess/WebPage/WebPage.cpp:
+        (WebKit::WebPage::mouseEventSyncForTesting):
+
 2012-02-28  Alexey Proskuryakov  <ap@apple.com>
 
         More build fix.
index 057a928..03d0c70 100644 (file)
@@ -1299,12 +1299,6 @@ void WebPage::mouseEvent(const WebMouseEvent& mouseEvent)
 
 void WebPage::mouseEventSyncForTesting(const WebMouseEvent& mouseEvent, bool& handled)
 {
-    // Don't try to handle any pending mouse events if a context menu is showing.
-    if (m_isShowingContextMenu) {
-        handled = true;
-        return;
-    }
-
     handled = m_pageOverlay && m_pageOverlay->mouseEvent(mouseEvent);
 
     if (!handled) {