Unreviewed, rolling out r252416, vimeo does not work
authorysuzuki@apple.com <ysuzuki@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 4 Dec 2019 23:01:57 +0000 (23:01 +0000)
committerysuzuki@apple.com <ysuzuki@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 4 Dec 2019 23:01:57 +0000 (23:01 +0000)
https://bugs.webkit.org/show_bug.cgi?id=204141

JSTests:

* stress/generator-cell-with-type.js: Removed.

Source/JavaScriptCore:

* dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@253124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

JSTests/ChangeLog
JSTests/stress/generator-cell-with-type.js [deleted file]
Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h

index 5c9de8c..d577f76 100644 (file)
@@ -1,5 +1,12 @@
 2019-12-04  Yusuke Suzuki  <ysuzuki@apple.com>
 
+        Unreviewed, rolling out r252416, vimeo does not work
+        https://bugs.webkit.org/show_bug.cgi?id=204141
+
+        * stress/generator-cell-with-type.js: Removed.
+
+2019-12-04  Yusuke Suzuki  <ysuzuki@apple.com>
+
         [JSC] JSWebAssemblyGlobal creation should have exception check
         https://bugs.webkit.org/show_bug.cgi?id=204857
         <rdar://problem/57618579>
diff --git a/JSTests/stress/generator-cell-with-type.js b/JSTests/stress/generator-cell-with-type.js
deleted file mode 100644 (file)
index fdc6e88..0000000
+++ /dev/null
@@ -1,45 +0,0 @@
-// This test takes too long on arm and mips devices.
-//@ skip if ["arm", "mips"].include?($architecture)
-function shouldBe(actual, expected) {
-    if (actual !== expected)
-        throw new Error('bad value: ' + actual);
-}
-
-function shouldThrow(func, errorMessage) {
-    var errorThrown = false;
-    var error = null;
-    try {
-        func();
-    } catch (e) {
-        errorThrown = true;
-        error = e;
-    }
-    if (!errorThrown)
-        throw new Error('not thrown');
-    if (String(error) !== errorMessage)
-        throw new Error(`bad error: ${String(error)}`);
-}
-
-function *generator()
-{
-}
-
-function test(gen)
-{
-    var func = gen.next;
-    shouldBe(gen.next().done, true);
-    return func;
-}
-noInline(test);
-var gen = generator();
-for (var i = 0; i < 1e6; ++i)
-    test(gen);
-
-for (var i = 0; i < 1e6; ++i) {
-    test(gen);
-    shouldThrow(() => {
-        test({
-            __proto__: gen.__proto__
-        });
-    }, `TypeError: |this| should be a generator`);
-}
index eba3bfd..6250ffd 100644 (file)
@@ -1,5 +1,13 @@
 2019-12-04  Yusuke Suzuki  <ysuzuki@apple.com>
 
+        Unreviewed, rolling out r252416, vimeo does not work
+        https://bugs.webkit.org/show_bug.cgi?id=204141
+
+        * dfg/DFGAbstractInterpreterInlines.h:
+        (JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
+
+2019-12-04  Yusuke Suzuki  <ysuzuki@apple.com>
+
         [JSC] JSWebAssemblyGlobal creation should have exception check
         https://bugs.webkit.org/show_bug.cgi?id=204857
         <rdar://problem/57618579>
index 273b8e0..f91d4f4 100644 (file)
@@ -1444,35 +1444,6 @@ bool AbstractInterpreter<AbstractStateType>::executeEffects(unsigned clobberLimi
             if (constantWasSet)
                 break;
         }
-
-        if (forNode(node->child1()).m_structure.isFinite()) {
-            bool constantWasSet = false;
-            switch (node->op()) {
-            case IsCellWithType: {
-                bool ok = true;
-                Optional<bool> result;
-                forNode(node->child1()).m_structure.forEach(
-                    [&](RegisteredStructure structure) {
-                        bool matched = structure->typeInfo().type() == node->queriedType();
-                        if (!result)
-                            result = matched;
-                        else {
-                            if (result.value() != matched)
-                                ok = false;
-                        }
-                    });
-                if (ok && result) {
-                    setConstant(node, jsBoolean(result.value()));
-                    constantWasSet = true;
-                }
-                break;
-            }
-            default:
-                break;
-            }
-            if (constantWasSet)
-                break;
-        }
         
         // FIXME: This code should really use AbstractValue::isType() and
         // AbstractValue::couldBeType().