[EFL] Enable the CUSTOM_SCHEME_HANDLER feature as default.
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 5 Jul 2012 10:52:48 +0000 (10:52 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 5 Jul 2012 10:52:48 +0000 (10:52 +0000)
https://bugs.webkit.org/show_bug.cgi?id=88608

Patch by Dongwoo Im <dw.im@samsung.com> on 2012-07-05
Reviewed by Hajime Morita.

.:

* Source/cmake/OptionsEfl.cmake: Enable the CUSTOM_SCHEME_HANDLER feature as default.

Source/WebKit2:

* WebProcess/WebCoreSupport/WebChromeClient.h:
(WebKit::WebChromeClient::isProtocolHandlerRegistered): Add a stub function.
(WebKit::WebChromeClient::unregisterProtocolHandler): Add a stub function.
(WebChromeClient):

Tools:

* Scripts/webkitperl/FeatureList.pm: Enable the CUSTOM_SCHEME_HANDLER feature as default.

LayoutTests:

* platform/efl/fast/dom/unregister-protocol-handler-expected.txt: Expected result of the EFL port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ChangeLog
LayoutTests/ChangeLog
LayoutTests/platform/efl/fast/dom/unregister-protocol-handler-expected.txt [new file with mode: 0644]
Source/WebKit2/ChangeLog
Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h
Source/cmake/OptionsEfl.cmake
Tools/ChangeLog
Tools/Scripts/webkitperl/FeatureList.pm

index 4812c5a..a1c5651 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2012-07-05  Dongwoo Im  <dw.im@samsung.com>
+
+        [EFL] Enable the CUSTOM_SCHEME_HANDLER feature as default.
+        https://bugs.webkit.org/show_bug.cgi?id=88608
+
+        Reviewed by Hajime Morita.
+
+        * Source/cmake/OptionsEfl.cmake: Enable the CUSTOM_SCHEME_HANDLER feature as default.
+
 2012-07-05  Ryuan Choi  <ryuan.choi@samsung.com>
 
         [Wk2][EFL] EFL needs a WebKitTestRunner
index 8f394f7..da23f5a 100644 (file)
@@ -1,3 +1,12 @@
+2012-07-05  Dongwoo Im  <dw.im@samsung.com>
+
+        [EFL] Enable the CUSTOM_SCHEME_HANDLER feature as default.
+        https://bugs.webkit.org/show_bug.cgi?id=88608
+
+        Reviewed by Hajime Morita.
+
+        * platform/efl/fast/dom/unregister-protocol-handler-expected.txt: Expected result of the EFL port.
+
 2012-07-05  Krist√≥f Koszty√≥  <kkristof@inf.u-szeged.hu>
 
         [Qt] Unreviewed gardening after r121891.
diff --git a/LayoutTests/platform/efl/fast/dom/unregister-protocol-handler-expected.txt b/LayoutTests/platform/efl/fast/dom/unregister-protocol-handler-expected.txt
new file mode 100644 (file)
index 0000000..a831d08
--- /dev/null
@@ -0,0 +1,20 @@
+This test makes sure that navigator.unregisterProtocolHandler throws the proper exceptions and has no-op default implementation.
+
+Pass: window.navigator.unregisterProtocolHandler is defined.
+Pass: Invalid protocol "http" threw SECURITY_ERR exception.
+Pass: Invalid protocol "https" threw SECURITY_ERR exception.
+Pass: Invalid protocol "file" threw SECURITY_ERR exception.
+Pass: Valid protocol "irc" allowed.
+Pass: Valid protocol "mailto" allowed.
+Pass: Valid protocol "mms" allowed.
+Pass: Valid protocol "news" allowed.
+Pass: Valid protocol "nntp" allowed.
+Pass: Valid protocol "sms" allowed.
+Pass: Valid protocol "smsto" allowed.
+Pass: Valid protocol "tel" allowed.
+Pass: Valid protocol "urn" allowed.
+Pass: Valid protocol "webcal" allowed.
+Pass: Invalid url "" threw SYNTAX_ERR exception.
+Pass: Invalid url "%S" threw SYNTAX_ERR exception.
+Pass: Valid call succeeded.
+
index 21c1b49..772b81e 100644 (file)
@@ -1,3 +1,15 @@
+2012-07-05  Dongwoo Im  <dw.im@samsung.com>
+
+        [EFL] Enable the CUSTOM_SCHEME_HANDLER feature as default.
+        https://bugs.webkit.org/show_bug.cgi?id=88608
+
+        Reviewed by Hajime Morita.
+
+        * WebProcess/WebCoreSupport/WebChromeClient.h:
+        (WebKit::WebChromeClient::isProtocolHandlerRegistered): Add a stub function.
+        (WebKit::WebChromeClient::unregisterProtocolHandler): Add a stub function.
+        (WebChromeClient):
+
 2012-07-05  Ryuan Choi  <ryuan.choi@samsung.com>
 
         [Wk2][EFL] EFL needs a WebKitTestRunner
index 18e04db..44eccff 100644 (file)
@@ -220,6 +220,11 @@ private:
     virtual void registerProtocolHandler(const String& scheme, const String& baseURL, const String& url, const String& title) OVERRIDE { }
 #endif
 
+#if ENABLE(CUSTOM_SCHEME_HANDLER)
+    virtual CustomHandlersState isProtocolHandlerRegistered(const String&, const String&, const String&) { return CustomHandlersDeclined; }
+    virtual void unregisterProtocolHandler(const String&, const String&, const String&) { }
+#endif
+
     String m_cachedToolTip;
     mutable RefPtr<WebFrame> m_cachedFrameSetLargestFrame;
     mutable bool m_cachedMainFrameHasHorizontalScrollbar;
index a47b22d..a8909d7 100644 (file)
@@ -71,6 +71,7 @@ WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_BATTERY_STATUS ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_BLOB ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_IMAGE_SET ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_VARIABLES ON)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CUSTOM_SCHEME_HANDLER ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DATALIST ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DRAG_SUPPORT ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FAST_MOBILE_SCROLLING ON)
index 8ce62df..0d5bb0f 100644 (file)
@@ -1,3 +1,12 @@
+2012-07-05  Dongwoo Im  <dw.im@samsung.com>
+
+        [EFL] Enable the CUSTOM_SCHEME_HANDLER feature as default.
+        https://bugs.webkit.org/show_bug.cgi?id=88608
+
+        Reviewed by Hajime Morita.
+
+        * Scripts/webkitperl/FeatureList.pm: Enable the CUSTOM_SCHEME_HANDLER feature as default.
+
 2012-07-05  Ryuan Choi  <ryuan.choi@samsung.com>
 
         [Wk2][EFL] EFL needs a WebKitTestRunner
index 86f102d..407fbb9 100644 (file)
@@ -178,7 +178,7 @@ my @features = (
       define => "ENABLE_CSS_VARIABLES", default => isEfl(), value => \$cssVariablesSupport },
 
     { option => "custom-scheme-handler", desc => "Toggle Custom Scheme Handler support",
-      define => "ENABLE_CUSTOM_SCHEME_HANDLER", default => isBlackBerry(), value => \$customSchemeHandlerSupport },
+      define => "ENABLE_CUSTOM_SCHEME_HANDLER", default => (isBlackBerry() || isEfl()), value => \$customSchemeHandlerSupport },
 
     { option => "datalist", desc => "Toggle Datalist support",
       define => "ENABLE_DATALIST", default => isEfl(), value => \$datalistSupport },