Improve NowPlaying "title"
authoreric.carlson@apple.com <eric.carlson@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 21 May 2018 21:28:16 +0000 (21:28 +0000)
committereric.carlson@apple.com <eric.carlson@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 21 May 2018 21:28:16 +0000 (21:28 +0000)
https://bugs.webkit.org/show_bug.cgi?id=185680
<rdar://problem/40296700>

Unreviewed test fix.

* http/tests/media/now-playing-info-expected.txt:
* http/tests/media/now-playing-info.html: Don't test .elapsedTime before seeking because
the time value can take a while to "settle" when a file has just loaded.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@232026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/http/tests/media/now-playing-info-expected.txt
LayoutTests/http/tests/media/now-playing-info.html

index 8f6a624..6a17bb0 100644 (file)
@@ -1,3 +1,15 @@
+2018-05-21  Eric Carlson  <eric.carlson@apple.com>
+
+        Improve NowPlaying "title"
+        https://bugs.webkit.org/show_bug.cgi?id=185680
+        <rdar://problem/40296700>
+
+        Unreviewed test fix.
+
+        * http/tests/media/now-playing-info-expected.txt:
+        * http/tests/media/now-playing-info.html: Don't test .elapsedTime before seeking because
+        the time value can take a while to "settle" when a file has just loaded.
+
 2018-05-21  Jer Noble  <jer.noble@apple.com>
 
         Complete fix for enabling modern EME by default
index 5c85b1d..dbc3c05 100644 (file)
@@ -17,7 +17,6 @@ RUN(nowPlayingState = internals.nowPlayingState)
 EXPECTED (nowPlayingState.registeredAsNowPlayingApplication == 'true') OK
 EXPECTED (nowPlayingState.title == 'Page Title') OK
 EXPECTED (nowPlayingState.duration > '0') OK
-EXPECTED (nowPlayingState.elapsedTime >= '0') OK
 
 * Set video title, it should be used.
 RUN(video.title = "Video Title")
index b60220e..a39bad0 100644 (file)
@@ -47,7 +47,6 @@
                 testExpected('nowPlayingState.registeredAsNowPlayingApplication', true);
                 testExpected('nowPlayingState.title', 'Page Title');
                 testExpected('nowPlayingState.duration', '0', '>');
-                testExpected('nowPlayingState.elapsedTime', '0', '>=');
                 previousNowPlayingState = nowPlayingState;
 
 
@@ -64,8 +63,6 @@
                 // because the values will be different from run to run.
                 if (nowPlayingState.uniqueIdentifier != previousNowPlayingState.uniqueIdentifier)
                     testExpected('nowPlayingState.uniqueIdentifier', previousNowPlayingState.uniqueIdentifier);
-                if (nowPlayingState.elapsedTime != previousNowPlayingState.elapsedTime)
-                    testExpected('nowPlayingState.elapsedTime', previousNowPlayingState.elapsedTime);
                 previousNowPlayingState = nowPlayingState;
 
                 consoleWrite('<br>* Clear video and page titles, page domain should be used.');
@@ -79,8 +76,6 @@
                 testExpected('nowPlayingState.duration', '0', '>');
                 if (nowPlayingState.uniqueIdentifier != previousNowPlayingState.uniqueIdentifier)
                     testExpected('nowPlayingState.uniqueIdentifier', previousNowPlayingState.uniqueIdentifier);
-                if (nowPlayingState.elapsedTime != previousNowPlayingState.elapsedTime)
-                    testExpected('nowPlayingState.elapsedTime', previousNowPlayingState.elapsedTime);
                 previousNowPlayingState = nowPlayingState;
 
                 consoleWrite('<br>* Change currentTime, state should be updated.');