LayoutTest storage/indexeddb/dont-wedge-private.html is a flaky failure
authorbeidson@apple.com <beidson@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 17 May 2018 00:33:34 +0000 (00:33 +0000)
committerbeidson@apple.com <beidson@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 17 May 2018 00:33:34 +0000 (00:33 +0000)
<rdar://problem/38975304> and https://bugs.webkit.org/show_bug.cgi?id=184058

Reviewed by Andy Estes.

Make the asynchronous IDB part of this test take way, way longer to always give the location change a chance to happen.

* TestExpectations:
* storage/indexeddb/dont-wedge-expected.txt:
* storage/indexeddb/dont-wedge-private-expected.txt:
* storage/indexeddb/resources/dont-wedge.js:
(openDatabase1.request.onupgradeneeded.openOnUpgradeNeeded1.putter):
(openDatabase1.request.onupgradeneeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@231880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/TestExpectations
LayoutTests/storage/indexeddb/dont-wedge-expected.txt
LayoutTests/storage/indexeddb/dont-wedge-private-expected.txt
LayoutTests/storage/indexeddb/resources/dont-wedge.js

index 460da16..14c0afc 100644 (file)
@@ -1,3 +1,19 @@
+2018-05-16  Brady Eidson  <beidson@apple.com>
+
+        LayoutTest storage/indexeddb/dont-wedge-private.html is a flaky failure
+        <rdar://problem/38975304> and https://bugs.webkit.org/show_bug.cgi?id=184058
+
+        Reviewed by Andy Estes.
+
+        Make the asynchronous IDB part of this test take way, way longer to always give the location change a chance to happen.
+
+        * TestExpectations:
+        * storage/indexeddb/dont-wedge-expected.txt:
+        * storage/indexeddb/dont-wedge-private-expected.txt:
+        * storage/indexeddb/resources/dont-wedge.js:
+        (openDatabase1.request.onupgradeneeded.openOnUpgradeNeeded1.putter):
+        (openDatabase1.request.onupgradeneeded):
+
 2018-05-16  Ross Kirsling  <ross.kirsling@sony.com>
 
         [WinCairo] Unreviewed gardening before WinCairoRequirements update.
index d8ad7a1..e6545f1 100644 (file)
@@ -1896,8 +1896,6 @@ webkit.org/b/116621 fast/replaced/preferred-widths.html [ Pass Failure ]
 
 webkit.org/b/184198 imported/w3c/web-platform-tests/html/browsers/offline/appcache/workers/appcache-worker.html [ Pass Failure ]
 
-webkit.org/b/184058 storage/indexeddb/dont-wedge-private.html [ Pass Failure ]
-
 webkit.org/b/184061 http/tests/appcache/interrupted-update.html [ Pass Failure ]
 
 webkit.org/b/184453 imported/w3c/web-platform-tests/workers/name-property.html [ Pass Failure ]
index b566488..2498ac7 100644 (file)
@@ -19,9 +19,6 @@ openDatabase1():
 indexedDB.open(dbname1, 1)
 
 openOnUpgradeNeeded1():
-db1 = event.target.result
-store1 = db1.createObjectStore('store')
-store1.put(0, 0)
 
 openOnSuccess1():
 PASS isAfterReload() is true
index b566488..2498ac7 100644 (file)
@@ -19,9 +19,6 @@ openDatabase1():
 indexedDB.open(dbname1, 1)
 
 openOnUpgradeNeeded1():
-db1 = event.target.result
-store1 = db1.createObjectStore('store')
-store1.put(0, 0)
 
 openOnSuccess1():
 PASS isAfterReload() is true
index 690ca5f..2f8141c 100644 (file)
@@ -54,9 +54,16 @@ function openDatabase1()
     request.onblocked = unexpectedBlockedCallback;
     request.onupgradeneeded = function openOnUpgradeNeeded1(evt) {
         preamble(evt);
-        evalAndLog("db1 = event.target.result");
-        evalAndLog("store1 = db1.createObjectStore('store')");
-        evalAndLog("store1.put(0, 0)");
+        db1 = event.target.result;
+               store1 = db1.createObjectStore('store');
+        var count = 0;
+        function putter() {
+                       ++count;
+                       if (count == 50)
+                               return;
+            store1.put(0, 0).onsuccess = putter;
+        }
+        putter();
     };
     request.onsuccess = function openOnSuccess1(evt) {
         preamble(evt);