[Mac] Layout Test http/wpt/webauthn/public-key-credential-create-success-hid.https...
authorjiewen_tan@apple.com <jiewen_tan@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 6 Dec 2018 02:28:23 +0000 (02:28 +0000)
committerjiewen_tan@apple.com <jiewen_tan@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 6 Dec 2018 02:28:23 +0000 (02:28 +0000)
https://bugs.webkit.org/show_bug.cgi?id=192061

Reviewed by Dewei Zhu.

Part 1.

Add some loggings to determine possible causes for the flakiness.

* UIProcess/WebAuthentication/Cocoa/HidService.mm:
(WebKit::HidService::continueAddDeviceAfterGetInfo):
* UIProcess/WebAuthentication/Mock/MockHidService.cpp:
(WebKit::MockHidService::platformStartDiscovery):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/ChangeLog
Source/WebKit/UIProcess/WebAuthentication/Cocoa/HidService.mm
Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidService.cpp

index bc6fa2f..caeb614 100644 (file)
@@ -1,3 +1,19 @@
+2018-12-05  Jiewen Tan  <jiewen_tan@apple.com>
+
+        [Mac] Layout Test http/wpt/webauthn/public-key-credential-create-success-hid.https.html and http/wpt/webauthn/public-key-credential-get-success-hid.https.html are flaky
+        https://bugs.webkit.org/show_bug.cgi?id=192061
+
+        Reviewed by Dewei Zhu.
+
+        Part 1.
+
+        Add some loggings to determine possible causes for the flakiness.
+
+        * UIProcess/WebAuthentication/Cocoa/HidService.mm:
+        (WebKit::HidService::continueAddDeviceAfterGetInfo):
+        * UIProcess/WebAuthentication/Mock/MockHidService.cpp:
+        (WebKit::MockHidService::platformStartDiscovery):
+
 2018-12-05  Chris Dumez  <cdumez@apple.com>
 
         Simplify logic inside WebPageProxy::continueNavigationInNewProcess()
index 2b386e0..988e96b 100644 (file)
@@ -115,6 +115,7 @@ void HidService::continueAddDeviceAfterGetInfo(CtapHidDriver* ptr, Vector<uint8_
         return;
     }
     // FIXME(191535): Support U2F authenticators.
+    LOG_ERROR("Couldn't parse a ctap get info response.");
 }
 
 } // namespace WebKit
index b35a873..958764f 100644 (file)
@@ -43,6 +43,7 @@ void MockHidService::platformStartDiscovery()
 {
     if (!!m_configuration.hid)
         deviceAdded(nullptr);
+    LOG_ERROR("No hid authenticators is available.");
 }
 
 UniqueRef<HidConnection> MockHidService::createHidConnection(IOHIDDeviceRef device) const