REGRESSION(r201956): Failure to initialize new internal settings produced random...
authorenrica@apple.com <enrica@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 14 Jun 2016 00:17:44 +0000 (00:17 +0000)
committerenrica@apple.com <enrica@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 14 Jun 2016 00:17:44 +0000 (00:17 +0000)
https://bugs.webkit.org/show_bug.cgi?id=158713
rdar://26769957

Reviewed by Simon Fraser.

Failed to initialize the new member variable in both Settings and InternalSettings classes.

* page/Settings.cpp:
(WebCore::Settings::Settings):
* testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/page/Settings.cpp
Source/WebCore/testing/InternalSettings.cpp

index 4799163..e31417b 100644 (file)
@@ -1,3 +1,18 @@
+2016-06-13  Enrica Casucci  <enrica@apple.com>
+
+        REGRESSION(r201956): Failure to initialize new internal settings produced random test failures in release.
+        https://bugs.webkit.org/show_bug.cgi?id=158713
+        rdar://26769957
+
+        Reviewed by Simon Fraser.
+
+        Failed to initialize the new member variable in both Settings and InternalSettings classes.
+
+        * page/Settings.cpp:
+        (WebCore::Settings::Settings):
+        * testing/InternalSettings.cpp:
+        (WebCore::InternalSettings::Backup::Backup):
+
 2016-06-13  Chris Dumez  <cdumez@apple.com>
 
         Drop HipChat hack introduced in r197548
index b415463..99333fa 100644 (file)
@@ -192,6 +192,7 @@ Settings::Settings(Page* page)
     , m_isJavaEnabledForLocalFiles(true)
     , m_loadsImagesAutomatically(false)
     , m_areImagesEnabled(true)
+    , m_preferMIMETypeForImages(false)
     , m_arePluginsEnabled(false)
     , m_isScriptEnabled(false)
     , m_needsAdobeFrameReloadingQuirk(false)
index 1b29784..fbd19aa 100644 (file)
@@ -79,6 +79,7 @@ InternalSettings::Backup::Backup(Settings& settings)
     , m_originalMockScrollbarsEnabled(settings.mockScrollbarsEnabled())
     , m_langAttributeAwareFormControlUIEnabled(RuntimeEnabledFeatures::sharedFeatures().langAttributeAwareFormControlUIEnabled())
     , m_imagesEnabled(settings.areImagesEnabled())
+    , m_preferMIMETypeForImages(settings.preferMIMETypeForImages())
     , m_minimumTimerInterval(settings.minimumDOMTimerInterval())
 #if ENABLE(VIDEO_TRACK)
     , m_shouldDisplaySubtitles(settings.shouldDisplaySubtitles())