2011-04-15 John Bates <jbates@google.com>
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 16 Apr 2011 04:40:22 +0000 (04:40 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 16 Apr 2011 04:40:22 +0000 (04:40 +0000)
        Reviewed by Kenneth Russell.

        Change WebGraphicsContext3D virtuals to pure virtuals as intended
        https://bugs.webkit.org/show_bug.cgi?id=58479

        * public/WebGraphicsContext3D.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/chromium/ChangeLog
Source/WebKit/chromium/public/WebGraphicsContext3D.h

index 2957dc1..2816a6f 100644 (file)
@@ -1,3 +1,12 @@
+2011-04-15  John Bates  <jbates@google.com>
+
+        Reviewed by Kenneth Russell.
+
+        Change WebGraphicsContext3D virtuals to pure virtuals as intended
+        https://bugs.webkit.org/show_bug.cgi?id=58479
+
+        * public/WebGraphicsContext3D.h:
+
 2011-04-15  Shishir Agrawal  <shishir@chromium.org>
 
         Reviewed by James Robinson.
index ff7e502..2d7b0a5 100644 (file)
@@ -169,10 +169,10 @@ public:
     virtual void renderbufferStorageMultisampleCHROMIUM(WGC3Denum target, WGC3Dsizei samples, WGC3Denum internalformat, WGC3Dsizei width, WGC3Dsizei height) = 0;
 
     // GL_CHROMIUM_latch
-    virtual void getParentToChildLatchCHROMIUM(WGC3Duint* latchId) {} // FIXME: = 0;
-    virtual void getChildToParentLatchCHROMIUM(WGC3Duint* latchId) {} // FIXME: = 0;
-    virtual void waitLatchCHROMIUM(WGC3Duint latchId) {} // FIXME: = 0;
-    virtual void setLatchCHROMIUM(WGC3Duint latchId) {} // FIXME: = 0;
+    virtual void getParentToChildLatchCHROMIUM(WGC3Duint* latchId) = 0;
+    virtual void getChildToParentLatchCHROMIUM(WGC3Duint* latchId) = 0;
+    virtual void waitLatchCHROMIUM(WGC3Duint latchId) = 0;
+    virtual void setLatchCHROMIUM(WGC3Duint latchId) = 0;
 
     // The entry points below map directly to the OpenGL ES 2.0 API.
     // See: http://www.khronos.org/registry/gles/