[LFC] Do not check margin box while validating geometry.
authorzalan@apple.com <zalan@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 3 Aug 2018 14:21:21 +0000 (14:21 +0000)
committerzalan@apple.com <zalan@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 3 Aug 2018 14:21:21 +0000 (14:21 +0000)
https://bugs.webkit.org/show_bug.cgi?id=188297

Reviewed by Antti Koivisto.

The current RenderBox::marginBox implementation is not spec compliant. Ignore it for now.

* layout/Verification.cpp:
(WebCore::Layout::outputMismatchingBlockBoxInformationIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/layout/Verification.cpp

index 0234a6a..11ff0f5 100644 (file)
@@ -1,3 +1,15 @@
+2018-08-03  Zalan Bujtas  <zalan@apple.com>
+
+        [LFC] Do not check margin box while validating geometry.
+        https://bugs.webkit.org/show_bug.cgi?id=188297
+
+        Reviewed by Antti Koivisto.
+
+        The current RenderBox::marginBox implementation is not spec compliant. Ignore it for now.
+
+        * layout/Verification.cpp:
+        (WebCore::Layout::outputMismatchingBlockBoxInformationIfNeeded):
+
 2018-08-03  Carlos Garcia Campos  <cgarcia@igalia.com>
 
         [WPE] Use WPE key symbols and new API instead of xkbcommon and the key mapper
index e211a7d..23d60af 100644 (file)
@@ -134,11 +134,6 @@ static bool outputMismatchingBlockBoxInformationIfNeeded(TextStream& stream, con
         return true;
     }
 
-    if (renderer.marginBoxRect() != displayBox->nonCollapsedMarginBox()) {
-        outputRect("marginBox", renderer.marginBoxRect(), displayBox->nonCollapsedMarginBox());
-        return true;
-    }
-
     if (renderer.borderBoxRect() != displayBox->borderBox()) {
         outputRect("borderBox", renderer.borderBoxRect(), displayBox->borderBox());
         return true;
@@ -154,6 +149,7 @@ static bool outputMismatchingBlockBoxInformationIfNeeded(TextStream& stream, con
         return true;
     }
 
+    // TODO: The RenderBox::marginBox() does not follow the spec and ignores certain constraints. Skip them for now.
     return false;
 }