New test inspector-protocol/page/archive.html added in r154828 fails on EFL, Qt, GTK
authoryurys@chromium.org <yurys@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 9 Nov 2019 06:27:57 +0000 (06:27 +0000)
committeryurys@chromium.org <yurys@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 9 Nov 2019 06:27:57 +0000 (06:27 +0000)
https://bugs.webkit.org/show_bug.cgi?id=120682

Reviewed by Devin Rousso.

Generate custom expectations for inspector-protocol/page/archive.html on the platforms
where Page.archive is not supported yet.

* inspector/page/archive.html: 'Not supported' is a valid response on some platforms.
* platform/gtk/TestExpectations:
* platform/gtk/inspector/page/archive-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@252305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/inspector/page/archive.html
LayoutTests/platform/gtk/TestExpectations
LayoutTests/platform/gtk/inspector/page/archive-expected.txt [new file with mode: 0644]

index 2e29081..38a955d 100644 (file)
@@ -1,3 +1,17 @@
+2019-11-08  Yury Semikhatsky  <yurys@chromium.org>
+
+        New test inspector-protocol/page/archive.html added in r154828 fails on EFL, Qt, GTK
+        https://bugs.webkit.org/show_bug.cgi?id=120682
+
+        Reviewed by Devin Rousso.
+
+        Generate custom expectations for inspector-protocol/page/archive.html on the platforms
+        where Page.archive is not supported yet.
+
+        * inspector/page/archive.html: 'Not supported' is a valid response on some platforms.
+        * platform/gtk/TestExpectations:
+        * platform/gtk/inspector/page/archive-expected.txt: Added.
+
 2019-11-08  Peng Liu  <peng.liu6@apple.com>
 
         Entering/Exiting Picture-in-Picture mode through webkitSetPresentationMode() does not fire events (enterpictureinpicture and leavepictureinpicture) defined in the spec
index 80691d0..68c2e97 100644 (file)
@@ -6,14 +6,17 @@ function test()
 {
     InspectorProtocol.sendCommand("Page.enable", {});
     InspectorProtocol.sendCommand("Page.archive", {}, function(event) {
-        var data = event.result.data;
-        if (!data)
-            ProtocolTest.log("FAIL: no data");
-        else if (data.length < 1000)
-            ProtocolTest.log("FAIL: unexpectedly short data. A serialized archive should be pretty large.");
-        else
-            ProtocolTest.log("PASS: Received archive data.");
-
+        if (event.error) {
+            ProtocolTest.fail(`Page.archive returned error: '${event.error.message}'.`);
+        } else {
+            let data = event.result.data;
+            if (!data)
+                ProtocolTest.fail("no data");
+            else if (data.length < 1000)
+                ProtocolTest.fail("unexpectedly short data. A serialized archive should be pretty large.");
+            else
+                ProtocolTest.pass("Received archive data.");
+        }
         ProtocolTest.completeTest();
     });
 }
index f189cea..31f08c8 100644 (file)
@@ -2318,8 +2318,6 @@ webkit.org/b/108925 http/tests/media/video-play-stall.html [ Failure Timeout ]
 
 webkit.org/b/116957 media/track/track-automatic-subtitles.html [ Timeout ]
 
-webkit.org/b/120682 inspector/page/archive.html [ Timeout ]
-
 webkit.org/b/147518 inspector/debugger/nested-inspectors.html [ Timeout ]
 
 Bug(GTK) plugins/reloadplugins-and-pages.html [ Timeout ]
diff --git a/LayoutTests/platform/gtk/inspector/page/archive-expected.txt b/LayoutTests/platform/gtk/inspector/page/archive-expected.txt
new file mode 100644 (file)
index 0000000..5d901db
--- /dev/null
@@ -0,0 +1,2 @@
+FAIL: Page.archive returned error: 'Not supported'.
+