Add API tests to the Dashbord page.
authorap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 9 Oct 2013 21:58:28 +0000 (21:58 +0000)
committerap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 9 Oct 2013 21:58:28 +0000 (21:58 +0000)
https://bugs.webkit.org/show_bug.cgi?id=122283

Patch by Timothy Hatcher <timothy@apple.com> on 2013-10-09
Reviewed by Timothy Hatcher.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
(BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot.prototype.apiTestResultsURLForIteration):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@157188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js
Tools/ChangeLog

index fdc4714..91fc609 100644 (file)
@@ -68,4 +68,9 @@ Buildbot.BuildArchitecture = {
 Buildbot.prototype = {
     constructor: Buildbot,
     __proto__: BaseObject.prototype,
+
+    buildPageURLForIteration: function(iteration)
+    {
+        return this.baseURL + "builders/" + encodeURIComponent(iteration.queue.id) + "/builds/" + iteration.id;
+    }
 };
index a0ef03f..607970e 100644 (file)
@@ -89,8 +89,9 @@ BuildbotTesterQueueView.prototype = {
                 } else if (!layoutTestResults.failureCount && !javascriptTestResults.failureCount && !apiTestResults.failureCount && !pythonTestResults.failureCount && !perlTestResults.failureCount && bindingTestResults.errorOccurred) {
                     var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Bad, "binding tests failed");
                 } else {
+                    var url = iteration.queue.buildbot.buildPageURLForIteration(iteration);
                     var totalFailures = layoutTestResults.failureCount + javascriptTestResults.failureCount + apiTestResults.failureCount + pythonTestResults.failureCount + perlTestResults.failureCount + bindingTestResults.errorOccurred;
-                    var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Bad, totalFailures === 1 ? "test failure" : "test failures", totalFailures);
+                    var status = new StatusLineView(messageLinkElement, StatusLineView.Status.Bad, totalFailures === 1 ? "test failure" : "test failures", totalFailures, url);
                 }
 
                 this.element.appendChild(status.element);
index 47cd166..235a0e0 100644 (file)
 
 2013-10-09  Alexey Proskuryakov  <ap@apple.com>
 
+        build.webkit.org/dashboard doesn't provide a results link when there issues at multiple steps
+        https://bugs.webkit.org/show_bug.cgi?id=122573
+
+        Reviewed by Tim Hatcher.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
+        (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Provide a URL.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
+        (Buildbot.prototype.buildPageURLForIteration): Added.
+
+2013-10-09  Alexey Proskuryakov  <ap@apple.com>
+
         http://build.webkit.org/dashboard/ links to a wrong jscore-test results page
         https://bugs.webkit.org/show_bug.cgi?id=122569