https://bugs.webkit.org/show_bug.cgi?id=139779
authorap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 18 Dec 2014 19:24:08 +0000 (19:24 +0000)
committerap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 18 Dec 2014 19:24:08 +0000 (19:24 +0000)
Fullscreen tests use unreasonably short timeouts

Reviewed by Eric Carlson.

* fullscreen/exit-full-screen-iframe.html:
* fullscreen/full-screen-iframe-allowed-prefixed.html:
* fullscreen/full-screen-iframe-allowed.html:
* fullscreen/full-screen-iframe-legacy.html:
* fullscreen/full-screen-iframe-without-allow-attribute-allowed-from-parent.html:
* fullscreen/resources/full-screen-iframe-with-mixed-allow-webkitallow-iframe2.html:
Removed the timeouts.

* platform/mac-wk1/TestExpectations: fullscreen/exit-full-screen-iframe.html
legitimately fails in DumpRenderTree, which we didn't know about.

* platform/mac/TestExpectations: Removed tests that should no longer be flaky now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@177507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/fullscreen/exit-full-screen-iframe.html
LayoutTests/fullscreen/full-screen-iframe-allowed-prefixed.html
LayoutTests/fullscreen/full-screen-iframe-allowed.html
LayoutTests/fullscreen/full-screen-iframe-legacy.html
LayoutTests/fullscreen/full-screen-iframe-without-allow-attribute-allowed-from-parent.html
LayoutTests/fullscreen/resources/full-screen-iframe-with-mixed-allow-webkitallow-iframe2.html
LayoutTests/platform/mac-wk1/TestExpectations
LayoutTests/platform/mac/TestExpectations

index 3da963c..15b9eda 100644 (file)
@@ -1,3 +1,23 @@
+2014-12-18  Alexey Proskuryakov  <ap@apple.com>
+
+        https://bugs.webkit.org/show_bug.cgi?id=139779
+        Fullscreen tests use unreasonably short timeouts
+
+        Reviewed by Eric Carlson.
+
+        * fullscreen/exit-full-screen-iframe.html:
+        * fullscreen/full-screen-iframe-allowed-prefixed.html:
+        * fullscreen/full-screen-iframe-allowed.html:
+        * fullscreen/full-screen-iframe-legacy.html:
+        * fullscreen/full-screen-iframe-without-allow-attribute-allowed-from-parent.html:
+        * fullscreen/resources/full-screen-iframe-with-mixed-allow-webkitallow-iframe2.html:
+        Removed the timeouts.
+
+        * platform/mac-wk1/TestExpectations: fullscreen/exit-full-screen-iframe.html
+        legitimately fails in DumpRenderTree, which we didn't know about.
+
+        * platform/mac/TestExpectations: Removed tests that should no longer be flaky now.
+
 2014-12-18  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
 
         Remove timeout from shouldBecome* functions in js-test.js
index af52b5e..80d66ca 100644 (file)
@@ -17,12 +17,6 @@ function runTest() {
     });
 
     runWithKeyDown(function() {
-
-        setTimeout(function() {
-            consoleWrite("FAIL - did not enter and exit full screen in time!");
-            endTest();
-        }, 100);
-
         frame.contentDocument.documentElement.webkitRequestFullScreen();
     });
 }
index d5eb118..ebbdf41 100644 (file)
@@ -12,12 +12,6 @@ function runTest() {
     });
 
     runWithKeyDown(function() {
-
-        setTimeout(function() { 
-            consoleWrite("FAIL - did not enter full screen!"); 
-            endTest(); 
-        }, 50);
-
         frame.contentDocument.documentElement.webkitRequestFullScreen();
     });
 }
index 282e97b..7144d09 100644 (file)
@@ -12,12 +12,6 @@ function runTest() {
     });
 
     runWithKeyDown(function() {
-
-        setTimeout(function() { 
-            consoleWrite("FAIL - did not enter full screen!"); 
-            endTest(); 
-        }, 50);
-
         frame.contentDocument.documentElement.webkitRequestFullScreen();
     });
 }
index 4baa124..be70164 100644 (file)
@@ -9,11 +9,6 @@ function canplaythrough() {
     var frame = document.getElementById('frame');
 
     runWithKeyDown(function() {
-        setTimeout(function() { 
-            consoleWrite("FAIL - did not enter full screen!"); 
-            endTest(); 
-        }, 100);
-
         var video = frame.contentDocument.getElementsByTagName('video')[0];
         video.webkitEnterFullScreen();
     });
index 4aa92c3..da67e11 100644 (file)
@@ -17,10 +17,6 @@ window.onmessage = function (e) {
     });
 
     runWithKeyDown(function() {
-        setTimeout(function() {
-            consoleWrite("FAIL - did not enter full screen!");
-            endTest();
-        }, 50);
         frame.webkitRequestFullScreen();
     });
 }
index 787997f..c064aa2 100644 (file)
@@ -5,9 +5,6 @@
     <script>
         document.body.onclick = function() {
             document.body.webkitRequestFullScreen();
-            setTimeout(function() {
-                parent.postMessage("FAIL - did not enter full screen!", "*");
-            }, 50);
         };
         waitForEvent(document, 'webkitfullscreenchange', function() {
             parent.postMessage("SUCCEED - entered full screen!", "*");
index 213c641..eeebe86 100644 (file)
@@ -30,6 +30,8 @@ webkit.org/b/112533 media/auto-play-in-sandbox-with-allow-scripts.html [ Pass Ti
 
 webkit.org/b/139599 fast/images/animated-gif-body-outside-viewport.html [ Pass Failure Timeout ]
 
+webkit.org/b/139778 fullscreen/exit-full-screen-iframe.html [ Skip ]
+
 ### END OF (1) Failures with bug reports
 ########################################
 
index 66a6cb4..1ff39d9 100644 (file)
@@ -365,8 +365,6 @@ http/tests/security/video-cross-origin-accessfailure.html
 # Requires ENABLE(MEDIA_CAPTURE)
 fast/forms/file/file-input-capture.html
 
-webkit.org/b/85523 fullscreen/full-screen-iframe-legacy.html [ Pass Failure Timeout ]
-
 webkit.org/b/85969 http/tests/loading/post-in-iframe-with-back-navigation.html [ Failure ]
 
 webkit.org/b/86480 plugins/npruntime/delete-plugin-within-setProperty.html [ Failure ]
@@ -763,8 +761,6 @@ webkit.org/b/116244 fast/events/mouse-cursor-image-set.html [ Failure Pass ]
 
 webkit.org/b/116245 canvas/philip/tests/2d.text.draw.fontface.notinpage.html [ Pass Failure ]
 
-webkit.org/b/90708 fullscreen/exit-full-screen-iframe.html [ Pass Failure ]
-
 webkit.org/b/120387 svg/animations/svglengthlist-animation-3.html [ Pass Failure ]
 
 webkit.org/b/120923 animations/cross-fade-background-image.html [ ImageOnlyFailure ]