http/tests/security/shape-image-cors-redirect-error-message-logging-*.html tests...
authorkrollin@apple.com <krollin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 10 Apr 2018 23:06:05 +0000 (23:06 +0000)
committerkrollin@apple.com <krollin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 10 Apr 2018 23:06:05 +0000 (23:06 +0000)
https://bugs.webkit.org/show_bug.cgi?id=155634
<rdar://problem/39326489>

Reviewed by Youenn Fablet.

These tests no longer appear to be flaky. I believe they were
addressed in <https://trac.webkit.org/changeset/217069/webkit>. After
enabling the test and rebasing the results, I ran run-webkit-tests
with --repeat-each=20 --iterations=20, and then I wrapped the
run-webkit-tests command in a loop that invoked it 20 times.

* TestExpectations:
* http/tests/security/shape-image-cors-redirect-error-message-logging-1-expected.txt:
* http/tests/security/shape-image-cors-redirect-error-message-logging-2-expected.txt:
* http/tests/security/shape-image-cors-redirect-error-message-logging-3-expected.txt:
* http/tests/security/shape-image-cors-redirect-error-message-logging-4-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@230499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/TestExpectations
LayoutTests/http/tests/security/shape-image-cors-redirect-error-message-logging-1-expected.txt
LayoutTests/http/tests/security/shape-image-cors-redirect-error-message-logging-2-expected.txt
LayoutTests/http/tests/security/shape-image-cors-redirect-error-message-logging-3-expected.txt
LayoutTests/http/tests/security/shape-image-cors-redirect-error-message-logging-4-expected.txt

index c37d90b..6a8917d 100644 (file)
@@ -1,3 +1,23 @@
+2018-04-10  Keith Rollin  <krollin@apple.com>
+
+        http/tests/security/shape-image-cors-redirect-error-message-logging-*.html tests are flaky
+        https://bugs.webkit.org/show_bug.cgi?id=155634
+        <rdar://problem/39326489>
+
+        Reviewed by Youenn Fablet.
+
+        These tests no longer appear to be flaky. I believe they were
+        addressed in <https://trac.webkit.org/changeset/217069/webkit>. After
+        enabling the test and rebasing the results, I ran run-webkit-tests
+        with --repeat-each=20 --iterations=20, and then I wrapped the
+        run-webkit-tests command in a loop that invoked it 20 times.
+
+        * TestExpectations:
+        * http/tests/security/shape-image-cors-redirect-error-message-logging-1-expected.txt:
+        * http/tests/security/shape-image-cors-redirect-error-message-logging-2-expected.txt:
+        * http/tests/security/shape-image-cors-redirect-error-message-logging-3-expected.txt:
+        * http/tests/security/shape-image-cors-redirect-error-message-logging-4-expected.txt:
+
 2018-04-10  Youenn Fablet  <youenn@apple.com>
 
         Beacon redirect responses should be CORS validated
index 93f005a..611b37c 100644 (file)
@@ -1176,11 +1176,6 @@ webkit.org/b/154687 streams/pipe-to.html [ Slow ]
 
 webkit.org/b/52185 fast/css/vertical-align-baseline-rowspan-010.html [ ImageOnlyFailure ]
 
-webkit.org/b/155634 http/tests/security/shape-image-cors-redirect-error-message-logging-1.html [ Pass Failure ]
-webkit.org/b/155634 http/tests/security/shape-image-cors-redirect-error-message-logging-2.html [ Pass Failure ]
-webkit.org/b/155634 http/tests/security/shape-image-cors-redirect-error-message-logging-3.html [ Pass Failure ]
-webkit.org/b/155634 http/tests/security/shape-image-cors-redirect-error-message-logging-4.html [ Pass Failure ]
-
 # Content Security Policy failures
 webkit.org/b/111869 http/tests/security/contentSecurityPolicy/eval-blocked-and-sends-report.html
 webkit.org/b/153148 http/tests/security/contentSecurityPolicy/eval-allowed-in-report-only-mode-and-sends-report.php
index 3649143..9b16047 100644 (file)
@@ -1,4 +1,4 @@
-CONSOLE MESSAGE: Unsafe attempt to load URL http://127.0.0.1:8000/resources/redirect.php?url=http%3A%2F%2Flocalhost%3A8080%2Fsecurity%2Fresources%2Fimage-access-control.php%3Ffile%3D..%2F..%2Fresources%2Fsquare100.png%26allow%3Dfalse.
+CONSOLE MESSAGE: Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin.
 Verify the error message in console in case of CORS failing checks.
 
 
index ff2d5a8..9b16047 100644 (file)
@@ -1,4 +1,4 @@
-CONSOLE MESSAGE: Unsafe attempt to load URL http://localhost:8080/security/resources/redirect-allow-star.php?url=http%3A%2F%2Flocalhost%3A8080%2Fsecurity%2Fresources%2Fimage-access-control.php%3Ffile%3D..%2F..%2Fresources%2Fsquare100.png%26allow%3Dfalse.
+CONSOLE MESSAGE: Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin.
 Verify the error message in console in case of CORS failing checks.
 
 
index 422339e..41857ef 100644 (file)
@@ -1,4 +1,4 @@
-CONSOLE MESSAGE: Cross-origin redirection denied by Cross-Origin Resource Sharing policy: Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin.
+CONSOLE MESSAGE: Cross-origin redirection to http://localhost:8080/security/resources/image-access-control.php?file=../../resources/square100.png&allow=true denied by Cross-Origin Resource Sharing policy: Origin http://127.0.0.1:8000 is not allowed by Access-Control-Allow-Origin.
 Verify the error message in console in case of CORS failing checks.
 
 
index dd30606..5119de9 100644 (file)
@@ -1,4 +1,4 @@
-CONSOLE MESSAGE: Cross-origin redirection denied by Cross-Origin Resource Sharing policy: Redirected to either a non-HTTP URL or a URL that contains credentials.
+CONSOLE MESSAGE: Cross-origin redirection to mailto://example.com denied by Cross-Origin Resource Sharing policy: URL is either a non-HTTP URL or contains credentials.
 Verify the error message in console in case of CORS failing checks.