Autoreleased cached pages slow down the PLT by 2%
authorggaren@apple.com <ggaren@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 6 Mar 2013 06:54:01 +0000 (06:54 +0000)
committerggaren@apple.com <ggaren@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 6 Mar 2013 06:54:01 +0000 (06:54 +0000)
https://bugs.webkit.org/show_bug.cgi?id=111522

Reviewed by Filip Pizlo.

Let's stop doing that.

2% PLT speedup.

* history/PageCache.cpp:
(WebCore::PageCache::remove):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/history/PageCache.cpp

index 3fa038c..e58e919 100644 (file)
@@ -1,3 +1,17 @@
+2013-03-05  Geoffrey Garen  <ggaren@apple.com>
+
+        Autoreleased cached pages slow down the PLT by 2%
+        https://bugs.webkit.org/show_bug.cgi?id=111522
+
+        Reviewed by Filip Pizlo.
+
+        Let's stop doing that.
+
+        2% PLT speedup.
+
+        * history/PageCache.cpp:
+        (WebCore::PageCache::remove):
+
 2013-03-05  Hayato Ito  <hayato@chromium.org>
 
         [Shadow] Implements event re-targeting for Touch Events.
 2013-03-05  Hayato Ito  <hayato@chromium.org>
 
         [Shadow] Implements event re-targeting for Touch Events.
index 8fae41b..54912a8 100644 (file)
@@ -485,7 +485,7 @@ void PageCache::remove(HistoryItem* item)
     if (!item || !item->m_cachedPage)
         return;
 
     if (!item || !item->m_cachedPage)
         return;
 
-    autorelease(item->m_cachedPage.release());
+    item->m_cachedPage.clear();
     removeFromLRUList(item);
     --m_size;
 
     removeFromLRUList(item);
     --m_size;