webkit-patch rebaseline*: fix typo for --results-directory
authordpranke@chromium.org <dpranke@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 6 Nov 2012 07:44:18 +0000 (07:44 +0000)
committerdpranke@chromium.org <dpranke@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 6 Nov 2012 07:44:18 +0000 (07:44 +0000)
https://bugs.webkit.org/show_bug.cgi?id=101295

Reviewed by Ojan Vafai.

Had --results_directory instead of --results-directory in both the
code and the unit test.

* Scripts/webkitpy/tool/commands/rebaseline.py:
(AbstractParallelRebaselineCommand._rebaseline_commands):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(TestRebaselineJson.test_results_directory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/Scripts/webkitpy/tool/commands/rebaseline.py
Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py

index a4e7068..2e0f5ee 100644 (file)
@@ -1,5 +1,20 @@
 2012-11-05  Dirk Pranke  <dpranke@chromium.org>
 
+        webkit-patch rebaseline*: fix typo for --results-directory
+        https://bugs.webkit.org/show_bug.cgi?id=101295
+
+        Reviewed by Ojan Vafai.
+
+        Had --results_directory instead of --results-directory in both the
+        code and the unit test.
+
+        * Scripts/webkitpy/tool/commands/rebaseline.py:
+        (AbstractParallelRebaselineCommand._rebaseline_commands):
+        * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
+        (TestRebaselineJson.test_results_directory):
+
+2012-11-05  Dirk Pranke  <dpranke@chromium.org>
+
         webkit-patch rebaseline*: fix handling of local file urls
         https://bugs.webkit.org/show_bug.cgi?id=101296
 
index 276d0a2..d9209b1 100644 (file)
@@ -312,7 +312,7 @@ class AbstractParallelRebaselineCommand(AbstractRebaseliningCommand):
                     for platform in move_overwritten_baselines_to:
                         cmd_line.extend(['--move-overwritten-baselines-to', platform])
                 if options.results_directory:
-                    cmd_line.extend(['--results_directory', options.results_directory])
+                    cmd_line.extend(['--results-directory', options.results_directory])
                 if options.verbose:
                     cmd_line.append('--verbose')
                 commands.append(tuple([cmd_line, cwd]))
index 1f0ec11..d7dafb9 100644 (file)
@@ -282,7 +282,7 @@ class TestRebaselineJson(_BaseTestCase):
 
         # Note that we have only one run_in_parallel() call
         self.assertEquals(self.tool.executive.calls,
-            [[['echo', 'rebaseline-test-internal', '--suffixes', 'txt,png', '--builder', 'MOCK builder', '--test', 'user-scripts/another-test.html', '--results_directory', '/tmp', '--verbose']]])
+            [[['echo', 'rebaseline-test-internal', '--suffixes', 'txt,png', '--builder', 'MOCK builder', '--test', 'user-scripts/another-test.html', '--results-directory', '/tmp', '--verbose']]])
 
 
 class TestRebaseline(_BaseTestCase):