Web Inspector: get rid of hiddenPanels filter
authorpfeldman@chromium.org <pfeldman@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 13 Mar 2013 14:17:45 +0000 (14:17 +0000)
committerpfeldman@chromium.org <pfeldman@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 13 Mar 2013 14:17:45 +0000 (14:17 +0000)
https://bugs.webkit.org/show_bug.cgi?id=112252

Reviewed by Vsevolod Vlasov.

Source/WebCore:

* WebCore.order:
* inspector/InspectorFrontendClient.h:
(InspectorFrontendClient):
* inspector/InspectorFrontendHost.cpp:
* inspector/InspectorFrontendHost.h:
(InspectorFrontendHost):
* inspector/InspectorFrontendHost.idl:
* inspector/front-end/InspectorFrontendHostStub.js:
* inspector/front-end/externs.js:
* inspector/front-end/inspector.js:
(WebInspector._panelDescriptors):
* testing/Internals.cpp:

Source/WebKit/chromium:

* src/InspectorFrontendClientImpl.cpp:
* src/InspectorFrontendClientImpl.h:
(InspectorFrontendClientImpl):

Source/WebKit/efl:

* WebCoreSupport/InspectorClientEfl.cpp:
* WebCoreSupport/InspectorClientEfl.h:
(InspectorFrontendClientEfl):

Source/WebKit/gtk:

* WebCoreSupport/InspectorClientGtk.cpp:
* WebCoreSupport/InspectorClientGtk.h:
(InspectorFrontendClient):

Source/WebKit/mac:

* WebCoreSupport/WebInspectorClient.h:
(WebInspectorFrontendClient):
* WebCoreSupport/WebInspectorClient.mm:
* WebKit.order:

Source/WebKit/qt:

* WebCoreSupport/InspectorClientQt.cpp:
(WebCore):
* WebCoreSupport/InspectorClientQt.h:
(InspectorFrontendClientQt):

Source/WebKit/win:

* WebCoreSupport/WebInspectorClient.cpp:
* WebCoreSupport/WebInspectorClient.h:
(WebInspectorFrontendClient):

Source/WebKit2:

* WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
* WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
(WebInspectorFrontendClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

33 files changed:
Source/WebCore/ChangeLog
Source/WebCore/WebCore.order
Source/WebCore/inspector/InspectorFrontendClient.h
Source/WebCore/inspector/InspectorFrontendHost.cpp
Source/WebCore/inspector/InspectorFrontendHost.h
Source/WebCore/inspector/InspectorFrontendHost.idl
Source/WebCore/inspector/front-end/InspectorFrontendHostStub.js
Source/WebCore/inspector/front-end/View.js
Source/WebCore/inspector/front-end/externs.js
Source/WebCore/inspector/front-end/inspector.js
Source/WebCore/testing/Internals.cpp
Source/WebKit/chromium/ChangeLog
Source/WebKit/chromium/src/InspectorFrontendClientImpl.cpp
Source/WebKit/chromium/src/InspectorFrontendClientImpl.h
Source/WebKit/efl/ChangeLog
Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.cpp
Source/WebKit/efl/WebCoreSupport/InspectorClientEfl.h
Source/WebKit/gtk/ChangeLog
Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp
Source/WebKit/gtk/WebCoreSupport/InspectorClientGtk.h
Source/WebKit/mac/ChangeLog
Source/WebKit/mac/WebCoreSupport/WebInspectorClient.h
Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm
Source/WebKit/mac/WebKit.order
Source/WebKit/qt/ChangeLog
Source/WebKit/qt/WebCoreSupport/InspectorClientQt.cpp
Source/WebKit/qt/WebCoreSupport/InspectorClientQt.h
Source/WebKit/win/ChangeLog
Source/WebKit/win/WebCoreSupport/WebInspectorClient.cpp
Source/WebKit/win/WebCoreSupport/WebInspectorClient.h
Source/WebKit2/ChangeLog
Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp
Source/WebKit2/WebProcess/WebCoreSupport/WebInspectorFrontendClient.h

index ab04309..b8f5f1a 100644 (file)
@@ -1,5 +1,25 @@
 2013-03-13  Pavel Feldman  <pfeldman@chromium.org>
 
+        Web Inspector: get rid of hiddenPanels filter
+        https://bugs.webkit.org/show_bug.cgi?id=112252
+
+        Reviewed by Vsevolod Vlasov.
+
+        * WebCore.order:
+        * inspector/InspectorFrontendClient.h:
+        (InspectorFrontendClient):
+        * inspector/InspectorFrontendHost.cpp:
+        * inspector/InspectorFrontendHost.h:
+        (InspectorFrontendHost):
+        * inspector/InspectorFrontendHost.idl:
+        * inspector/front-end/InspectorFrontendHostStub.js:
+        * inspector/front-end/externs.js:
+        * inspector/front-end/inspector.js:
+        (WebInspector._panelDescriptors):
+        * testing/Internals.cpp:
+
+2013-03-13  Pavel Feldman  <pfeldman@chromium.org>
+
         Web Inspector: convert workers inspection into capability
         https://bugs.webkit.org/show_bug.cgi?id=112251
 
index 3b06e5b..7503dc2 100644 (file)
@@ -27139,7 +27139,6 @@ __ZN7WebCore18InspectorPageAgent18resourceTypeStringENS0_12ResourceTypeE
 __ZN3WTF6VectorINS_6RefPtrIN7WebCore14InspectorValueEEELm0EE14expandCapacityEm
 __ZNK7WebCore14InspectorArray9writeJSONEPN3WTF6VectorItLm0EEE
 __ZN7WebCore52jsInspectorFrontendHostPrototypeFunctionHiddenPanelsEPN3JSC9ExecStateE
-__ZN7WebCore21InspectorFrontendHost12hiddenPanelsEv
 __ZN7WebCore24InspectorInstrumentation26didInvalidateStyleAttrImplEPNS_19InstrumentingAgentsEPNS_4NodeE
 __ZN7WebCore24InspectorInstrumentation21willRemoveDOMNodeImplEPNS_19InstrumentingAgentsEPNS_4NodeE
 __ZN7WebCore24InspectorInstrumentation20didRemoveDOMNodeImplEPNS_19InstrumentingAgentsEPNS_4NodeE
index 2bca83f..418a630 100644 (file)
@@ -55,7 +55,6 @@ public:
     virtual void moveWindowBy(float x, float y) = 0;
 
     virtual String localizedStringsURL() = 0;
-    virtual String hiddenPanels() = 0;
 
     virtual void bringToFront() = 0;
     virtual void closeWindow() = 0;
index 743407a..d9ac3c8 100644 (file)
@@ -211,11 +211,6 @@ String InspectorFrontendHost::localizedStringsURL()
     return m_client ? m_client->localizedStringsURL() : "";
 }
 
-String InspectorFrontendHost::hiddenPanels()
-{
-    return m_client ? m_client->hiddenPanels() : "";
-}
-
 void InspectorFrontendHost::copyText(const String& text)
 {
     Pasteboard::generalPasteboard()->writePlainText(text, Pasteboard::CannotSmartReplace);
index 4aa243f..65edb52 100644 (file)
@@ -69,7 +69,6 @@ public:
     void setInjectedScriptForOrigin(const String& origin, const String& script);
 
     String localizedStringsURL();
-    String hiddenPanels();
 
     void copyText(const String& text);
     void openInNewTab(const String& url);
index 2b628c1..eb9c4d3 100644 (file)
@@ -46,7 +46,6 @@
     void setInjectedScriptForOrigin(in DOMString origin, in DOMString script);
 
     DOMString localizedStringsURL();
-    DOMString hiddenPanels();
 
     void copyText(in DOMString text);
     void openInNewTab(in DOMString url);
index 0d900e1..22a351c 100644 (file)
@@ -95,11 +95,6 @@ WebInspector.InspectorFrontendHostStub.prototype = {
         return undefined;
     },
 
-    hiddenPanels: function()
-    {
-        return WebInspector.queryParamsObject["hiddenPanels"] || "";
-    },
-
     inspectedURLChanged: function(url)
     {
         document.title = WebInspector.UIString(Preferences.applicationTitle, url);
index e1e601f..3c2ca2d 100644 (file)
@@ -59,6 +59,14 @@ WebInspector.View.prototype = {
         this._isRoot = true;
     },
 
+    /**
+     * @return {?WebInspector.View}
+     */
+    parentView: function()
+    {
+        return this._parentView;
+    },
+
     isShowing: function()
     {
         return this._isShowing;
index 17bcc4c..63996ac 100644 (file)
@@ -172,7 +172,6 @@ InspectorFrontendHostAPI.prototype.moveWindowBy = function(x, y) {}
 InspectorFrontendHostAPI.prototype.setInjectedScriptForOrigin = function(origin, script) {}
 InspectorFrontendHostAPI.prototype.loaded = function() {}
 InspectorFrontendHostAPI.prototype.localizedStringsURL = function() {}
-InspectorFrontendHostAPI.prototype.hiddenPanels = function() {}
 InspectorFrontendHostAPI.prototype.inspectedURLChanged = function(url) {}
 InspectorFrontendHostAPI.prototype.documentCopy = function(event) {}
 InspectorFrontendHostAPI.prototype.copyText = function(text) {}
index 76530f6..ed92e1a 100644 (file)
@@ -71,11 +71,8 @@ var WebInspector = {
             panelDescriptors.push(console);
             return panelDescriptors;
         }
-        var hiddenPanels = InspectorFrontendHost.hiddenPanels();
-        for (var i = 0; i < allDescriptors.length; ++i) {
-            if (hiddenPanels.indexOf(allDescriptors[i].name()) === -1)
-                panelDescriptors.push(allDescriptors[i]);
-        }
+        for (var i = 0; i < allDescriptors.length; ++i)
+            panelDescriptors.push(allDescriptors[i]);
         return panelDescriptors;
     },
 
index 6cb1467..2dc25e1 100644 (file)
@@ -161,7 +161,6 @@ public:
     virtual void detachWindow() OVERRIDE { }
 
     virtual String localizedStringsURL() OVERRIDE { return String(); }
-    virtual String hiddenPanels() OVERRIDE { return String(); }
 
     virtual void bringToFront() OVERRIDE { }
     virtual void closeWindow() OVERRIDE { }
index 113aecf..dfaff21 100644 (file)
@@ -1,3 +1,14 @@
+2013-03-13  Pavel Feldman  <pfeldman@chromium.org>
+
+        Web Inspector: get rid of hiddenPanels filter
+        https://bugs.webkit.org/show_bug.cgi?id=112252
+
+        Reviewed by Vsevolod Vlasov.
+
+        * src/InspectorFrontendClientImpl.cpp:
+        * src/InspectorFrontendClientImpl.h:
+        (InspectorFrontendClientImpl):
+
 2013-03-13  Mikhail Naganov  <mnaganov@chromium.org>
 
         [Chromium] Rename android_build_type to android_webview_build in .gyp files.
index dbec9ef..d1bf9df 100644 (file)
@@ -88,11 +88,6 @@ String InspectorFrontendClientImpl::localizedStringsURL()
     return "";
 }
 
-String InspectorFrontendClientImpl::hiddenPanels()
-{
-    return "";
-}
-
 void InspectorFrontendClientImpl::bringToFront()
 {
     m_client->activateWindow();
index c409b82..cefc192 100644 (file)
@@ -57,7 +57,6 @@ public:
     virtual void moveWindowBy(float x, float y);
 
     virtual WTF::String localizedStringsURL();
-    virtual WTF::String hiddenPanels();
 
     virtual void bringToFront();
     virtual void closeWindow();
index dbe6cfd..5f62577 100644 (file)
@@ -1,3 +1,14 @@
+2013-03-13  Pavel Feldman  <pfeldman@chromium.org>
+
+        Web Inspector: get rid of hiddenPanels filter
+        https://bugs.webkit.org/show_bug.cgi?id=112252
+
+        Reviewed by Vsevolod Vlasov.
+
+        * WebCoreSupport/InspectorClientEfl.cpp:
+        * WebCoreSupport/InspectorClientEfl.h:
+        (InspectorFrontendClientEfl):
+
 2013-03-06  Krzysztof Czech  <k.czech@samsung.com>
 
         [EFL] Missing implementation of AccessibilityControllerEfl and AccessibilityUIElementEfl files
index 1d6e083..f1b7430 100644 (file)
@@ -167,12 +167,6 @@ String InspectorFrontendClientEfl::localizedStringsURL()
     return m_inspectorClient->inspectorFilesPath() + "/localizedStrings.js";
 }
 
-String InspectorFrontendClientEfl::hiddenPanels()
-{
-    notImplemented();
-    return String();
-}
-
 void InspectorFrontendClientEfl::bringToFront()
 {
     evas_object_focus_set(m_inspectorView, true);
index 18820c5..894854c 100644 (file)
@@ -75,7 +75,6 @@ public:
     ~InspectorFrontendClientEfl();
 
     virtual String localizedStringsURL();
-    virtual String hiddenPanels();
 
     virtual void bringToFront();
     virtual void closeWindow();
index 9367e50..599fa83 100644 (file)
@@ -1,3 +1,14 @@
+2013-03-13  Pavel Feldman  <pfeldman@chromium.org>
+
+        Web Inspector: get rid of hiddenPanels filter
+        https://bugs.webkit.org/show_bug.cgi?id=112252
+
+        Reviewed by Vsevolod Vlasov.
+
+        * WebCoreSupport/InspectorClientGtk.cpp:
+        * WebCoreSupport/InspectorClientGtk.h:
+        (InspectorFrontendClient):
+
 2013-03-12  Zan Dobersek  <zdobersek@igalia.com>
 
         [GTK] Set up the libPlatformGtk.la library
index cf73156..49e9ad9 100644 (file)
@@ -227,12 +227,6 @@ String InspectorFrontendClient::localizedStringsURL()
     return String::fromUTF8(stringsURI.get());
 }
 
-String InspectorFrontendClient::hiddenPanels()
-{
-    notImplemented();
-    return String();
-}
-
 void InspectorFrontendClient::bringToFront()
 {
     if (!m_inspectorWebView)
index ee42e23..a51a9c8 100644 (file)
@@ -85,8 +85,6 @@ public:
 
     virtual WTF::String localizedStringsURL();
 
-    virtual WTF::String hiddenPanels();
-
     virtual void bringToFront();
     virtual void closeWindow();
 
index be6d180..ca0d8a7 100644 (file)
@@ -1,3 +1,15 @@
+2013-03-13  Pavel Feldman  <pfeldman@chromium.org>
+
+        Web Inspector: get rid of hiddenPanels filter
+        https://bugs.webkit.org/show_bug.cgi?id=112252
+
+        Reviewed by Vsevolod Vlasov.
+
+        * WebCoreSupport/WebInspectorClient.h:
+        (WebInspectorFrontendClient):
+        * WebCoreSupport/WebInspectorClient.mm:
+        * WebKit.order:
+
 2013-03-12  Geoffrey Garen  <ggaren@apple.com>
 
         Moved RunLoopTimer and SchedulePair to WTF
index 1923e0d..a7094fd 100644 (file)
@@ -97,7 +97,6 @@ public:
     virtual void frontendLoaded();
 
     virtual String localizedStringsURL();
-    virtual String hiddenPanels();
 
     virtual void bringToFront();
     virtual void closeWindow();
index 5d2f0a4..5a113ec 100644 (file)
@@ -236,14 +236,6 @@ String WebInspectorFrontendClient::localizedStringsURL()
     return String();
 }
 
-String WebInspectorFrontendClient::hiddenPanels()
-{
-    NSString *hiddenPanels = [[NSUserDefaults standardUserDefaults] stringForKey:@"WebKitInspectorHiddenPanels"];
-    if (hiddenPanels)
-        return hiddenPanels;
-    return String();
-}
-
 void WebInspectorFrontendClient::bringToFront()
 {
     updateWindowTitle();
index 016c17a..081dde4 100644 (file)
@@ -2028,7 +2028,6 @@ __ZNK26WebInspectorFrontendClient17updateWindowTitleEv
 -[WebInspectorWindowController window]
 _WKNSWindowMakeBottomCornersSquare
 __ZN18WebInspectorClient21sendMessageToFrontendERKN3WTF6StringE
-__ZN26WebInspectorFrontendClient12hiddenPanelsEv
 __ZN26WebInspectorFrontendClient18loadSessionSettingERKN3WTF6StringEPS1_
 -[WebInspectorWindowController inspectorClient]
 __ZN18WebInspectorClient18loadSessionSettingERKN3WTF6StringEPS1_
index 0e4e672..2499290 100644 (file)
@@ -1,3 +1,15 @@
+2013-03-13  Pavel Feldman  <pfeldman@chromium.org>
+
+        Web Inspector: get rid of hiddenPanels filter
+        https://bugs.webkit.org/show_bug.cgi?id=112252
+
+        Reviewed by Vsevolod Vlasov.
+
+        * WebCoreSupport/InspectorClientQt.cpp:
+        (WebCore):
+        * WebCoreSupport/InspectorClientQt.h:
+        (InspectorFrontendClientQt):
+
 2013-03-11  Jochen Eisinger  <jochen@chromium.org>
 
         Rename DefinitelyProcessingUserGesture to DefinitelyProcessingNewUserGesture
index 1bfaa7b..eb157b9 100644 (file)
@@ -306,12 +306,6 @@ String InspectorFrontendClientQt::localizedStringsURL()
     return String();
 }
 
-String InspectorFrontendClientQt::hiddenPanels()
-{
-    notImplemented();
-    return String();
-}
-
 void InspectorFrontendClientQt::bringToFront()
 {
     updateWindowTitle();
index be1febc..9e9ee7f 100644 (file)
@@ -88,8 +88,6 @@ public:
 
     virtual String localizedStringsURL();
 
-    virtual String hiddenPanels();
-
     virtual void bringToFront();
     virtual void closeWindow();
 
index 85f670e..558fe7d 100644 (file)
@@ -1,3 +1,14 @@
+2013-03-13  Pavel Feldman  <pfeldman@chromium.org>
+
+        Web Inspector: get rid of hiddenPanels filter
+        https://bugs.webkit.org/show_bug.cgi?id=112252
+
+        Reviewed by Vsevolod Vlasov.
+
+        * WebCoreSupport/WebInspectorClient.cpp:
+        * WebCoreSupport/WebInspectorClient.h:
+        (WebInspectorFrontendClient):
+
 2013-03-12  Abhishek Arya  <inferno@chromium.org>
 
         Replace static_casts with to* helper functions.
index bbd3a51..0e84b43 100644 (file)
@@ -268,12 +268,6 @@ String WebInspectorFrontendClient::localizedStringsURL()
     return CFURLGetString(url.get());
 }
 
-String WebInspectorFrontendClient::hiddenPanels()
-{
-    // FIXME: implement this
-    return String();
-}
-
 void WebInspectorFrontendClient::bringToFront()
 {
     showWindowWithoutNotifications();
index 036e2dd..4ddd6d0 100644 (file)
@@ -97,7 +97,6 @@ public:
     virtual void frontendLoaded();
     
     virtual WTF::String localizedStringsURL();
-    virtual WTF::String hiddenPanels();
     
     virtual void bringToFront();
     virtual void closeWindow();
index 63e699c..27a9b2c 100644 (file)
@@ -1,3 +1,14 @@
+2013-03-13  Pavel Feldman  <pfeldman@chromium.org>
+
+        Web Inspector: get rid of hiddenPanels filter
+        https://bugs.webkit.org/show_bug.cgi?id=112252
+
+        Reviewed by Vsevolod Vlasov.
+
+        * WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
+        * WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
+        (WebInspectorFrontendClient):
+
 2013-03-13  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
 
         [WK2][Qt] Regression(145517) WebProcess asserts in debug build on WebKitTestRunner start
index 09e1d37..23a4474 100644 (file)
@@ -57,12 +57,6 @@ String WebInspectorFrontendClient::localizedStringsURL()
     return m_page->inspector()->localizedStringsURL();
 }
 
-String WebInspectorFrontendClient::hiddenPanels()
-{
-    notImplemented();
-    return String();
-}
-
 void WebInspectorFrontendClient::bringToFront()
 {
     m_page->inspector()->bringToFront();
index 3183ab0..09ea35d 100644 (file)
@@ -42,7 +42,6 @@ private:
     virtual void frontendLoaded() OVERRIDE;
 
     virtual String localizedStringsURL() OVERRIDE;
-    virtual String hiddenPanels() OVERRIDE;
 
     virtual void bringToFront() OVERRIDE;
     virtual void closeWindow() OVERRIDE;