Activate some new webrtc tests
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 2 Mar 2017 23:39:40 +0000 (23:39 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 2 Mar 2017 23:39:40 +0000 (23:39 +0000)
https://bugs.webkit.org/show_bug.cgi?id=168850

Patch by Youenn Fablet <youenn@apple.com> on 2017-03-02
Reviewed by Alex Christensen.

Source/WebKit2:

* Shared/WebPreferencesDefinitions.h: Activating peer connection by default when libwebrtc is on.
This allows ensuring the network process will have its sandbox extension.

LayoutTests:

* TestExpectations: Marking webrtc/audio-peer-connection-webaudio.html as failing.
* webrtc/audio-peer-connection-webaudio.html: Making test nicer when failing.
* webrtc/datachannel/basic-expected.txt: Updated test expectation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@213310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/TestExpectations
LayoutTests/webrtc/audio-peer-connection-webaudio.html
LayoutTests/webrtc/datachannel/basic-expected.txt
Source/WebKit2/ChangeLog
Source/WebKit2/Shared/WebPreferencesDefinitions.h

index 2b48eb1..804054e 100644 (file)
@@ -1,3 +1,14 @@
+2017-03-02  Youenn Fablet  <youenn@apple.com>
+
+        Activate some new webrtc tests
+        https://bugs.webkit.org/show_bug.cgi?id=168850
+
+        Reviewed by Alex Christensen.
+
+        * TestExpectations: Marking webrtc/audio-peer-connection-webaudio.html as failing.
+        * webrtc/audio-peer-connection-webaudio.html: Making test nicer when failing.
+        * webrtc/datachannel/basic-expected.txt: Updated test expectation.
+
 2017-03-02  Dave Hyatt  <hyatt@apple.com>
 
         flex-basis should be 0% (not 0px) when omitted
index 167a7ba..984faf8 100644 (file)
@@ -691,6 +691,8 @@ media/session [ Skip ]
 # WebRTC backend not enabled by default on Mac/iOS release bots.
 # GTK enables some of this tests on their TestExpectations file.
 [ Release ] webrtc [ Skip ]
+
+webrtc/audio-peer-connection-webaudio.html [ Failure ]
 fast/mediastream/getUserMedia-webaudio.html [ Skip ]
 fast/mediastream/RTCPeerConnection-AddRemoveStream.html [ Skip ]
 fast/mediastream/RTCPeerConnection-closed-state.html [ Skip ]
index a57eefd..03e9918 100644 (file)
@@ -8,9 +8,6 @@
     <script src ="routines.js"></script>
     <script>
     var test = async_test(() => {
-        if (window.internals)
-            internals.useMockRTCPeerConnectionFactory("TwoRealPeerConnections");
-
         if (window.testRunner)
             testRunner.setUserMediaPermission(true);
 
         var heardBip = false;
 
         navigator.mediaDevices.getUserMedia({audio: true}).then((stream) => {
+            if (window.internals)
+                internals.useMockRTCPeerConnectionFactory("TwoRealPeerConnections");
+
             createConnections((firstConnection) => {
                 firstConnection.addStream(stream);
             }, (secondConnection) => {
-                secondConnection.onaddstream = (streamEvent) => { 
+                secondConnection.onaddstream = (streamEvent) => {
                     var context = new webkitAudioContext();
                     var sourceNode = context.createMediaStreamSource(streamEvent.stream);
                     var analyser = context.createAnalyser();
                             done();
                     };
 
-                    var done = () => {
+                    var done = test.step_func_done(() => {
                         clearTimeout(timeout);
                         clearInterval(interval);
 
-                        assert_true(heardHum);
-                        assert_true(heardBip);
-                        assert_true(heardBop);
+                        assert_true(heardHum, "heard hum");
+                        assert_true(heardBip, "heard bip");
+                        assert_true(heardBop, "heard bop");
                         test.done();
-                    };
+                    };);
 
                     var timeout = setTimeout(done, 3000);
                     var interval = setInterval(analyse, 1000 / 30);
index aa3ffad..1422dd0 100644 (file)
@@ -1,4 +1,6 @@
 
 PASS Basic data channel exchange from offerer to receiver 
 PASS Basic data channel exchange from receiver to offerer 
+PASS Basic data channel exchange from offerer to receiver using UDP only 
+PASS Basic data channel exchange from offerer to receiver using TCP only 
 
index d04922e..4e0775a 100644 (file)
@@ -1,3 +1,13 @@
+2017-03-02  Youenn Fablet  <youenn@apple.com>
+
+        Activate some new webrtc tests
+        https://bugs.webkit.org/show_bug.cgi?id=168850
+
+        Reviewed by Alex Christensen.
+
+        * Shared/WebPreferencesDefinitions.h: Activating peer connection by default when libwebrtc is on.
+        This allows ensuring the network process will have its sandbox extension.
+
 2017-03-02  Brian Burg  <bburg@apple.com>
 
         Web Automation: _WKAutomationSessionDelegate should work with WKWebViews
index 28e25ad..a2e5760 100644 (file)
     macro(SubpixelCSSOMElementMetricsEnabled, subpixelCSSOMElementMetricsEnabled, Bool, bool, false, "", "") \
     macro(UseGiantTiles, useGiantTiles, Bool, bool, false, "", "") \
     macro(MediaStreamEnabled, mediaStreamEnabled, Bool, bool, false, "", "") \
-    macro(PeerConnectionEnabled, peerConnectionEnabled, Bool, bool, false, "", "") \
+    macro(PeerConnectionEnabled, peerConnectionEnabled, Bool, bool, WebCore::LibWebRTCProvider::webRTCAvailable(), "", "") \
     macro(UseLegacyTextAlignPositionedElementBehavior, useLegacyTextAlignPositionedElementBehavior, Bool, bool, false, "", "") \
     macro(SpatialNavigationEnabled, spatialNavigationEnabled, Bool, bool, false, "", "") \
     macro(MediaSourceEnabled, mediaSourceEnabled, Bool, bool, true, "", "") \