Unreviewed, rolling out r116633.
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 10 May 2012 13:48:47 +0000 (13:48 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 10 May 2012 13:48:47 +0000 (13:48 +0000)
http://trac.webkit.org/changeset/116633
https://bugs.webkit.org/show_bug.cgi?id=86093

Breaks EFL tests (Requested by kov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-10

Source/WebKit/efl:

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
* DumpRenderTree/efl/EventSender.cpp:
(keyDownCallback):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setTabKeyCyclesThroughElements):

LayoutTests:

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/efl/Skipped
Source/WebKit/efl/ChangeLog
Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.cpp
Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h
Tools/ChangeLog
Tools/DumpRenderTree/efl/DumpRenderTreeChrome.cpp
Tools/DumpRenderTree/efl/EventSender.cpp
Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp

index 5c6d5c5..9585b88 100644 (file)
@@ -1,3 +1,13 @@
+2012-05-10  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r116633.
+        http://trac.webkit.org/changeset/116633
+        https://bugs.webkit.org/show_bug.cgi?id=86093
+
+        Breaks EFL tests (Requested by kov on #webkit).
+
+        * platform/efl/Skipped:
+
 2012-05-10  Noel Gordon  <noel.gordon@gmail.com>
 
         [chromium] REGRESSION(r107389) Visible line artifacts on JPEG images
index d28f8b5..e1efbf9 100644 (file)
@@ -249,6 +249,9 @@ editing/selection/designmode-no-caret.html
 editing/selection/selection-background.html
 fast/dom/Window/window-onFocus.html
 
+# EFL's LayoutTestController does not implement setTabKeyCyclesThroughElements
+fast/events/keypress-insert-tab.html
+
 # EFL's LayoutTestController does not implement setUseDashboardCompatibilityMode
 fast/canvas/canvas-gradient-addStop-error.html
 fast/canvas/fill-stroke-clip-reset-path.html
index 8b67252..4921a2c 100644 (file)
@@ -1,3 +1,14 @@
+2012-05-10  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r116633.
+        http://trac.webkit.org/changeset/116633
+        https://bugs.webkit.org/show_bug.cgi?id=86093
+
+        Breaks EFL tests (Requested by kov on #webkit).
+
+        * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
+        * WebCoreSupport/DumpRenderTreeSupportEfl.h:
+
 2012-05-10  Alexander Shalamov  <alexander.shalamov@intel.com>
 
         [EFL] LayoutTestController needs implementation of setTabKeyCyclesThroughElements
index e118a62..8bd8909 100644 (file)
@@ -478,15 +478,6 @@ void DumpRenderTreeSupportEfl::setSelectTrailingWhitespaceEnabled(Evas_Object* e
     editorClient->setSelectTrailingWhitespaceEnabled(enabled);
 }
 
-void DumpRenderTreeSupportEfl::setTabKeyCyclesThroughElements(const Evas_Object* ewkView, bool cycles)
-{
-    WebCore::Page* page = EWKPrivate::corePage(ewkView);
-    if (!page)
-        return;
-
-    page->setTabKeyCyclesThroughElements(cycles);
-}
-
 void DumpRenderTreeSupportEfl::garbageCollectorCollect()
 {
     WebCore::gcController().garbageCollectNow();
index 21da5b3..fd07762 100644 (file)
@@ -80,7 +80,6 @@ public:
     static void setJavaScriptProfilingEnabled(const Evas_Object* ewkView, bool enabled);
     static void setSmartInsertDeleteEnabled(Evas_Object* ewkView, bool enabled);
     static void setSelectTrailingWhitespaceEnabled(Evas_Object* ewkView, bool enabled);
-    static void setTabKeyCyclesThroughElements(const Evas_Object* ewkView, bool cycles);
 
     static void garbageCollectorCollect();
     static void garbageCollectorCollectOnAlternateThread(bool waitUntilDone);
index 05b635d..11325bb 100644 (file)
@@ -1,3 +1,18 @@
+2012-05-10  Sheriff Bot  <webkit.review.bot@gmail.com>
+
+        Unreviewed, rolling out r116633.
+        http://trac.webkit.org/changeset/116633
+        https://bugs.webkit.org/show_bug.cgi?id=86093
+
+        Breaks EFL tests (Requested by kov on #webkit).
+
+        * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
+        (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
+        * DumpRenderTree/efl/EventSender.cpp:
+        (keyDownCallback):
+        * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
+        (LayoutTestController::setTabKeyCyclesThroughElements):
+
 2012-05-10  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
 
         [EFL] Memory leaks found in EFL DRT
index b60b824..9f74416 100644 (file)
@@ -264,7 +264,6 @@ void DumpRenderTreeChrome::resetDefaultsToConsistentValues()
     DumpRenderTreeSupportEfl::setEditingBehavior(mainView(), defaultEditingBehavior());
     DumpRenderTreeSupportEfl::setJavaScriptProfilingEnabled(mainView(), false);
     DumpRenderTreeSupportEfl::setLoadsSiteIconsIgnoringImageLoadingSetting(mainView(), false);
-    DumpRenderTreeSupportEfl::setTabKeyCyclesThroughElements(mainView(), true);
 }
 
 static CString pathSuitableForTestResult(const char* uriString)
index 7265285..ed606ff 100644 (file)
@@ -497,12 +497,7 @@ static void sendKeyDown(Evas* evas, KeyEventInfo* keyEventInfo)
 static JSValueRef keyDownCallback(JSContextRef context, JSObjectRef function, JSObjectRef thisObject, size_t argumentCount, const JSValueRef arguments[], JSValueRef* exception)
 {
     OwnPtr<KeyEventInfo> keyEventInfo = adoptPtr(createKeyEventInfo(context, argumentCount, arguments, exception));
-    Evas_Object* mainFrame = browser->mainFrame();
-
-    // Focus of the main frame could be lost during the test
-    // Therefore, setting focus to the main frame
-    evas_object_focus_set(mainFrame, true);
-    sendKeyDown(evas_object_evas_get(mainFrame), keyEventInfo.get());
+    sendKeyDown(evas_object_evas_get(browser->mainFrame()), keyEventInfo.get());
 
     return JSValueMakeUndefined(context);
 }
index 5067655..a4532f3 100644 (file)
@@ -241,9 +241,9 @@ void LayoutTestController::setMainFrameIsFirstResponder(bool)
     notImplemented();
 }
 
-void LayoutTestController::setTabKeyCyclesThroughElements(bool cycles)
+void LayoutTestController::setTabKeyCyclesThroughElements(bool)
 {
-    DumpRenderTreeSupportEfl::setTabKeyCyclesThroughElements(browser->mainView(), cycles);
+    notImplemented();
 }
 
 void LayoutTestController::setUseDashboardCompatibilityMode(bool)