Web Inspector: TreeOutline shouldn't select first child of an expanded element on...
authormattbaker@apple.com <mattbaker@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 16 Nov 2018 22:45:13 +0000 (22:45 +0000)
committermattbaker@apple.com <mattbaker@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 16 Nov 2018 22:45:13 +0000 (22:45 +0000)
https://bugs.webkit.org/show_bug.cgi?id=191766

Reviewed by Devin Rousso.

* UserInterface/Views/TreeOutline.js:
(WI.TreeOutline.prototype._treeKeyDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Views/TreeOutline.js

index f8428bf..377c761 100644 (file)
@@ -1,3 +1,13 @@
+2018-11-16  Matt Baker  <mattbaker@apple.com>
+
+        Web Inspector: TreeOutline shouldn't select first child of an expanded element on right arrow key
+        https://bugs.webkit.org/show_bug.cgi?id=191766
+
+        Reviewed by Devin Rousso.
+
+        * UserInterface/Views/TreeOutline.js:
+        (WI.TreeOutline.prototype._treeKeyDown):
+
 2018-11-14  Matt Baker  <mattbaker@apple.com>
 
         Web Inspector: Table should recalculate scrollable height when resized
index 8ec3f99..21ac3c2 100644 (file)
@@ -563,12 +563,7 @@ WI.TreeOutline = class TreeOutline extends WI.Object
                 handled = true;
             } else if (this.selectedTreeElement.hasChildren) {
                 handled = true;
-                if (this.selectedTreeElement.expanded) {
-                    nextSelectedElement = this.selectedTreeElement.children[0];
-                    while (nextSelectedElement && !nextSelectedElement.selectable)
-                        nextSelectedElement = nextSelectedElement.nextSibling;
-                    handled = nextSelectedElement ? true : false;
-                } else {
+                if (!this.selectedTreeElement.expanded) {
                     if (event.altKey)
                         this.selectedTreeElement.expandRecursively();
                     else