REGRESSION (r232991): Switching to dark mode in Mail does not update the message...
authortimothy@apple.com <timothy@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 20 Dec 2018 01:28:06 +0000 (01:28 +0000)
committertimothy@apple.com <timothy@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 20 Dec 2018 01:28:06 +0000 (01:28 +0000)
https://bugs.webkit.org/show_bug.cgi?id=188891
rdar://problem/42344352

Reviewed by Simon Fraser.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::rootBackgroundColorOrTransparencyChanged):
Don't return early when m_layerForOverhangAreas is null to avoid skipping
setRootLayerConfigurationNeedsUpdate() and scheduleCompositingLayerUpdate().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderLayerCompositor.cpp

index fdad2dd..98790bb 100644 (file)
@@ -1,3 +1,16 @@
+2018-12-19  Timothy Hatcher  <timothy@apple.com>
+
+        REGRESSION (r232991): Switching to dark mode in Mail does not update the message view to be transparent
+        https://bugs.webkit.org/show_bug.cgi?id=188891
+        rdar://problem/42344352
+
+        Reviewed by Simon Fraser.
+
+        * rendering/RenderLayerCompositor.cpp:
+        (WebCore::RenderLayerCompositor::rootBackgroundColorOrTransparencyChanged):
+        Don't return early when m_layerForOverhangAreas is null to avoid skipping
+        setRootLayerConfigurationNeedsUpdate() and scheduleCompositingLayerUpdate().
+
 2018-12-19  Justin Fan  <justin_fan@apple.com>
 
         [WebGPU] Add stubs for WebGPUPipelineLayout/Descriptor and device::createPipelineLayout
index ac2e036..97039a4 100644 (file)
@@ -3280,13 +3280,12 @@ void RenderLayerCompositor::rootBackgroundColorOrTransparencyChanged()
         page().chrome().client().pageExtendedBackgroundColorDidChange(m_rootExtendedBackgroundColor);
         
 #if ENABLE(RUBBER_BANDING)
-        if (!m_layerForOverhangAreas)
-            return;
-        
-        m_layerForOverhangAreas->setBackgroundColor(m_rootExtendedBackgroundColor);
-        
-        if (!m_rootExtendedBackgroundColor.isValid())
-            m_layerForOverhangAreas->setCustomAppearance(GraphicsLayer::CustomAppearance::ScrollingOverhang);
+        if (m_layerForOverhangAreas) {
+            m_layerForOverhangAreas->setBackgroundColor(m_rootExtendedBackgroundColor);
+
+            if (!m_rootExtendedBackgroundColor.isValid())
+                m_layerForOverhangAreas->setCustomAppearance(GraphicsLayer::CustomAppearance::ScrollingOverhang);
+        }
 #endif
     }