Add a WPE EWS queue
authorclopez@igalia.com <clopez@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 30 May 2017 14:43:43 +0000 (14:43 +0000)
committerclopez@igalia.com <clopez@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 30 May 2017 14:43:43 +0000 (14:43 +0000)
https://bugs.webkit.org/show_bug.cgi?id=172693

Reviewed by Carlos Garcia Campos.

* QueueStatusServer/config/queues.py:
* QueueStatusServer/model/queues.py: Capitalize the name of the
port on the tooltip of the bubbles. Do the same for the GTK port.
(Queue.display_name):
* Scripts/webkitpy/common/config/ews.json: Update the watcher mail
for the GTK+ EWS also. Set for both ports as watcher the alias
bugs-noreply@webkitgtk.org that maintainers of both ports follow.
* Scripts/webkitpy/common/config/ports.py:
(DeprecatedPort.port):
(WpePort):
(WpePort.build_webkit_command):
(WpePort.run_webkit_tests_command):
* Scripts/webkitpy/common/config/ports_unittest.py:
(DeprecatedPortTest):
(DeprecatedPortTest.test_wpe_port):
* Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
(test_ews_name):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@217555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/QueueStatusServer/config/queues.py
Tools/QueueStatusServer/model/queues.py
Tools/Scripts/webkitpy/common/config/ews.json
Tools/Scripts/webkitpy/common/config/ports.py
Tools/Scripts/webkitpy/common/config/ports_unittest.py
Tools/Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py

index d40f5d8..97b751b 100644 (file)
@@ -1,3 +1,28 @@
+2017-05-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
+
+        Add a WPE EWS queue
+        https://bugs.webkit.org/show_bug.cgi?id=172693
+
+        Reviewed by Carlos Garcia Campos.
+
+        * QueueStatusServer/config/queues.py:
+        * QueueStatusServer/model/queues.py: Capitalize the name of the
+        port on the tooltip of the bubbles. Do the same for the GTK port.
+        (Queue.display_name):
+        * Scripts/webkitpy/common/config/ews.json: Update the watcher mail
+        for the GTK+ EWS also. Set for both ports as watcher the alias
+        bugs-noreply@webkitgtk.org that maintainers of both ports follow.
+        * Scripts/webkitpy/common/config/ports.py:
+        (DeprecatedPort.port):
+        (WpePort):
+        (WpePort.build_webkit_command):
+        (WpePort.run_webkit_tests_command):
+        * Scripts/webkitpy/common/config/ports_unittest.py:
+        (DeprecatedPortTest):
+        (DeprecatedPortTest.test_wpe_port):
+        * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
+        (test_ews_name):
+
 2017-05-29  Zan Dobersek  <zdobersek@igalia.com>
 
         Unreviewed. Bumping the WPEBackend-mesa dependency version.
index a2e01b2..15aaae9 100644 (file)
@@ -43,6 +43,7 @@ all_queue_names = [
     "mac-debug-ews",
     "mac-32bit-ews",
     "win-ews",
+    "wpe-ews",
 ]
 
 # If the patch is still active after this much time, then a bot must have frozen or rebooted,
index 674da29..6c64da1 100644 (file)
@@ -79,6 +79,8 @@ class Queue(object):
         display_name = display_name.replace("Ews", "EWS")
         display_name = display_name.replace("Ios", "iOS")
         display_name = display_name.replace("Jsc", "JSC")
+        display_name = display_name.replace("Wpe", "WPE")
+        display_name = display_name.replace("Gtk", "GTK")
         return display_name
 
     _dash_regexp = re.compile("-")
index 11d86e5..de4853c 100644 (file)
@@ -2,7 +2,7 @@
     "GTK WK2 EWS": {
         "port": "gtk-wk2",
         "watchers": [
-            "xan.lopez@gmail.com"
+            "bugs-noreply@webkitgtk.org"
         ]
     },
     "Win EWS": {
         "group": "bindings",
         "runTests": true,
         "shouldBuild": false
+    },
+    "WPE EWS": {
+        "port": "wpe",
+        "watchers": [
+            "bugs-noreply@webkitgtk.org"
+        ]
     }
 }
index 6d152e2..a3d6dd7 100644 (file)
@@ -72,6 +72,7 @@ class DeprecatedPort(object):
             "mac-wk2": MacWK2Port,
             "win": WinPort,
             "wincairo": WinCairoPort,
+            "wpe": WpePort,
         }
         default_port = {
             "Windows": WinPort,
@@ -200,3 +201,19 @@ class GtkWK2Port(DeprecatedPort):
         command = super(GtkWK2Port, self).run_webkit_tests_command(build_style)
         command.append("--gtk")
         return command
+
+
+class WpePort(DeprecatedPort):
+    port_flag_name = "wpe"
+
+    def build_webkit_command(self, build_style=None):
+        command = super(WpePort, self).build_webkit_command(build_style=build_style)
+        command.append("--wpe")
+        command.append("--update-wpe")
+        command.append(super(WpePort, self).makeArgs())
+        return command
+
+    def run_webkit_tests_command(self, build_style=None):
+        command = super(WpePort, self).run_webkit_tests_command(build_style)
+        command.append("--wpe")
+        return command
index 16cd7f9..9e679e2 100644 (file)
@@ -49,3 +49,9 @@ class DeprecatedPortTest(unittest.TestCase):
         self.assertEqual(GtkWK2Port().run_webkit_tests_command(), DeprecatedPort().script_shell_command("run-webkit-tests") + ["--gtk"])
         self.assertEqual(GtkWK2Port().build_webkit_command(), DeprecatedPort().script_shell_command("build-webkit") + ["--gtk", "--update-gtk", DeprecatedPort().makeArgs()])
         self.assertEqual(GtkWK2Port().build_webkit_command(build_style="debug"), DeprecatedPort().script_shell_command("build-webkit") + ["--debug", "--gtk", "--update-gtk", DeprecatedPort().makeArgs()])
+
+    def test_wpe_port(self):
+        self.assertEqual(WpePort().flag(), "--port=wpe")
+        self.assertEqual(WpePort().run_webkit_tests_command(), DeprecatedPort().script_shell_command("run-webkit-tests") + ["--wpe"])
+        self.assertEqual(WpePort().build_webkit_command(), DeprecatedPort().script_shell_command("build-webkit") + ["--wpe", "--update-wpe", DeprecatedPort().makeArgs()])
+        self.assertEqual(WpePort().build_webkit_command(build_style="debug"), DeprecatedPort().script_shell_command("build-webkit") + ["--debug", "--wpe", "--update-wpe", DeprecatedPort().makeArgs()])
index e3f9f6a..adcbf93 100644 (file)
@@ -185,6 +185,7 @@ Running: webkit-patch --status-host=example.com check-patch-relevance --quiet --
             'mac-32bit-ews',
             'bindings-ews',
             'jsc-ews',
+            'wpe-ews',
         }
         classes = AbstractEarlyWarningSystem.load_ews_classes()
         names = {cls.name for cls in classes}