[Modern Media Controls] Turn media/modern-media-controls tests back on by default
authorgraouts@webkit.org <graouts@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 5 Feb 2018 16:33:33 +0000 (16:33 +0000)
committergraouts@webkit.org <graouts@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 5 Feb 2018 16:33:33 +0000 (16:33 +0000)
https://bugs.webkit.org/show_bug.cgi?id=182482

Reviewed by Eric Carlson.

After updating a significant amount of tests under media/modern-media-controls over the last week, we can stop skipping
tests in this directory by default, and instead skip tests that do not apply on a per-platform basis. This patch does that
along with fixing a few remaining tests and adding some more for the new behavior of display 3, 4, 5 or 6 digits for time
labels depending on the overall video duration.

* TestExpectations:
* http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast-expected.txt:
* http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast.html:
* http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click-expected.txt:
* http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click.html:
* http/tests/media/modern-media-controls/status-support/status-support-loading-expected.txt:
* http/tests/media/modern-media-controls/status-support/status-support-loading.html:
* http/tests/media/modern-media-controls/time-control/1-to-10-hours-expected.txt: Added.
* http/tests/media/modern-media-controls/time-control/1-to-10-hours.html: Added.
* http/tests/media/modern-media-controls/time-control/10-hours-or-more-expected.txt: Added.
* http/tests/media/modern-media-controls/time-control/10-hours-or-more.html: Added.
* http/tests/media/modern-media-controls/time-control/10-minutes-to-1-hour-expected.txt: Added.
* http/tests/media/modern-media-controls/time-control/10-minutes-to-1-hour.html: Added.
* http/tests/media/modern-media-controls/time-control/less-than-10-minutes-expected.txt: Renamed from LayoutTests/http/tests/media/modern-media-controls/time-labels-support/long-time-expected.txt.
* http/tests/media/modern-media-controls/time-control/less-than-10-minutes.html: Renamed from LayoutTests/http/tests/media/modern-media-controls/time-labels-support/long-time.html.
* media/modern-media-controls/scrubber-support/scrubber-support-drag.html: Make this test more reliable by going a little further
left of the slider's left-most point to ensure we always get a 0-value.
* platform/ios/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@228097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 files changed:
LayoutTests/ChangeLog
LayoutTests/TestExpectations
LayoutTests/http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast-expected.txt
LayoutTests/http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast.html
LayoutTests/http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click-expected.txt
LayoutTests/http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click.html
LayoutTests/http/tests/media/modern-media-controls/status-support/status-support-loading-expected.txt
LayoutTests/http/tests/media/modern-media-controls/status-support/status-support-loading.html
LayoutTests/http/tests/media/modern-media-controls/time-control/1-to-10-hours-expected.txt [new file with mode: 0644]
LayoutTests/http/tests/media/modern-media-controls/time-control/1-to-10-hours.html [moved from LayoutTests/http/tests/media/modern-media-controls/time-labels-support/long-time.html with 76% similarity]
LayoutTests/http/tests/media/modern-media-controls/time-control/10-hours-or-more-expected.txt [moved from LayoutTests/http/tests/media/modern-media-controls/time-labels-support/long-time-expected.txt with 60% similarity]
LayoutTests/http/tests/media/modern-media-controls/time-control/10-hours-or-more.html [new file with mode: 0644]
LayoutTests/http/tests/media/modern-media-controls/time-control/10-minutes-to-1-hour-expected.txt [new file with mode: 0644]
LayoutTests/http/tests/media/modern-media-controls/time-control/10-minutes-to-1-hour.html [new file with mode: 0644]
LayoutTests/http/tests/media/modern-media-controls/time-control/less-than-10-minutes-expected.txt [new file with mode: 0644]
LayoutTests/http/tests/media/modern-media-controls/time-control/less-than-10-minutes.html [new file with mode: 0644]
LayoutTests/media/modern-media-controls/scrubber-support/scrubber-support-drag.html
LayoutTests/platform/ios/TestExpectations
LayoutTests/platform/mac/TestExpectations

index a01ffb2..88274e2 100644 (file)
@@ -1,3 +1,35 @@
+2018-02-05  Antoine Quint  <graouts@apple.com>
+
+        [Modern Media Controls] Turn media/modern-media-controls tests back on by default
+        https://bugs.webkit.org/show_bug.cgi?id=182482
+
+        Reviewed by Eric Carlson.
+
+        After updating a significant amount of tests under media/modern-media-controls over the last week, we can stop skipping
+        tests in this directory by default, and instead skip tests that do not apply on a per-platform basis. This patch does that
+        along with fixing a few remaining tests and adding some more for the new behavior of display 3, 4, 5 or 6 digits for time
+        labels depending on the overall video duration.
+
+        * TestExpectations:
+        * http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast-expected.txt:
+        * http/tests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-live-broadcast.html:
+        * http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click-expected.txt:
+        * http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click.html:
+        * http/tests/media/modern-media-controls/status-support/status-support-loading-expected.txt:
+        * http/tests/media/modern-media-controls/status-support/status-support-loading.html:
+        * http/tests/media/modern-media-controls/time-control/1-to-10-hours-expected.txt: Added.
+        * http/tests/media/modern-media-controls/time-control/1-to-10-hours.html: Added.
+        * http/tests/media/modern-media-controls/time-control/10-hours-or-more-expected.txt: Added.
+        * http/tests/media/modern-media-controls/time-control/10-hours-or-more.html: Added.
+        * http/tests/media/modern-media-controls/time-control/10-minutes-to-1-hour-expected.txt: Added.
+        * http/tests/media/modern-media-controls/time-control/10-minutes-to-1-hour.html: Added.
+        * http/tests/media/modern-media-controls/time-control/less-than-10-minutes-expected.txt: Renamed from LayoutTests/http/tests/media/modern-media-controls/time-labels-support/long-time-expected.txt.
+        * http/tests/media/modern-media-controls/time-control/less-than-10-minutes.html: Renamed from LayoutTests/http/tests/media/modern-media-controls/time-labels-support/long-time.html.
+        * media/modern-media-controls/scrubber-support/scrubber-support-drag.html: Make this test more reliable by going a little further
+        left of the slider's left-most point to ensure we always get a 0-value.
+        * platform/ios/TestExpectations:
+        * platform/mac/TestExpectations:
+
 2018-02-05  Antti Koivisto  <antti@apple.com>
 
         Crash on sfgate.com because mismatching link preload types
index 620c844..53df891 100644 (file)
@@ -1593,10 +1593,6 @@ webkit.org/b/5991 imported/w3c/web-platform-tests/cssom-view/scrollingElement.ht
 # FileAPI
 webkit.org/b/172099 imported/w3c/web-platform-tests/FileAPI/url/url_xmlhttprequest_img.html [ ImageOnlyFailure ]
 
-# All modern-media-controls tests are disabled for the time being.
-http/tests/media/modern-media-controls [ Skip ]
-media/modern-media-controls [ Skip ]
-
 # Secure Contexts tests that timeout
 imported/w3c/web-platform-tests/secure-contexts/basic-dedicated-worker.html [ Skip ]
 imported/w3c/web-platform-tests/secure-contexts/basic-dedicated-worker.https.html [ Skip ]
index d36fa1e..faf94cd 100644 (file)
@@ -7,7 +7,7 @@ PASS media.duration became Number.POSITIVE_INFINITY
 PASS mediaController.controls.rewindButton.enabled is false
 PASS mediaController.controls.forwardButton.enabled is false
 PASS mediaController.controls.timeControl.parent is null
-PASS mediaController.controls.statusLabel.parent is mediaController.controls.controlsBar
+PASS mediaController.controls.statusLabel.parent is mediaController.controls.bottomControlsBar
 
 PASS successfullyParsed is true
 
index 3d4767f..eadac40 100644 (file)
@@ -2,7 +2,7 @@
 <script src="/media-resources/modern-media-controls/resources/media-controls-loader.js"></script>
 <script src="/media-resources/modern-media-controls/resources/media-controls-utils.js"></script>
 <body>
-<video src="../../resources/hls/test-live.php" style="width: 800px;" autoplay></video>
+<video src="../../resources/hls/test-live.php" style="width: 400px; height: 300px;" autoplay></video>
 <div id="shadow"></div>
 <script type="text/javascript">
 
@@ -22,7 +22,7 @@ media.addEventListener("webkitfullscreenchange", () => {
         shouldBeFalse("mediaController.controls.rewindButton.enabled");
         shouldBeFalse("mediaController.controls.forwardButton.enabled");
         shouldBe("mediaController.controls.timeControl.parent", "null");
-        shouldBe("mediaController.controls.statusLabel.parent", "mediaController.controls.controlsBar");
+        shouldBe("mediaController.controls.statusLabel.parent", "mediaController.controls.bottomControlsBar");
 
         debug("");
         media.remove();
@@ -35,6 +35,7 @@ media.addEventListener("play", () => {
     media.pause();
 
     const button = document.body.appendChild(document.createElement("button"));
+    button.textContent = "Enter fullscreen";
     button.addEventListener("click", event => media.webkitEnterFullscreen());
     pressOnElement(button);
     button.remove();
index 6836771..b6eb9b2 100644 (file)
@@ -3,10 +3,10 @@ Testing the SkipBackSupport behavior by clicking on the mute button.
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-Media seeked to currentTime = 50
+Media seeked to currentTime = 25
 
 Dispatching click event to the skip back button
-Media seeked to currentTime = 20
+Media seeked to currentTime = 10
 
 Dispatching click event to the skip back button
 Media seeked to currentTime = 0
index 000041d..84ed8e1 100644 (file)
@@ -36,7 +36,7 @@ function mediaCanPlay()
 {
     media.removeEventListener("canplaythrough", mediaCanPlay);
     media.addEventListener("seeked", mediaDidSeek);
-    media.currentTime = 50;
+    media.currentTime = 25;
 }
 
 media.addEventListener("canplaythrough", mediaCanPlay);
index 0515bd9..8055866 100644 (file)
@@ -1,9 +1,13 @@
-Testing the StatusSupport behavior for the loading state.
+Testing the TimeControl behavior for the loading state.
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-PASS mediaController.controls.statusLabel.text is "Loading"
+TimeControl should not be in loading state by default.
+PASS mediaController.controls.timeControl.loading is false
+
+Media is stalled, TimeControl should now be in the loading state.
+PASS mediaController.controls.timeControl.loading is true
 
 PASS successfullyParsed is true
 
index 9a78bfe..bd3fd4a 100644 (file)
@@ -7,14 +7,19 @@
 
 window.jsTestIsAsync = true;
 
-description("Testing the <code>StatusSupport</code> behavior for the loading state.");
+description("Testing the <code>TimeControl</code> behavior for the loading state.");
 
 const shadowRoot = document.querySelector("div#shadow").attachShadow({ mode: "open" });
 const media = document.querySelector("video");
 const mediaController = createControls(shadowRoot, media, null);
 
+debug("TimeControl should not be in loading state by default.");
+shouldBeFalse("mediaController.controls.timeControl.loading")
+
 media.addEventListener("stalled", function() {
-    shouldBeEqualToString("mediaController.controls.statusLabel.text", "Loading");
+    debug("");
+    debug("Media is stalled, TimeControl should now be in the loading state.");
+    shouldBeTrue("mediaController.controls.timeControl.loading");
     debug("");
     shadowRoot.host.remove();
     media.remove();
diff --git a/LayoutTests/http/tests/media/modern-media-controls/time-control/1-to-10-hours-expected.txt b/LayoutTests/http/tests/media/modern-media-controls/time-control/1-to-10-hours-expected.txt
new file mode 100644 (file)
index 0000000..7342eac
--- /dev/null
@@ -0,0 +1,11 @@
+Testing the display of time labels with a video that is over 1 hour but less than 10.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS mediaController.controls.timeControl.elapsedTimeLabel.element.textContent became "0:00:05"
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
@@ -1,22 +1,22 @@
 <script src="../../../../../resources/js-test-pre.js"></script>
 <script src="/media-resources/modern-media-controls/resources/media-controls-loader.js"></script>
 <body>
-<video src="../../resources/hls/generate-vod.php?duration=8000" style="width: 320px; height: 240px;"></video>
+<video src="../../resources/hls/generate-vod.php?duration=8000" style="width: 320px; height: 240px;" controls autoplay></video>
 <div id="shadow"></div>
 <script type="text/javascript">
 
 window.jsTestIsAsync = true;
 
-description("Testing the display of time labels with a video that lasts an hour or more.");
+description("Testing the display of time labels with a video that is over 1 hour but less than 10.");
 
 const shadowRoot = document.querySelector("div#shadow").attachShadow({ mode: "open" });
 const media = document.querySelector("video");
 const mediaController = createControls(shadowRoot, media, null);
 
-media.addEventListener("durationchange", function() {
+media.addEventListener("play", () => {
+    media.pause();
     media.currentTime = 5;
-    shouldBeTrue("mediaController.controls.timeControl.useSixDigitsForTimeLabels");
-    shouldBecomeEqualToString("mediaController.controls.timeControl.elapsedTimeLabel.element.textContent", "00:00:05", () => {
+    shouldBecomeEqualToString("mediaController.controls.timeControl.elapsedTimeLabel.element.textContent", "0:00:05", () => {
         debug("");
         shadowRoot.host.remove();
         media.remove();
@@ -1,9 +1,8 @@
-Testing the display of time labels with a video that lasts an hour or more.
+Testing the display of time labels with a video that is over 10 hours.
 
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-PASS mediaController.controls.timeControl.useSixDigitsForTimeLabels is true
 PASS mediaController.controls.timeControl.elapsedTimeLabel.element.textContent became "00:00:05"
 
 PASS successfullyParsed is true
diff --git a/LayoutTests/http/tests/media/modern-media-controls/time-control/10-hours-or-more.html b/LayoutTests/http/tests/media/modern-media-controls/time-control/10-hours-or-more.html
new file mode 100644 (file)
index 0000000..ddfb7a0
--- /dev/null
@@ -0,0 +1,29 @@
+<script src="../../../../../resources/js-test-pre.js"></script>
+<script src="/media-resources/modern-media-controls/resources/media-controls-loader.js"></script>
+<body>
+<video src="../../resources/hls/generate-vod.php?duration=36001" style="width: 320px; height: 240px;" controls autoplay></video>
+<div id="shadow"></div>
+<script type="text/javascript">
+
+window.jsTestIsAsync = true;
+
+description("Testing the display of time labels with a video that is over 10 hours.");
+
+const shadowRoot = document.querySelector("div#shadow").attachShadow({ mode: "open" });
+const media = document.querySelector("video");
+const mediaController = createControls(shadowRoot, media, null);
+
+media.addEventListener("play", () => {
+    media.pause();
+    media.currentTime = 5;
+    shouldBecomeEqualToString("mediaController.controls.timeControl.elapsedTimeLabel.element.textContent", "00:00:05", () => {
+        debug("");
+        shadowRoot.host.remove();
+        media.remove();
+        finishJSTest();
+    });
+});
+
+</script>
+<script src="../../../../../resources/js-test-post.js"></script>
+</body>
diff --git a/LayoutTests/http/tests/media/modern-media-controls/time-control/10-minutes-to-1-hour-expected.txt b/LayoutTests/http/tests/media/modern-media-controls/time-control/10-minutes-to-1-hour-expected.txt
new file mode 100644 (file)
index 0000000..f00044e
--- /dev/null
@@ -0,0 +1,11 @@
+Testing the display of time labels with a video that is 10 minutes or more but less than 1 hour.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS mediaController.controls.timeControl.elapsedTimeLabel.element.textContent became "00:05"
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
diff --git a/LayoutTests/http/tests/media/modern-media-controls/time-control/10-minutes-to-1-hour.html b/LayoutTests/http/tests/media/modern-media-controls/time-control/10-minutes-to-1-hour.html
new file mode 100644 (file)
index 0000000..440a4d4
--- /dev/null
@@ -0,0 +1,29 @@
+<script src="../../../../../resources/js-test-pre.js"></script>
+<script src="/media-resources/modern-media-controls/resources/media-controls-loader.js"></script>
+<body>
+<video src="../../resources/hls/generate-vod.php?duration=800" style="width: 320px; height: 240px;" controls autoplay></video>
+<div id="shadow"></div>
+<script type="text/javascript">
+
+window.jsTestIsAsync = true;
+
+description("Testing the display of time labels with a video that is 10 minutes or more but less than 1 hour.");
+
+const shadowRoot = document.querySelector("div#shadow").attachShadow({ mode: "open" });
+const media = document.querySelector("video");
+const mediaController = createControls(shadowRoot, media, null);
+
+media.addEventListener("play", () => {
+    media.pause();
+    media.currentTime = 5;
+    shouldBecomeEqualToString("mediaController.controls.timeControl.elapsedTimeLabel.element.textContent", "00:05", () => {
+        debug("");
+        shadowRoot.host.remove();
+        media.remove();
+        finishJSTest();
+    });
+});
+
+</script>
+<script src="../../../../../resources/js-test-post.js"></script>
+</body>
diff --git a/LayoutTests/http/tests/media/modern-media-controls/time-control/less-than-10-minutes-expected.txt b/LayoutTests/http/tests/media/modern-media-controls/time-control/less-than-10-minutes-expected.txt
new file mode 100644 (file)
index 0000000..e1a08ed
--- /dev/null
@@ -0,0 +1,11 @@
+Testing the display of time labels with a video that is less than 10 minutes.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS mediaController.controls.timeControl.elapsedTimeLabel.element.textContent became "0:05"
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
diff --git a/LayoutTests/http/tests/media/modern-media-controls/time-control/less-than-10-minutes.html b/LayoutTests/http/tests/media/modern-media-controls/time-control/less-than-10-minutes.html
new file mode 100644 (file)
index 0000000..0d73af6
--- /dev/null
@@ -0,0 +1,29 @@
+<script src="../../../../../resources/js-test-pre.js"></script>
+<script src="/media-resources/modern-media-controls/resources/media-controls-loader.js"></script>
+<body>
+<video src="../../resources/hls/generate-vod.php?duration=599" style="width: 320px; height: 240px;" controls autoplay></video>
+<div id="shadow"></div>
+<script type="text/javascript">
+
+window.jsTestIsAsync = true;
+
+description("Testing the display of time labels with a video that is less than 10 minutes.");
+
+const shadowRoot = document.querySelector("div#shadow").attachShadow({ mode: "open" });
+const media = document.querySelector("video");
+const mediaController = createControls(shadowRoot, media, null);
+
+media.addEventListener("play", () => {
+    media.pause();
+    media.currentTime = 5;
+    shouldBecomeEqualToString("mediaController.controls.timeControl.elapsedTimeLabel.element.textContent", "0:05", () => {
+        debug("");
+        shadowRoot.host.remove();
+        media.remove();
+        finishJSTest();
+    });
+});
+
+</script>
+<script src="../../../../../resources/js-test-post.js"></script>
+</body>
index 0a48be7..e3a0845 100644 (file)
@@ -38,7 +38,7 @@ scheduler.frameDidFire = function() {
     media.pause();
 
     const dragStartX = bounds.left + bounds.width / 2;
-    const dragEndX = bounds.left;
+    const dragEndX = bounds.left - 1;
     const centerY = bounds.top + bounds.height / 2;
 
     media.addEventListener("timeupdate", () => {
index 658efb1..1e88226 100644 (file)
@@ -3190,52 +3190,6 @@ webkit.org/b/179773 imported/w3c/web-platform-tests/fetch/api/abort/serviceworke
 
 webkit.org/b/179784 svg/in-html/by-reference.html [ Failure Timeout ]
 
-# The modern-media-controls tests are disabled due to past flakiness and some major code changes.
-# As a result, a host of tests need to be updated and being turned on selectively here.
-media/modern-media-controls/airplay-button [ Pass ]
-media/modern-media-controls/airplay-placard [ Pass ]
-media/modern-media-controls/audio [ Pass ]
-media/modern-media-controls/background-tint [ Pass ]
-media/modern-media-controls/button [ Pass ]
-media/modern-media-controls/buttons-container [ Pass ]
-media/modern-media-controls/controls-bar [ Pass ]
-media/modern-media-controls/controls-visibility-support [ Pass ]
-media/modern-media-controls/css [ Pass ]
-media/modern-media-controls/forward-button [ Pass ]
-media/modern-media-controls/fullscreen-button [ Pass ]
-media/modern-media-controls/fullscreen-support [ Pass ]
-media/modern-media-controls/icon-service [ Pass ]
-media/modern-media-controls/invalid-placard [ Pass ]
-media/modern-media-controls/ios-inline-media-controls [ Pass ]
-media/modern-media-controls/layout-item [ Pass ]
-media/modern-media-controls/layout-node [ Pass ]
-media/modern-media-controls/localized-strings [ Pass ]
-media/modern-media-controls/media-controller [ Pass ]
-media/modern-media-controls/media-controls [ Pass ]
-media/modern-media-controls/media-documents [ Pass ]
-media/modern-media-controls/mute-button [ Pass ]
-media/modern-media-controls/mute-support [ Pass ]
-media/modern-media-controls/pip-button [ Pass ]
-media/modern-media-controls/pip-placard [ Pass ]
-media/modern-media-controls/pip-support/ipad [ Pass ]
-media/modern-media-controls/placard [ Pass ]
-media/modern-media-controls/placard-support [ Pass ]
-media/modern-media-controls/play-pause-button [ Pass ]
-media/modern-media-controls/playback-support [ Pass ]
-media/modern-media-controls/rewind-button [ Pass ]
-media/modern-media-controls/scheduler [ Pass ]
-media/modern-media-controls/scrubber [ Pass ]
-media/modern-media-controls/scrubber-support [ Pass ]
-media/modern-media-controls/skip-back-button [ Pass ]
-media/modern-media-controls/skip-forward-button [ Pass ]
-media/modern-media-controls/slider [ Pass ]
-media/modern-media-controls/start-support [ Pass ]
-media/modern-media-controls/status-label [ Pass ]
-media/modern-media-controls/status-support [ Pass ]
-media/modern-media-controls/time-control [ Pass ]
-media/modern-media-controls/time-label [ Pass ]
-media/modern-media-controls/time-labels-support [ Pass ]
-
 # accessibilityController.role cannot be tested on iOS
 media/modern-media-controls/time-label/time-label.html [ Skip ]
 media/modern-media-controls/tracks-button [ Pass ]
@@ -3255,8 +3209,12 @@ media/modern-media-controls/mute-support/mute-support-press-on-button.html [ Ski
 media/modern-media-controls/pip-support/ipad/pip-support-tap.html [ Skip ]
 media/modern-media-controls/placard-support/ipad [ Skip ]
 media/modern-media-controls/scrubber-support/ipad/scrubber-support-drag.html [ Skip ]
+media/modern-media-controls/seek-backward-support [ Skip ]
+media/modern-media-controls/seek-forward-support [ Skip ]
 media/modern-media-controls/start-support/start-support-click-to-start.html [ Skip ]
 media/modern-media-controls/start-support/start-support-lowPowerMode.html [ Skip ]
+media/modern-media-controls/volume-down-support [ Skip ]
+media/modern-media-controls/volume-up-support [ Skip ]
 
 # There is no focus state for on iOS
 media/modern-media-controls/button/button-focus-state.html [ Skip ]
@@ -3276,6 +3234,7 @@ media/modern-media-controls/start-support/start-support-fullscreen.html [ Skip ]
 # These tests are designed to work only on macOS
 media/modern-media-controls/button/button-click-on-edges.html [ Skip ]
 media/modern-media-controls/macos-inline-media-controls [ Skip ]
+media/modern-media-controls/macos-fullscreen-media-controls [ Skip ]
 media/modern-media-controls/placard-support/placard-support-pip.html [ Skip ]
 media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html [ Skip ]
 media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-over-controls-bar.html [ Skip ]
@@ -3287,10 +3246,17 @@ media/modern-media-controls/media-controller/media-controller-click-on-video-bac
 media/modern-media-controls/media-controller/media-controller-space-bar-toggle-playback.html [ Skip ]
 media/modern-media-controls/media-documents/media-document-audio-mac-sizing.html [ Skip ]
 media/modern-media-controls/media-documents/media-document-video-mac-sizing.html [ Skip ]
+media/modern-media-controls/pip-support [ Skip ]
 media/modern-media-controls/playback-support/playback-support-button-click.html [ Skip ]
 media/modern-media-controls/scrubber-support/scrubber-support-click.html [ Skip ]
 media/modern-media-controls/scrubber-support/scrubber-support-drag.html [ Skip ]
 media/modern-media-controls/slider/slider-value.html [ Skip ]
+media/modern-media-controls/text-tracks [ Skip ]
+media/modern-media-controls/tracks-panel [ Skip ]
+media/modern-media-controls/tracks-support [ Skip ]
+media/modern-media-controls/volume-support [ Skip ]
+
+media/modern-media-controls/pip-support/ipad [ Pass ]
 
 webkit.org/b/178127 media/modern-media-controls/media-controller/media-controller-video-with-only-audio.html [ Skip ]
 
index 8a18d75..92f668c 100644 (file)
@@ -1441,66 +1441,9 @@ webkit.org/b/171886 imported/w3c/web-platform-tests/streams/readable-byte-stream
 
 webkit.org/b/172469 [ ElCapitan ] imported/w3c/web-platform-tests/WebCryptoAPI/import_export/test_rsa_importKey.https.html [ Timeout ]
 
-# The modern-media-controls tests are disabled due to past flakiness and some major code changes.
-# As a result, a host of tests need to be updated and being turned on selectively here.
-media/modern-media-controls/airplay-button [ Pass ]
-media/modern-media-controls/airplay-placard [ Pass ]
-media/modern-media-controls/airplay-support [ Pass ]
-media/modern-media-controls/audio [ Pass ]
-media/modern-media-controls/background-tint [ Pass ]
-media/modern-media-controls/button [ Pass ]
-media/modern-media-controls/buttons-container [ Pass ]
-media/modern-media-controls/controls-bar [ Pass ]
-media/modern-media-controls/controls-visibility-support [ Pass ]
-media/modern-media-controls/css [ Pass ]
-media/modern-media-controls/forward-button [ Pass ]
-media/modern-media-controls/fullscreen-button [ Pass ]
-media/modern-media-controls/fullscreen-support [ Pass ]
-media/modern-media-controls/icon-service [ Pass ]
-media/modern-media-controls/invalid-placard [ Pass ]
-media/modern-media-controls/layout-item [ Pass ]
-media/modern-media-controls/layout-node [ Pass ]
-media/modern-media-controls/localized-strings [ Pass ]
-media/modern-media-controls/macos-fullscreen-media-controls [ Pass ]
-media/modern-media-controls/macos-inline-media-controls [ Pass ]
-media/modern-media-controls/media-controller [ Pass ]
-media/modern-media-controls/media-controls [ Pass ]
-media/modern-media-controls/media-documents [ Pass ]
-media/modern-media-controls/mute-button [ Pass ]
-media/modern-media-controls/mute-support [ Pass ]
-media/modern-media-controls/pip-button [ Pass ]
-media/modern-media-controls/pip-placard [ Pass ]
-media/modern-media-controls/pip-support [ Pass ]
-media/modern-media-controls/placard [ Pass ]
-media/modern-media-controls/placard-support [ Pass ]
-media/modern-media-controls/play-pause-button [ Pass ]
-media/modern-media-controls/playback-support [ Pass ]
-media/modern-media-controls/rewind-button [ Pass ]
-media/modern-media-controls/scheduler [ Pass ]
-media/modern-media-controls/scrubber [ Pass ]
-media/modern-media-controls/scrubber-support [ Pass ]
-media/modern-media-controls/seek-backward-support [ Pass ]
-media/modern-media-controls/seek-forward-support [ Pass ]
-media/modern-media-controls/skip-back-button [ Pass ]
-media/modern-media-controls/skip-forward-button [ Pass ]
-media/modern-media-controls/slider [ Pass ]
-media/modern-media-controls/start-support [ Pass ]
-media/modern-media-controls/status-label [ Pass ]
-media/modern-media-controls/status-support [ Pass ]
-media/modern-media-controls/text-tracks [ Pass ]
-media/modern-media-controls/time-control [ Pass ]
-media/modern-media-controls/time-label [ Pass ]
-media/modern-media-controls/time-label/ios-time-label.html [ Skip ]
-media/modern-media-controls/time-labels-support [ Pass ]
-media/modern-media-controls/tracks-panel [ Pass ]
-media/modern-media-controls/tracks-support [ Pass ]
-media/modern-media-controls/tracks-button [ Pass ]
-media/modern-media-controls/volume-down-support [ Pass ]
-media/modern-media-controls/volume-support [ Pass ]
-media/modern-media-controls/volume-up-support [ Pass ]
-
 # These tests are iOS-specific
 media/modern-media-controls/audio/audio-controls-styles.html [ Skip ]
+media/modern-media-controls/ios-inline-media-controls [ Skip ]
 media/modern-media-controls/placard-support/ipad [ Skip ]
 media/modern-media-controls/media-controller/ios [ Skip ]
 media/modern-media-controls/media-documents/ipad [ Skip ]