Unreviewed, rolling out r215046.
authorryanhaddad@apple.com <ryanhaddad@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 6 Apr 2017 23:11:45 +0000 (23:11 +0000)
committerryanhaddad@apple.com <ryanhaddad@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 6 Apr 2017 23:11:45 +0000 (23:11 +0000)
This change broke internal builds.

Reverted changeset:

"WebRTC tests gardening"
https://bugs.webkit.org/show_bug.cgi?id=170508
http://trac.webkit.org/changeset/215046

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@215066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 files changed:
LayoutTests/ChangeLog
LayoutTests/platform/ios-wk1/TestExpectations
LayoutTests/platform/ios-wk2/TestExpectations
LayoutTests/platform/ios/TestExpectations
Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig
Source/WebCore/ChangeLog
Source/WebCore/Configurations/FeatureDefines.xcconfig
Source/WebCore/PAL/ChangeLog
Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig
Source/WebKit/mac/ChangeLog
Source/WebKit/mac/Configurations/FeatureDefines.xcconfig
Source/WebKit2/ChangeLog
Source/WebKit2/Configurations/FeatureDefines.xcconfig
Tools/ChangeLog
Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig

index 99be178..bc539a6 100644 (file)
@@ -1,5 +1,17 @@
 2017-04-06  Ryan Haddad  <ryanhaddad@apple.com>
 
+        Unreviewed, rolling out r215046.
+
+        This change broke internal builds.
+
+        Reverted changeset:
+
+        "WebRTC tests gardening"
+        https://bugs.webkit.org/show_bug.cgi?id=170508
+        http://trac.webkit.org/changeset/215046
+
+2017-04-06  Ryan Haddad  <ryanhaddad@apple.com>
+
         Skip a test that was accidentally enabled with r214982.
 
         Unreviewed test gardening.
index 648af8e..9ff6a18 100644 (file)
@@ -10,7 +10,6 @@ editing/input/focus-change-with-marked-text.html [ Pass ]
 # Skip WebRTC for now in WK1
 imported/w3c/web-platform-tests/webrtc [ Skip ]
 webrtc [ Skip ]
-fast/events/constructors/media-stream-event-constructor.html
 
 # <rdar://problem/6501130> LayoutTests: Enable editing tests after we support editing
 editing/deleting/4922367.html
index 3373d8b..9c4a417 100644 (file)
@@ -1842,10 +1842,6 @@ fast/scrolling/ios/scroll-events-back-forward-after-pageshow.html [ Pass Failure
 
 webkit.org/b/157589 fast/text-autosizing/ios/text-autosizing-after-back.html [ Pass Timeout ]
 
-#See webkit.org/b/170508
-webrtc/video.html [ Failure ]
-webrtc/video-with-receiver.html [ Failure ]
-
 # started to fail after new snapshotting in r202532
 webkit.org/b/150942 animations/multiple-backgrounds.html [ Pass ImageOnlyFailure ]
 compositing/contents-scale/rasterization-scale.html [ ImageOnlyFailure ]
@@ -1925,6 +1921,9 @@ fast/css/deferred-parsing/hover-test.html [ Skip ]
 
 webkit.org/b/166025 http/tests/fetch/fetching-same-resource-with-diffferent-options.html [ Pass Failure ]
 
+imported/w3c/web-platform-tests/webrtc [ Skip ]
+webrtc [ Skip ]
+
 # Skipped because there is no key to show the context menu
 fast/events/context-activated-by-key-event.html [ Skip ]
 
index 497c813..674c71b 100644 (file)
@@ -59,6 +59,9 @@ fast/history/page-cache-closed-audiocontext.html
 fast/history/page-cache-running-audiocontext.html
 fast/history/page-cache-suspended-audiocontext.html
 
+# WebRTC tests are skipped on iOS for now.
+fast/events/constructors/media-stream-event-constructor.html
+
 # No wheel events on iOS
 fast/scrolling/iframe-scrollable-after-back.html [ Skip ]
 fast/scrolling/overflow-scrollable-after-back.html [ Skip ]
index 41712b2..b0a69ed 100644 (file)
@@ -1,3 +1,15 @@
+2017-04-06  Ryan Haddad  <ryanhaddad@apple.com>
+
+        Unreviewed, rolling out r215046.
+
+        This change broke internal builds.
+
+        Reverted changeset:
+
+        "WebRTC tests gardening"
+        https://bugs.webkit.org/show_bug.cgi?id=170508
+        http://trac.webkit.org/changeset/215046
+
 2017-04-06  Joseph Pecoraro  <pecoraro@apple.com>
 
         Web Inspector: Show all headers in the Request Headers section of the Resource details sidebar
index f3d52bf..a00dddb 100644 (file)
@@ -184,8 +184,9 @@ ENABLE_SVG_FONTS = ENABLE_SVG_FONTS;
 ENABLE_WEB_RTC[sdk=watch*] = ;
 ENABLE_WEB_RTC[sdk=appletv*] = ;
 ENABLE_WEB_RTC[sdk=iphone*] = $(ENABLE_WEB_RTC_ios);
-ENABLE_WEB_RTC_ios[arch=arm64] = ENABLE_WEB_RTC;
-ENABLE_WEB_RTC_ios[arch=x86_64] = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios[arch=arm64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base))
+ENABLE_WEB_RTC_ios[arch=x86_64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base))
+ENABLE_WEB_RTC_ios_11 = ENABLE_WEB_RTC;
 ENABLE_WEB_RTC[sdk=macosx*] = $(ENABLE_WEB_RTC_macosx);
 ENABLE_WEB_RTC_macosx[arch=x86_64] = $(ENABLE_WEB_RTC_macosx_$(CONFIGURATION));
 ENABLE_WEB_RTC_macosx_Debug = ENABLE_WEB_RTC;
index 36df114..e1e8dc6 100644 (file)
@@ -1,3 +1,15 @@
+2017-04-06  Ryan Haddad  <ryanhaddad@apple.com>
+
+        Unreviewed, rolling out r215046.
+
+        This change broke internal builds.
+
+        Reverted changeset:
+
+        "WebRTC tests gardening"
+        https://bugs.webkit.org/show_bug.cgi?id=170508
+        http://trac.webkit.org/changeset/215046
+
 2017-04-06  Joseph Pecoraro  <pecoraro@apple.com>
 
         Web Inspector: Only Capture Extra Network Load Metrics when there is a Web Inspector Frontend
index f3d52bf..a00dddb 100644 (file)
@@ -184,8 +184,9 @@ ENABLE_SVG_FONTS = ENABLE_SVG_FONTS;
 ENABLE_WEB_RTC[sdk=watch*] = ;
 ENABLE_WEB_RTC[sdk=appletv*] = ;
 ENABLE_WEB_RTC[sdk=iphone*] = $(ENABLE_WEB_RTC_ios);
-ENABLE_WEB_RTC_ios[arch=arm64] = ENABLE_WEB_RTC;
-ENABLE_WEB_RTC_ios[arch=x86_64] = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios[arch=arm64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base))
+ENABLE_WEB_RTC_ios[arch=x86_64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base))
+ENABLE_WEB_RTC_ios_11 = ENABLE_WEB_RTC;
 ENABLE_WEB_RTC[sdk=macosx*] = $(ENABLE_WEB_RTC_macosx);
 ENABLE_WEB_RTC_macosx[arch=x86_64] = $(ENABLE_WEB_RTC_macosx_$(CONFIGURATION));
 ENABLE_WEB_RTC_macosx_Debug = ENABLE_WEB_RTC;
index 8539738..6a07f74 100644 (file)
@@ -1,3 +1,15 @@
+2017-04-06  Ryan Haddad  <ryanhaddad@apple.com>
+
+        Unreviewed, rolling out r215046.
+
+        This change broke internal builds.
+
+        Reverted changeset:
+
+        "WebRTC tests gardening"
+        https://bugs.webkit.org/show_bug.cgi?id=170508
+        http://trac.webkit.org/changeset/215046
+
 2017-04-06  Youenn Fablet  <youenn@apple.com>
 
         WebRTC tests gardening
index f3d52bf..a00dddb 100644 (file)
@@ -184,8 +184,9 @@ ENABLE_SVG_FONTS = ENABLE_SVG_FONTS;
 ENABLE_WEB_RTC[sdk=watch*] = ;
 ENABLE_WEB_RTC[sdk=appletv*] = ;
 ENABLE_WEB_RTC[sdk=iphone*] = $(ENABLE_WEB_RTC_ios);
-ENABLE_WEB_RTC_ios[arch=arm64] = ENABLE_WEB_RTC;
-ENABLE_WEB_RTC_ios[arch=x86_64] = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios[arch=arm64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base))
+ENABLE_WEB_RTC_ios[arch=x86_64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base))
+ENABLE_WEB_RTC_ios_11 = ENABLE_WEB_RTC;
 ENABLE_WEB_RTC[sdk=macosx*] = $(ENABLE_WEB_RTC_macosx);
 ENABLE_WEB_RTC_macosx[arch=x86_64] = $(ENABLE_WEB_RTC_macosx_$(CONFIGURATION));
 ENABLE_WEB_RTC_macosx_Debug = ENABLE_WEB_RTC;
index 4c30f73..cb591dd 100644 (file)
@@ -1,3 +1,15 @@
+2017-04-06  Ryan Haddad  <ryanhaddad@apple.com>
+
+        Unreviewed, rolling out r215046.
+
+        This change broke internal builds.
+
+        Reverted changeset:
+
+        "WebRTC tests gardening"
+        https://bugs.webkit.org/show_bug.cgi?id=170508
+        http://trac.webkit.org/changeset/215046
+
 2017-04-06  Tim Horton  <timothy_horton@apple.com>
 
         Obj-C bindings build fails with CSS_DEVICE_ADAPTATION turned on
index f3d52bf..a00dddb 100644 (file)
@@ -184,8 +184,9 @@ ENABLE_SVG_FONTS = ENABLE_SVG_FONTS;
 ENABLE_WEB_RTC[sdk=watch*] = ;
 ENABLE_WEB_RTC[sdk=appletv*] = ;
 ENABLE_WEB_RTC[sdk=iphone*] = $(ENABLE_WEB_RTC_ios);
-ENABLE_WEB_RTC_ios[arch=arm64] = ENABLE_WEB_RTC;
-ENABLE_WEB_RTC_ios[arch=x86_64] = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios[arch=arm64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base))
+ENABLE_WEB_RTC_ios[arch=x86_64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base))
+ENABLE_WEB_RTC_ios_11 = ENABLE_WEB_RTC;
 ENABLE_WEB_RTC[sdk=macosx*] = $(ENABLE_WEB_RTC_macosx);
 ENABLE_WEB_RTC_macosx[arch=x86_64] = $(ENABLE_WEB_RTC_macosx_$(CONFIGURATION));
 ENABLE_WEB_RTC_macosx_Debug = ENABLE_WEB_RTC;
index d8a0859..0b70b2e 100644 (file)
@@ -1,3 +1,15 @@
+2017-04-06  Ryan Haddad  <ryanhaddad@apple.com>
+
+        Unreviewed, rolling out r215046.
+
+        This change broke internal builds.
+
+        Reverted changeset:
+
+        "WebRTC tests gardening"
+        https://bugs.webkit.org/show_bug.cgi?id=170508
+        http://trac.webkit.org/changeset/215046
+
 2017-04-06  Joseph Pecoraro  <pecoraro@apple.com>
 
         Web Inspector: Only Capture Extra Network Load Metrics when there is a Web Inspector Frontend
index f3d52bf..a00dddb 100644 (file)
@@ -184,8 +184,9 @@ ENABLE_SVG_FONTS = ENABLE_SVG_FONTS;
 ENABLE_WEB_RTC[sdk=watch*] = ;
 ENABLE_WEB_RTC[sdk=appletv*] = ;
 ENABLE_WEB_RTC[sdk=iphone*] = $(ENABLE_WEB_RTC_ios);
-ENABLE_WEB_RTC_ios[arch=arm64] = ENABLE_WEB_RTC;
-ENABLE_WEB_RTC_ios[arch=x86_64] = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios[arch=arm64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base))
+ENABLE_WEB_RTC_ios[arch=x86_64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base))
+ENABLE_WEB_RTC_ios_11 = ENABLE_WEB_RTC;
 ENABLE_WEB_RTC[sdk=macosx*] = $(ENABLE_WEB_RTC_macosx);
 ENABLE_WEB_RTC_macosx[arch=x86_64] = $(ENABLE_WEB_RTC_macosx_$(CONFIGURATION));
 ENABLE_WEB_RTC_macosx_Debug = ENABLE_WEB_RTC;
index 1319164..9ffe7ac 100644 (file)
@@ -1,3 +1,15 @@
+2017-04-06  Ryan Haddad  <ryanhaddad@apple.com>
+
+        Unreviewed, rolling out r215046.
+
+        This change broke internal builds.
+
+        Reverted changeset:
+
+        "WebRTC tests gardening"
+        https://bugs.webkit.org/show_bug.cgi?id=170508
+        http://trac.webkit.org/changeset/215046
+
 2017-04-06  Youenn Fablet  <youenn@apple.com>
 
         WebRTC tests gardening
index f3d52bf..a00dddb 100644 (file)
@@ -184,8 +184,9 @@ ENABLE_SVG_FONTS = ENABLE_SVG_FONTS;
 ENABLE_WEB_RTC[sdk=watch*] = ;
 ENABLE_WEB_RTC[sdk=appletv*] = ;
 ENABLE_WEB_RTC[sdk=iphone*] = $(ENABLE_WEB_RTC_ios);
-ENABLE_WEB_RTC_ios[arch=arm64] = ENABLE_WEB_RTC;
-ENABLE_WEB_RTC_ios[arch=x86_64] = ENABLE_WEB_RTC;
+ENABLE_WEB_RTC_ios[arch=arm64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base))
+ENABLE_WEB_RTC_ios[arch=x86_64] = $(ENABLE_WEB_RTC_ios_$(IPHONEOS_DEPLOYMENT_TARGET:base))
+ENABLE_WEB_RTC_ios_11 = ENABLE_WEB_RTC;
 ENABLE_WEB_RTC[sdk=macosx*] = $(ENABLE_WEB_RTC_macosx);
 ENABLE_WEB_RTC_macosx[arch=x86_64] = $(ENABLE_WEB_RTC_macosx_$(CONFIGURATION));
 ENABLE_WEB_RTC_macosx_Debug = ENABLE_WEB_RTC;