REGRESSION: Weak symbol warning when linking TestWebKitAPI
authorfpizlo@apple.com <fpizlo@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 24 Jun 2016 23:49:15 +0000 (23:49 +0000)
committerfpizlo@apple.com <fpizlo@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 24 Jun 2016 23:49:15 +0000 (23:49 +0000)
https://bugs.webkit.org/show_bug.cgi?id=159104

Reviewed by Mark Lam.

The problem is that the tests were not compiled with -fvisibility=hidden like the rest of
WK.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj

index 1b151d7..e8bd2f3 100644 (file)
@@ -1,3 +1,15 @@
+2016-06-24  Filip Pizlo  <fpizlo@apple.com>
+
+        REGRESSION: Weak symbol warning when linking TestWebKitAPI
+        https://bugs.webkit.org/show_bug.cgi?id=159104
+
+        Reviewed by Mark Lam.
+        
+        The problem is that the tests were not compiled with -fvisibility=hidden like the rest of
+        WK.
+
+        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+
 2016-06-24  David Kilzer  <ddkilzer@apple.com>
 
         parser_unittests.pl should not hardcode list of tests
 2016-06-24  David Kilzer  <ddkilzer@apple.com>
 
         parser_unittests.pl should not hardcode list of tests
index edf1467..04a1fce 100644 (file)
                        isa = XCBuildConfiguration;
                        baseConfigurationReference = 7C83E0271D0A5B8D00FEBCF3 /* TestWTFLibrary.xcconfig */;
                        buildSettings = {
                        isa = XCBuildConfiguration;
                        baseConfigurationReference = 7C83E0271D0A5B8D00FEBCF3 /* TestWTFLibrary.xcconfig */;
                        buildSettings = {
+                               OTHER_CPLUSPLUSFLAGS = (
+                                       "$(inherited)",
+                                       "-ftemplate-depth=256",
+                                       "-fvisibility=hidden",
+                               );
                        };
                        name = Debug;
                };
                        };
                        name = Debug;
                };
                        isa = XCBuildConfiguration;
                        baseConfigurationReference = 7C83E0271D0A5B8D00FEBCF3 /* TestWTFLibrary.xcconfig */;
                        buildSettings = {
                        isa = XCBuildConfiguration;
                        baseConfigurationReference = 7C83E0271D0A5B8D00FEBCF3 /* TestWTFLibrary.xcconfig */;
                        buildSettings = {
+                               OTHER_CPLUSPLUSFLAGS = (
+                                       "$(inherited)",
+                                       "-ftemplate-depth=256",
+                                       "-fvisibility=hidden",
+                               );
                        };
                        name = Release;
                };
                        };
                        name = Release;
                };