Remove a test that times out.
authorfpizlo@apple.com <fpizlo@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 15 Aug 2013 21:33:45 +0000 (21:33 +0000)
committerfpizlo@apple.com <fpizlo@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 15 Aug 2013 21:33:45 +0000 (21:33 +0000)
Rubber stamped by Mark Hahnenberg.

This test times out for me, every time. It tests code that has since been rewritten
and has had new tests added to cover it. It's not clear that this test would be
useful anymore even if we made it not timeout.

* fast/js/array-sort-modifying-tostring-expected.txt: Removed.
* fast/js/array-sort-modifying-tostring.html: Removed.
* fast/js/script-tests/array-sort-modifying-tostring.js: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@154135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/fast/js/array-sort-modifying-tostring-expected.txt [deleted file]
LayoutTests/fast/js/array-sort-modifying-tostring.html [deleted file]
LayoutTests/fast/js/script-tests/array-sort-modifying-tostring.js [deleted file]

index d961320..c62fbd5 100644 (file)
@@ -1,3 +1,17 @@
+2013-08-15  Filip Pizlo  <fpizlo@apple.com>
+
+        Remove a test that times out.
+        
+        Rubber stamped by Mark Hahnenberg.
+        
+        This test times out for me, every time. It tests code that has since been rewritten
+        and has had new tests added to cover it. It's not clear that this test would be
+        useful anymore even if we made it not timeout.
+
+        * fast/js/array-sort-modifying-tostring-expected.txt: Removed.
+        * fast/js/array-sort-modifying-tostring.html: Removed.
+        * fast/js/script-tests/array-sort-modifying-tostring.js: Removed.
+
 2013-08-15  Dirk Schulze  <krit@webkit.org>
 
         Implement CSS Image filter() function
diff --git a/LayoutTests/fast/js/array-sort-modifying-tostring-expected.txt b/LayoutTests/fast/js/array-sort-modifying-tostring-expected.txt
deleted file mode 100644 (file)
index 21ec761..0000000
+++ /dev/null
@@ -1,11 +0,0 @@
-Test of array with toString() override that truncates array.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS Array length is unchanged.
-PASS Array values are correct.
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
diff --git a/LayoutTests/fast/js/array-sort-modifying-tostring.html b/LayoutTests/fast/js/array-sort-modifying-tostring.html
deleted file mode 100644 (file)
index 697b44c..0000000
+++ /dev/null
@@ -1,10 +0,0 @@
-<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">
-<html>
-<head>
-<script src="resources/js-test-pre.js"></script>
-</head>
-<body>
-<script src="script-tests/array-sort-modifying-tostring.js"></script>
-<script src="resources/js-test-post.js"></script>
-</body>
-</html>
diff --git a/LayoutTests/fast/js/script-tests/array-sort-modifying-tostring.js b/LayoutTests/fast/js/script-tests/array-sort-modifying-tostring.js
deleted file mode 100644 (file)
index 270465b..0000000
+++ /dev/null
@@ -1,75 +0,0 @@
-description(
-"Test of array with toString() override that truncates array."
-);
-
-var maxSize = 2000;
-var keepSize = 100;
-var digits = 4;
-var countToDelete = maxSize - keepSize;
-
-var a = new Array(maxSize);
-
-function do_gc() {
-    if (window.GCController)
-        return GCController.collect();
-
-    for (var i = 0; i < 1000; i++)
-        new String(i);
-}
-
-function Item(val) {
-    this.value = val;
-}
-
-function toString_Mutate() {
-    a.splice(keepSize, countToDelete);
-    do_gc();
-    for (var i = keepSize; i < countToDelete; i++) {
-        delete a[i];
-    }
-
-    if ((this != undefined) && (this.value != undefined)) {
-        var s = this.value.toString();
-        if (s.length < digits)
-            s = ('0000' + s).slice(-digits);
-
-        return s;
-    } else
-        return "Undef";
-}
-
-function test() {
-    for (var i = 0; i < a.length; i++) {
-        a[i] = new Item(a.length - i - 1);
-        a[i].toString = toString_Mutate;
-    }
-    try {
-        a.sort();
-    if (a.length == maxSize)
-        testPassed("Array length is unchanged.");
-    else
-        testFailed("Array length should be " + maxSize + " but is " + a.length + ".");
-
-    var firstFailedValue = -1;
-
-    for (var i = 0; i < a.length; i++) {
-        if (a[i].value != i) {
-            firstFailedValue = i;
-            break;
-        }
-    }
-
-    if (firstFailedValue == -1)
-        testPassed("Array values are correct.");
-    else
-        testFailed("Array values are wrong, first bad value at index " + firstFailedValue + ", should be " + firstFailedValue + " was " + a[firstFailedValue].value + ".");
-    } catch(er) {
-        testFailed("Got exception processing sort()");
-    }
-
-    for (var i = 0; i < a.length; i++) {
-        a[i] = 0x42424242;
-    }
-}
-
-test();