Reviewed by Adam Roben.
authorap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 12 Jul 2010 20:39:47 +0000 (20:39 +0000)
committerap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 12 Jul 2010 20:39:47 +0000 (20:39 +0000)
        https://bugs.webkit.org/show_bug.cgi?id=13075
        XMLHttpRequest with failed authentication should set status to 401

        https://bugs.webkit.org/show_bug.cgi?id=6871
        <rdar://problem/3363403> 401 error page is never shown

        Fix crashes in Windows DumpRenderTree.

        * DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
        If we return an error, WebKit will call continueWithoutCredentialForAuthenticationChallenge()
        again on a destroyed sender.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKitTools/ChangeLog
WebKitTools/DumpRenderTree/win/ResourceLoadDelegate.cpp

index dacc3cb..34ac82e 100644 (file)
@@ -1,3 +1,19 @@
+2010-07-12  Alexey Proskuryakov  <ap@apple.com>
+
+        Reviewed by Adam Roben.
+
+        https://bugs.webkit.org/show_bug.cgi?id=13075
+        XMLHttpRequest with failed authentication should set status to 401
+
+        https://bugs.webkit.org/show_bug.cgi?id=6871
+        <rdar://problem/3363403> 401 error page is never shown
+
+        Fix crashes in Windows DumpRenderTree.
+
+        * DumpRenderTree/win/ResourceLoadDelegate.cpp: (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
+        If we return an error, WebKit will call continueWithoutCredentialForAuthenticationChallenge()
+        again on a destroyed sender.
+
 2010-07-12  Adam Roben  <aroben@apple.com>
 
         Windows failure-to-launch fix
index c422c11..ce01933 100644 (file)
@@ -286,7 +286,7 @@ HRESULT STDMETHODCALLTYPE ResourceLoadDelegate::didReceiveAuthenticationChalleng
 
     if (!gLayoutTestController->handlesAuthenticationChallenges()) {
         sender->continueWithoutCredentialForAuthenticationChallenge(challenge);
-        return E_FAIL;
+        return S_OK;
     }
     
     const char* user = gLayoutTestController->authenticationUsername().c_str();