Remove some virtual methods in CachedRawResource
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 5 Nov 2018 13:55:21 +0000 (13:55 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 5 Nov 2018 13:55:21 +0000 (13:55 +0000)
https://bugs.webkit.org/show_bug.cgi?id=191251

Patch by Rob Buis <rbuis@igalia.com> on 2018-11-05
Reviewed by Frédéric Wang.

Since CachedRawResource is final no need to introduce new virtual
methods in CachedRawResource. This patch also removes an outdated
comment and forward declaration.

No new tests since no change in functionality.

* loader/cache/CachedRawResource.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/loader/cache/CachedRawResource.h

index 73ea083..9ab7bd2 100644 (file)
@@ -1,3 +1,18 @@
+2018-11-05  Rob Buis  <rbuis@igalia.com>
+
+        Remove some virtual methods in CachedRawResource
+        https://bugs.webkit.org/show_bug.cgi?id=191251
+
+        Reviewed by Frédéric Wang.
+
+        Since CachedRawResource is final no need to introduce new virtual
+        methods in CachedRawResource. This patch also removes an outdated
+        comment and forward declaration.
+
+        No new tests since no change in functionality.
+
+        * loader/cache/CachedRawResource.h:
+
 2018-11-05  Philippe Normand  <pnormand@igalia.com>
 
         [GStreamer] Move elements registration to GStreamerCommon
index 2d3dac9..cf29c30 100644 (file)
@@ -29,18 +29,14 @@ namespace WebCore {
 class CachedResourceClient;
 class ResourceTiming;
 class SharedBufferDataView;
-class SubresourceLoader;
 
 class CachedRawResource final : public CachedResource {
 public:
     CachedRawResource(CachedResourceRequest&&, Type, PAL::SessionID);
 
-    // FIXME: AssociatedURLLoader shouldn't be a DocumentThreadableLoader and therefore shouldn't
-    // use CachedRawResource. However, it is, and it needs to be able to defer loading.
-    // This can be fixed by splitting CORS preflighting out of DocumentThreacableLoader.
-    virtual void setDefersLoading(bool);
+    void setDefersLoading(bool);
 
-    virtual void setDataBufferingPolicy(DataBufferingPolicy);
+    void setDataBufferingPolicy(DataBufferingPolicy);
 
     // FIXME: This is exposed for the InspectorInstrumentation for preflights in DocumentThreadableLoader. It's also really lame.
     unsigned long identifier() const { return m_identifier; }