2009-04-18 Xan Lopez <xlopez@igalia.com>
authorxan@webkit.org <xan@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 27 Apr 2009 21:40:31 +0000 (21:40 +0000)
committerxan@webkit.org <xan@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 27 Apr 2009 21:40:31 +0000 (21:40 +0000)
        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=21546
        [GTK] ATK accessibility enhancements

        Do not call ATK setters in the getters, just return the
        value. Among other things calling the setter will emit the notify
        signal, which is wrong.

        * page/gtk/AccessibilityObjectWrapperAtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog
WebCore/page/gtk/AccessibilityObjectWrapperAtk.cpp

index 0552727..1f412bd 100644 (file)
@@ -1,3 +1,16 @@
+2009-04-18  Xan Lopez  <xlopez@igalia.com>
+
+        Reviewed by Gustavo Noronha.
+
+        https://bugs.webkit.org/show_bug.cgi?id=21546
+        [GTK] ATK accessibility enhancements
+
+        Do not call ATK setters in the getters, just return the
+        value. Among other things calling the setter will emit the notify
+        signal, which is wrong.
+
+        * page/gtk/AccessibilityObjectWrapperAtk.cpp:
+
 2009-04-16  Xan Lopez  <xlopez@igalia.com>
 
         Reviewed by Gustavo Noronha.
index 057b948..95de8bc 100644 (file)
@@ -121,21 +121,14 @@ extern "C" {
 
 static const gchar* webkit_accessible_get_name(AtkObject* object)
 {
-    // TODO: Deal with later changes.
-    if (!object->name)
-        atk_object_set_name(object, core(object)->stringValue().utf8().data());
-    return object->name;
+    return returnString(core(object)->stringValue());
 }
 
 static const gchar* webkit_accessible_get_description(AtkObject* object)
 {
     // TODO: the Mozilla MSAA implementation prepends "Description: "
     // Should we do this too?
-
-    // TODO: Deal with later changes.
-    if (!object->description)
-        atk_object_set_description(object, core(object)->accessibilityDescription().utf8().data());
-    return object->description;
+    return returnString(core(object)->accessibilityDescription());
 }
 
 static AtkObject* webkit_accessible_get_parent(AtkObject* object)