Web Inspector: Remove unused WebInspectorProxy code
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 15 Nov 2018 22:42:56 +0000 (22:42 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 15 Nov 2018 22:42:56 +0000 (22:42 +0000)
https://bugs.webkit.org/show_bug.cgi?id=191674

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2018-11-15
Reviewed by Dean Jackson.

* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::createInspectorPage):
(WebKit::WebInspectorProxy::closeFrontendPageAndWindow):
* UIProcess/WebInspectorProxy.h:
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::setInspectorWindowFrame): Deleted.
(WebKit::WebInspectorProxy::inspectorWindowFrame): Deleted.
* WebProcess/WebPage/WebInspector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/ChangeLog
Source/WebKit/UIProcess/WebInspectorProxy.cpp
Source/WebKit/UIProcess/WebInspectorProxy.h
Source/WebKit/UIProcess/mac/WebInspectorProxyMac.mm
Source/WebKit/WebProcess/WebPage/WebInspector.h

index ad0228f..5c1313d 100644 (file)
@@ -1,3 +1,19 @@
+2018-11-15  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Remove unused WebInspectorProxy code
+        https://bugs.webkit.org/show_bug.cgi?id=191674
+
+        Reviewed by Dean Jackson.
+
+        * UIProcess/WebInspectorProxy.cpp:
+        (WebKit::WebInspectorProxy::createInspectorPage):
+        (WebKit::WebInspectorProxy::closeFrontendPageAndWindow):
+        * UIProcess/WebInspectorProxy.h:
+        * UIProcess/mac/WebInspectorProxyMac.mm:
+        (WebKit::WebInspectorProxy::setInspectorWindowFrame): Deleted.
+        (WebKit::WebInspectorProxy::inspectorWindowFrame): Deleted.
+        * WebProcess/WebPage/WebInspector.h:
+
 2018-11-15  Ryosuke Niwa  <rniwa@webkit.org>
 
         Enable process swap on cross-site navigation by default on macOS
index 635c3d6..8cd6213 100644 (file)
@@ -353,9 +353,7 @@ void WebInspectorProxy::createInspectorPage(IPC::Attachment connectionIdentifier
     if (!m_inspectorPage)
         return;
 
-    m_connectionIdentifier = WTFMove(connectionIdentifier);
-
-    m_inspectorPage->process().send(Messages::WebInspectorUI::EstablishConnection(m_connectionIdentifier, m_inspectedPage->pageID(), m_underTest, inspectionLevel()), m_inspectorPage->pageID());
+    m_inspectorPage->process().send(Messages::WebInspectorUI::EstablishConnection(WTFMove(connectionIdentifier), m_inspectedPage->pageID(), m_underTest, inspectionLevel()), m_inspectorPage->pageID());
 
     if (!m_underTest) {
         m_canAttach = platformCanAttach(canAttach);
@@ -437,8 +435,6 @@ void WebInspectorProxy::closeFrontendPageAndWindow()
     m_canAttach = false;
     m_underTest = false;
 
-    m_connectionIdentifier = IPC::Attachment();
-
     platformCloseFrontendPageAndWindow();
 }
 
index 6782de9..d4e6069 100644 (file)
@@ -107,9 +107,6 @@ public:
     void windowFullScreenDidChange();
     NSWindow* inspectorWindow() const { return m_inspectorWindow.get(); }
 
-    void setInspectorWindowFrame(WKRect&);
-    WKRect inspectorWindowFrame();
-
     void closeFrontendPage();
     void closeFrontendAfterInactivityTimerFired();
 
@@ -243,8 +240,6 @@ private:
     bool m_ignoreElementSelectionChange { false };
     bool m_isOpening { false };
 
-    IPC::Attachment m_connectionIdentifier;
-
     AttachmentSide m_attachmentSide {AttachmentSide::Bottom};
 
 #if PLATFORM(MAC) && WK_API_ENABLED
index 70e1340..9832632 100644 (file)
@@ -210,23 +210,6 @@ void WebInspectorProxy::attachmentDidMoveToWindow(NSWindow *newWindow)
     }
 }
 
-void WebInspectorProxy::setInspectorWindowFrame(WKRect& frame)
-{
-    if (m_isAttached)
-        return;
-
-    [m_inspectorWindow setFrame:NSMakeRect(frame.origin.x, frame.origin.y, frame.size.width, frame.size.height) display:YES];
-}
-
-WKRect WebInspectorProxy::inspectorWindowFrame()
-{
-    if (m_isAttached)
-        return WKRectMake(0, 0, 0, 0);
-
-    NSRect frame = m_inspectorWindow.get().frame;
-    return WKRectMake(frame.origin.x, frame.origin.y, frame.size.width, frame.size.height);
-}
-
 void WebInspectorProxy::updateInspectorWindowTitle() const
 {
     if (!m_inspectorWindow)
index e0c5124..5c11df3 100644 (file)
@@ -54,9 +54,6 @@ public:
     void didClose(IPC::Connection&) override { close(); }
     void didReceiveInvalidMessage(IPC::Connection&, IPC::StringReference, IPC::StringReference) override { close(); }
 
-    // Called by WebInspector messages
-    void connectionEstablished();
-
     void show();
     void close();