[GTK] Remove the --enable-unstable-features configuration option
authorzandobersek@gmail.com <zandobersek@gmail.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 20 Dec 2012 15:26:35 +0000 (15:26 +0000)
committerzandobersek@gmail.com <zandobersek@gmail.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 20 Dec 2012 15:26:35 +0000 (15:26 +0000)
https://bugs.webkit.org/show_bug.cgi?id=105327

Reviewed by Martin Robinson.

.:

Remove the unnecessary feature_defines_unstable variable.
Remove the unstable-features configuration option.

* configure.ac:
* GNUmakefile.am:

Source/WebCore:

Remove the ENABLE_UNSTABLE_FEATURES guards in various GNUmakefiles now that
the configuration option is removed.

No new tests - no new testable functionality.

* GNUmakefile.am: Remove the ENABLE_UNSTABLE_FEATURES guards in GNUmakefile.am
where they were used to override certain feature define values in case of a release build.
* GNUmakefile.features.am.in: Adjust the default value for the feature defines that were
previously overriden in release builds. This feature define list will eventually represent
feature status in release builds with overriding being done through build-webkit.
* bindings/gobject/GNUmakefile.am: Move the DOM bindings targets that were previously guarded
by the ENABLE_UNSTABLE_FEATURES guards to the common listing of the video-dependent DOM bindings.

Tools:

Add a missing feature option for the CSS sticky position feature.

* Scripts/webkitperl/FeatureList.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@138252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ChangeLog
GNUmakefile.am
Source/WebCore/ChangeLog
Source/WebCore/GNUmakefile.am
Source/WebCore/GNUmakefile.features.am.in
Source/WebCore/bindings/gobject/GNUmakefile.am
Tools/ChangeLog
Tools/Scripts/webkitperl/FeatureList.pm
configure.ac

index b1d5d45..30076d1 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,16 @@
+2012-12-20  Zan Dobersek  <zandobersek@gmail.com>
+
+        [GTK] Remove the --enable-unstable-features configuration option
+        https://bugs.webkit.org/show_bug.cgi?id=105327
+
+        Reviewed by Martin Robinson.
+
+        Remove the unnecessary feature_defines_unstable variable.
+        Remove the unstable-features configuration option.
+
+        * configure.ac:
+        * GNUmakefile.am:
+
 2012-12-20  Dominik Röttsches  <dominik.rottsches@intel.com>
 
         [EFL] MiniBrowser does not play Infinite Gangnam Style
 2012-12-20  Dominik Röttsches  <dominik.rottsches@intel.com>
 
         [EFL] MiniBrowser does not play Infinite Gangnam Style
index dbf4bbf..f51d39f 100644 (file)
@@ -62,7 +62,6 @@ MOFILES :=
 ALL_MOFILES :=
 feature_defines_defaults :=
 feature_defines_overrides :=
 ALL_MOFILES :=
 feature_defines_defaults :=
 feature_defines_overrides :=
-feature_defines_unstable :=
 feature_defines :=
 dom_binding_idls :=
 wtf_sources :=
 feature_defines :=
 dom_binding_idls :=
 wtf_sources :=
index 88a2095..934daae 100644 (file)
@@ -1,3 +1,23 @@
+2012-12-20  Zan Dobersek  <zandobersek@gmail.com>
+
+        [GTK] Remove the --enable-unstable-features configuration option
+        https://bugs.webkit.org/show_bug.cgi?id=105327
+
+        Reviewed by Martin Robinson.
+
+        Remove the ENABLE_UNSTABLE_FEATURES guards in various GNUmakefiles now that
+        the configuration option is removed.
+
+        No new tests - no new testable functionality.
+
+        * GNUmakefile.am: Remove the ENABLE_UNSTABLE_FEATURES guards in GNUmakefile.am
+        where they were used to override certain feature define values in case of a release build.
+        * GNUmakefile.features.am.in: Adjust the default value for the feature defines that were
+        previously overriden in release builds. This feature define list will eventually represent
+        feature status in release builds with overriding being done through build-webkit.
+        * bindings/gobject/GNUmakefile.am: Move the DOM bindings targets that were previously guarded
+        by the ENABLE_UNSTABLE_FEATURES guards to the common listing of the video-dependent DOM bindings.
+
 2012-12-20  Florin Malita  <fmalita@chromium.org>
 
         Incorrect color space conversion for FEImage
 2012-12-20  Florin Malita  <fmalita@chromium.org>
 
         Incorrect color space conversion for FEImage
index df715ba..02c4c6d 100644 (file)
@@ -342,22 +342,6 @@ else
 feature_defines_overrides += ENABLE_SPELLCHECK=0
 endif  # END ENABLE_SPELLCHECK
 
 feature_defines_overrides += ENABLE_SPELLCHECK=0
 endif  # END ENABLE_SPELLCHECK
 
-# ---
-# Unstable features
-# If unstable features should not be enabled, their defines should be overriden with a 0 value.
-# ---
-if !ENABLE_UNSTABLE_FEATURES
-feature_defines_unstable += \
-       ENABLE_CSP_NEXT=0 \
-       ENABLE_CSS3_TEXT=0 \
-       ENABLE_CSS_STICKY_POSITION=0 \
-       ENABLE_LINK_PREFETCH=0 \
-       ENABLE_MICRODATA=0 \
-       ENABLE_MUTATION_OBSERVERS=0 \
-       ENABLE_STYLE_SCOPED=0 \
-       ENABLE_VIDEO_TRACK=0
-endif
-
 
 # Fill the feature_defines variable with all the defines, making it possible
 # to override the default define value (as set in feature_defines_defaults)
 
 # Fill the feature_defines variable with all the defines, making it possible
 # to override the default define value (as set in feature_defines_defaults)
@@ -369,12 +353,9 @@ feature_defines += $(strip $(foreach bare_define, \
                        $(if $(findstring =$(fvalue),$(define)),$(patsubst %=$(fvalue),%,$(define))) \
                ) \
        ), \
                        $(if $(findstring =$(fvalue),$(define)),$(patsubst %=$(fvalue),%,$(define))) \
                ) \
        ), \
-       $(if $(findstring $(bare_define)=, $(feature_defines_unstable)), \
-               $(filter $(bare_define)=%,$(feature_defines_unstable)), \
-               $(if $(findstring $(bare_define)=, $(feature_defines_overrides)), \
-                       $(filter $(bare_define)=%,$(feature_defines_overrides)), \
-                       $(filter $(bare_define)=%,$(feature_defines_defaults)) \
-               ) \
+       $(if $(findstring $(bare_define)=, $(feature_defines_overrides)), \
+               $(filter $(bare_define)=%,$(feature_defines_overrides)), \
+               $(filter $(bare_define)=%,$(feature_defines_defaults)) \
        ) \
 ))
 
        ) \
 ))
 
index 33b7d9d..d18fc71 100644 (file)
@@ -5,8 +5,8 @@ feature_defines_defaults += \
        ENABLE_BATTERY_STATUS=0 \
        ENABLE_BLOB=1 \
        ENABLE_CHANNEL_MESSAGING=1 \
        ENABLE_BATTERY_STATUS=0 \
        ENABLE_BLOB=1 \
        ENABLE_CHANNEL_MESSAGING=1 \
-       ENABLE_CSP_NEXT=1 \
-       ENABLE_CSS3_TEXT=1 \
+       ENABLE_CSP_NEXT=0 \
+       ENABLE_CSS3_TEXT=0 \
        ENABLE_CSS_BOX_DECORATION_BREAK=1 \
        ENABLE_CSS_COMPOSITING=0 \
        ENABLE_CSS_DEVICE_ADAPTATION=0 \
        ENABLE_CSS_BOX_DECORATION_BREAK=1 \
        ENABLE_CSS_COMPOSITING=0 \
        ENABLE_CSS_DEVICE_ADAPTATION=0 \
@@ -16,7 +16,7 @@ feature_defines_defaults += \
        ENABLE_CSS_IMAGE_RESOLUTION=0 \
        ENABLE_CSS_REGIONS=1 \
        ENABLE_CSS_SHADERS=0 \
        ENABLE_CSS_IMAGE_RESOLUTION=0 \
        ENABLE_CSS_REGIONS=1 \
        ENABLE_CSS_SHADERS=0 \
-       ENABLE_CSS_STICKY_POSITION=1 \
+       ENABLE_CSS_STICKY_POSITION=0 \
        ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED=1 \
        ENABLE_CSS_VARIABLES=0 \
        ENABLE_CSS3_CONDITIONAL_RULES=0 \
        ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED=1 \
        ENABLE_CSS_VARIABLES=0 \
        ENABLE_CSS3_CONDITIONAL_RULES=0 \
@@ -53,7 +53,7 @@ feature_defines_defaults += \
        ENABLE_LEGACY_NOTIFICATIONS=0 \
        ENABLE_LEGACY_VENDOR_PREFIXES=1 \
        ENABLE_LEGACY_WEB_AUDIO=1 \
        ENABLE_LEGACY_NOTIFICATIONS=0 \
        ENABLE_LEGACY_VENDOR_PREFIXES=1 \
        ENABLE_LEGACY_WEB_AUDIO=1 \
-       ENABLE_LINK_PREFETCH=1 \
+       ENABLE_LINK_PREFETCH=0 \
        ENABLE_LINK_PRERENDER=0 \
        ENABLE_MATHML=1 \
        ENABLE_MEDIA_CAPTURE=0 \
        ENABLE_LINK_PRERENDER=0 \
        ENABLE_MATHML=1 \
        ENABLE_MEDIA_CAPTURE=0 \
@@ -62,9 +62,9 @@ feature_defines_defaults += \
        ENABLE_MEDIA_STREAM=1 \
        ENABLE_METER_ELEMENT=1 \
        ENABLE_MHTML=1 \
        ENABLE_MEDIA_STREAM=1 \
        ENABLE_METER_ELEMENT=1 \
        ENABLE_MHTML=1 \
-       ENABLE_MICRODATA=1 \
+       ENABLE_MICRODATA=0 \
        ENABLE_MOUSE_CURSOR_SCALE=0 \
        ENABLE_MOUSE_CURSOR_SCALE=0 \
-       ENABLE_MUTATION_OBSERVERS=1 \
+       ENABLE_MUTATION_OBSERVERS=0 \
        ENABLE_NAVIGATOR_CONTENT_UTILS=0 \
        ENABLE_NETSCAPE_PLUGIN_API=1 \
        ENABLE_NETWORK_INFO=0 \
        ENABLE_NAVIGATOR_CONTENT_UTILS=0 \
        ENABLE_NETSCAPE_PLUGIN_API=1 \
        ENABLE_NETWORK_INFO=0 \
@@ -81,7 +81,7 @@ feature_defines_defaults += \
        ENABLE_SMOOTH_SCROLLING=1 \
        ENABLE_SPELLCHECK=1 \
        ENABLE_SQL_DATABASE=1 \
        ENABLE_SMOOTH_SCROLLING=1 \
        ENABLE_SPELLCHECK=1 \
        ENABLE_SQL_DATABASE=1 \
-       ENABLE_STYLE_SCOPED=1 \
+       ENABLE_STYLE_SCOPED=0 \
        ENABLE_SVG=1 \
        ENABLE_SVG_DOM_OBJC_BINDINGS=0 \
        ENABLE_SVG_FONTS=1 \
        ENABLE_SVG=1 \
        ENABLE_SVG_DOM_OBJC_BINDINGS=0 \
        ENABLE_SVG_FONTS=1 \
@@ -91,7 +91,7 @@ feature_defines_defaults += \
        ENABLE_TOUCH_ICON_LOADING=0 \
        ENABLE_VIBRATION=0 \
        ENABLE_VIDEO=1 \
        ENABLE_TOUCH_ICON_LOADING=0 \
        ENABLE_VIBRATION=0 \
        ENABLE_VIDEO=1 \
-       ENABLE_VIDEO_TRACK=1 \
+       ENABLE_VIDEO_TRACK=0 \
        ENABLE_WEBGL=1 \
        ENABLE_WEB_AUDIO=0 \
        ENABLE_WEB_INTENTS=0 \
        ENABLE_WEBGL=1 \
        ENABLE_WEB_AUDIO=0 \
        ENABLE_WEB_INTENTS=0 \
index dfb76de..67bee68 100644 (file)
@@ -423,22 +423,17 @@ webkitgtk_gdom_built_h_api += \
 if ENABLE_VIDEO
 webkitgtk_gdom_built_h_api += \
        $(top_builddir)/DerivedSources/webkitdom/WebKitDOMHTMLAudioElement.h \
 if ENABLE_VIDEO
 webkitgtk_gdom_built_h_api += \
        $(top_builddir)/DerivedSources/webkitdom/WebKitDOMHTMLAudioElement.h \
-       $(top_builddir)/DerivedSources/webkitdom/WebKitDOMHTMLVideoElement.h
-webkitgtk_gdom_built_sources += \
-       DerivedSources/webkitdom/WebKitDOMHTMLAudioElement.cpp \
-       DerivedSources/webkitdom/WebKitDOMHTMLAudioElementPrivate.h \
-       DerivedSources/webkitdom/WebKitDOMHTMLVideoElement.cpp \
-       DerivedSources/webkitdom/WebKitDOMHTMLVideoElementPrivate.h
-
-# Video Track feature currently depends on HTML Video and is considered unstable.
-if ENABLE_UNSTABLE_FEATURES
-webkitgtk_gdom_built_h_api += \
+       $(top_builddir)/DerivedSources/webkitdom/WebKitDOMHTMLVideoElement.h \
        $(top_builddir)/DerivedSources/webkitdom/WebKitDOMTextTrack.h \
        $(top_builddir)/DerivedSources/webkitdom/WebKitDOMTextTrackList.h \
        $(top_builddir)/DerivedSources/webkitdom/WebKitDOMTextTrackCue.h \
        $(top_builddir)/DerivedSources/webkitdom/WebKitDOMTextTrackCueList.h \
        $(top_builddir)/DerivedSources/webkitdom/WebKitDOMTrackEvent.h
 webkitgtk_gdom_built_sources += \
        $(top_builddir)/DerivedSources/webkitdom/WebKitDOMTextTrack.h \
        $(top_builddir)/DerivedSources/webkitdom/WebKitDOMTextTrackList.h \
        $(top_builddir)/DerivedSources/webkitdom/WebKitDOMTextTrackCue.h \
        $(top_builddir)/DerivedSources/webkitdom/WebKitDOMTextTrackCueList.h \
        $(top_builddir)/DerivedSources/webkitdom/WebKitDOMTrackEvent.h
 webkitgtk_gdom_built_sources += \
+       DerivedSources/webkitdom/WebKitDOMHTMLAudioElement.cpp \
+       DerivedSources/webkitdom/WebKitDOMHTMLAudioElementPrivate.h \
+       DerivedSources/webkitdom/WebKitDOMHTMLVideoElement.cpp \
+       DerivedSources/webkitdom/WebKitDOMHTMLVideoElementPrivate.h \
        DerivedSources/webkitdom/WebKitDOMTextTrack.cpp \
        DerivedSources/webkitdom/WebKitDOMTextTrackPrivate.h \
        DerivedSources/webkitdom/WebKitDOMTextTrackList.cpp \
        DerivedSources/webkitdom/WebKitDOMTextTrack.cpp \
        DerivedSources/webkitdom/WebKitDOMTextTrackPrivate.h \
        DerivedSources/webkitdom/WebKitDOMTextTrackList.cpp \
@@ -450,7 +445,6 @@ webkitgtk_gdom_built_sources += \
        DerivedSources/webkitdom/WebKitDOMTrackEvent.cpp \
        DerivedSources/webkitdom/WebKitDOMTrackEventPrivate.h
 endif
        DerivedSources/webkitdom/WebKitDOMTrackEvent.cpp \
        DerivedSources/webkitdom/WebKitDOMTrackEventPrivate.h
 endif
-endif
 
 BUILT_SOURCES += \
        $(webkitgtk_gdom_built_h_api) \
 
 BUILT_SOURCES += \
        $(webkitgtk_gdom_built_h_api) \
index d676a0e..180c1ab 100644 (file)
@@ -1,3 +1,14 @@
+2012-12-20  Zan Dobersek  <zandobersek@gmail.com>
+
+        [GTK] Remove the --enable-unstable-features configuration option
+        https://bugs.webkit.org/show_bug.cgi?id=105327
+
+        Reviewed by Martin Robinson.
+
+        Add a missing feature option for the CSS sticky position feature.
+
+        * Scripts/webkitperl/FeatureList.pm:
+
 2012-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
 
         Unreviewed. Skip unit test WebKit2.ForceRepaint that times out
 2012-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
 
         Unreviewed. Skip unit test WebKit2.ForceRepaint that times out
index 612701a..10b4e7a 100644 (file)
@@ -61,6 +61,7 @@ my (
     $cssImageResolutionSupport,
     $cssRegionsSupport,
     $cssShadersSupport,
     $cssImageResolutionSupport,
     $cssRegionsSupport,
     $cssShadersSupport,
+    $cssStickyPositionSupport,
     $cssCompositingSupport,
     $cssAnimationsTransitionsTransformsUnprefixedSupport,
     $cssVariablesSupport,
     $cssCompositingSupport,
     $cssAnimationsTransitionsTransformsUnprefixedSupport,
     $cssVariablesSupport,
@@ -201,6 +202,9 @@ my @features = (
     { option => "css-shaders", desc => "Toggle CSS Shaders support",
       define => "ENABLE_CSS_SHADERS", default => isAppleMacWebKit(), value => \$cssShadersSupport },
 
     { option => "css-shaders", desc => "Toggle CSS Shaders support",
       define => "ENABLE_CSS_SHADERS", default => isAppleMacWebKit(), value => \$cssShadersSupport },
 
+    { option => "css-sticky-position", desc => "Toggle CSS sticky position support",
+      define => "ENABLE_CSS_STICKY_POSITION", default => isGtk(), value => \$cssStickyPositionSupport },
+
     { option => "css-compositing", desc => "Toggle CSS Compositing support",
       define => "ENABLE_CSS_COMPOSITING", default => isAppleWebKit(), value => \$cssCompositingSupport },
 
     { option => "css-compositing", desc => "Toggle CSS Compositing support",
       define => "ENABLE_CSS_COMPOSITING", default => isAppleWebKit(), value => \$cssCompositingSupport },
 
index 0564bb1..aa420ba 100644 (file)
@@ -500,14 +500,6 @@ AC_ARG_ENABLE(optimizations,
               [if test "$enable_debug" = "yes"; then enable_optimizations="no"; else enable_optimizations="yes"; fi])
 AC_MSG_RESULT([$enable_optimizations])
 
               [if test "$enable_debug" = "yes"; then enable_optimizations="no"; else enable_optimizations="yes"; fi])
 AC_MSG_RESULT([$enable_optimizations])
 
-# check whether to enable unstable features
-AC_MSG_CHECKING([whether to enable unstable features])
-AC_ARG_ENABLE(unstable_features,
-              AC_HELP_STRING([--enable-unstable-features],
-                             [enable unstable features [default=no]]),
-              [],[enable_unstable_features="no"])
-AC_MSG_RESULT([$enable_unstable_features])
-
 found_opengl=no
 AC_ARG_ENABLE(glx,
               AC_HELP_STRING([--enable-glx], [enable support for GLX [default=auto]]),
 found_opengl=no
 AC_ARG_ENABLE(glx,
               AC_HELP_STRING([--enable-glx], [enable support for GLX [default=auto]]),
@@ -649,7 +641,7 @@ AC_MSG_CHECKING([whether to enable Gamepad support])
 AC_ARG_ENABLE(gamepad,
               AC_HELP_STRING([--enable-gamepad],
                              [enable Gamepad support [default=no]]),
 AC_ARG_ENABLE(gamepad,
               AC_HELP_STRING([--enable-gamepad],
                              [enable Gamepad support [default=no]]),
-              [],[enable_gamepad=$enable_unstable_features])
+              [],[enable_gamepad="no"])
 AC_MSG_RESULT([$enable_gamepad])
 
 if test "$enable_gamepad" = "yes" && test "$os_linux" = no; then
 AC_MSG_RESULT([$enable_gamepad])
 
 if test "$enable_gamepad" = "yes" && test "$os_linux" = no; then
@@ -670,7 +662,7 @@ AC_MSG_CHECKING([whether to enable media stream support])
 AC_ARG_ENABLE(media_stream,
               AC_HELP_STRING([--enable-media-stream],
                              [enable media stream support (incomplete) [default=no]]),
 AC_ARG_ENABLE(media_stream,
               AC_HELP_STRING([--enable-media-stream],
                              [enable media stream support (incomplete) [default=no]]),
-              [],[enable_media_stream=$enable_unstable_features])
+              [],[enable_media_stream="no"])
 AC_MSG_RESULT([$enable_media_stream])
 
 # check whether to enable XSLT support
 AC_MSG_RESULT([$enable_media_stream])
 
 # check whether to enable XSLT support
@@ -854,11 +846,11 @@ AC_ARG_ENABLE([introspection],
   [],[enable_introspection=no])
 AC_MSG_RESULT([$enable_introspection])
 
   [],[enable_introspection=no])
 AC_MSG_RESULT([$enable_introspection])
 
-# Enable CSS Filters and Shaders if unstable_features and accelerated_compositing are turned on.
+# Enable CSS Filters and Shaders if accelerated_compositing is turned on.
 enable_css_filters=no;
 enable_css_shaders=no;
 AC_MSG_CHECKING([whether to enable CSS Filters and Shaders])
 enable_css_filters=no;
 enable_css_shaders=no;
 AC_MSG_CHECKING([whether to enable CSS Filters and Shaders])
-if test "$enable_unstable_features" = "yes" && test "$enable_accelerated_compositing" = "yes" && test "$with_acceleration_backend" = "opengl"; then
+if test "$enable_accelerated_compositing" = "yes" && test "$with_acceleration_backend" = "opengl"; then
     enable_css_filters=yes;
     enable_css_shaders=yes;
 fi
     enable_css_filters=yes;
     enable_css_shaders=yes;
 fi
@@ -1164,7 +1156,6 @@ AM_CONDITIONAL([USE_FARSTREAM], [test "$have_farstream" = "yes"])
 
 # WebKit feature conditionals
 AM_CONDITIONAL([ENABLE_DEBUG],[test "$enable_debug_features" = "yes"])
 
 # WebKit feature conditionals
 AM_CONDITIONAL([ENABLE_DEBUG],[test "$enable_debug_features" = "yes"])
-AM_CONDITIONAL([ENABLE_UNSTABLE_FEATURES],[test "$enable_unstable_features" = "yes"])
 AM_CONDITIONAL([ENABLE_WEBGL],[test "$enable_webgl" = "yes"])
 AM_CONDITIONAL([ENABLE_GAMEPAD],[test "$enable_gamepad" = "yes"])
 AM_CONDITIONAL([ENABLE_XSLT],[test "$enable_xslt" = "yes"])
 AM_CONDITIONAL([ENABLE_WEBGL],[test "$enable_webgl" = "yes"])
 AM_CONDITIONAL([ENABLE_GAMEPAD],[test "$enable_gamepad" = "yes"])
 AM_CONDITIONAL([ENABLE_XSLT],[test "$enable_xslt" = "yes"])