Followup to:
authorbeidson@apple.com <beidson@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 5 Dec 2017 01:19:25 +0000 (01:19 +0000)
committerbeidson@apple.com <beidson@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 5 Dec 2017 01:19:25 +0000 (01:19 +0000)
Get a directory path to SWServers for storing ServiceWorker registrations
https://bugs.webkit.org/show_bug.cgi?id=180362

Unreviewed.

* StorageProcess/StorageProcess.cpp:
(WebKit::StorageProcess::swServerForSession): Change this ASSERT which is invalid in private browsing sessions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@225510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/ChangeLog
Source/WebKit/StorageProcess/StorageProcess.cpp

index 4c48b6f..bc27400 100644 (file)
@@ -1,3 +1,14 @@
+2017-12-04  Brady Eidson  <beidson@apple.com>
+
+        Followup to:
+        Get a directory path to SWServers for storing ServiceWorker registrations
+        https://bugs.webkit.org/show_bug.cgi?id=180362
+
+        Unreviewed.
+
+        * StorageProcess/StorageProcess.cpp:
+        (WebKit::StorageProcess::swServerForSession): Change this ASSERT which is invalid in private browsing sessions.
+
 2017-12-04  Simon Fraser  <simon.fraser@apple.com>
 
         Minor DisplayRefreshMonitor-related cleanup
index ad9590e..2f7a501 100644 (file)
@@ -387,7 +387,7 @@ SWServer& StorageProcess::swServerForSession(PAL::SessionID sessionID)
     auto path = m_swDatabasePaths.get(sessionID);
     // There should already be a registered path for this PAL::SessionID.
     // If there's not, then where did this PAL::SessionID come from?
-    ASSERT(!path.isEmpty());
+    ASSERT(sessionID.isEphemeral() || !path.isEmpty());
 
     result.iterator->value = std::make_unique<SWServer>(makeUniqueRef<WebSWOriginStore>(), path);
     return *result.iterator->value;