Enable requestAnimationFrame on Windows
authorcmarrin@apple.com <cmarrin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 26 Sep 2011 23:02:17 +0000 (23:02 +0000)
committercmarrin@apple.com <cmarrin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 26 Sep 2011 23:02:17 +0000 (23:02 +0000)
https://bugs.webkit.org/show_bug.cgi?id=68397

Reviewed by Simon Fraser.

Source/JavaScriptCore:

Enabled REQUEST_ANIMATION_FRAME_TIMER for Windows

* wtf/Platform.h:

WebKitLibraries:

Enable REQUEST_ANIMATION_FRAME for Windows

* win/tools/vsprops/FeatureDefines.vsprops:

LayoutTests:

Unskip requestAnimationFrame tests for Windows. request-animation-frame-during-modal.html
is still skipped because it uses showModalDialog which is not supported in DRT on Windows

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/win/Skipped
Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/wtf/Platform.h
Source/WebCore/DerivedSources.cpp
Source/WebCore/WebCore.vcproj/WebCore.vcproj
Source/WebCore/bindings/js/JSBindingsAllInOne.cpp
WebKitLibraries/ChangeLog
WebKitLibraries/win/tools/vsprops/FeatureDefines.vsprops

index 9742db1..90a46f3 100644 (file)
@@ -1,3 +1,15 @@
+2011-09-26  Chris Marrin  <cmarrin@apple.com>
+
+        Enable requestAnimationFrame on Windows
+        https://bugs.webkit.org/show_bug.cgi?id=68397
+
+        Reviewed by Simon Fraser.
+
+        Unskip requestAnimationFrame tests for Windows. request-animation-frame-during-modal.html
+        is still skipped because it uses showModalDialog which is not supported in DRT on Windows
+
+        * platform/win/Skipped:
+
 2011-09-26  Ryosuke Niwa  <rniwa@webkit.org>
 
         editing/selection/select-bidi-run.html timeouts on non-Mac platforms
index 0b0c271..150b8f2 100644 (file)
@@ -1244,9 +1244,8 @@ editing/selection/caret-mode-paragraph-keys-navigation.html
 # DRT does not obey addURLToRedirect
 http/tests/loading/cross-origin-XHR-willLoadRequest.html
 
-# Request ENABLE(REQUEST_ANIMATION_FRAME) support
-fast/animation
-inspector/timeline/timeline-animation-frame.html
+# Uses showModalDialog (https://bugs.webkit.org/show_bug.cgi?id=53675)
+fast/animation/request-animation-frame-during-modal.html
 
 # This port doesn't support v8 i18n extension.
 fast/js/i18n-bindings-locale.html
index 2bc2530..073f2d1 100644 (file)
@@ -1,3 +1,14 @@
+2011-09-26  Chris Marrin  <cmarrin@apple.com>
+
+        Enable requestAnimationFrame on Windows
+        https://bugs.webkit.org/show_bug.cgi?id=68397
+
+        Reviewed by Simon Fraser.
+
+        Enabled REQUEST_ANIMATION_FRAME_TIMER for Windows
+
+        * wtf/Platform.h:
+
 2011-09-26  Noel Gordon  <noel.gordon@gmail.com>
 
         [Chromium] Remove DFGAliasTracker.h references from gyp project files
index 34f691c..aff68a3 100644 (file)
 #define WTF_USE_AVFOUNDATION 1
 #endif
 
-#if PLATFORM(MAC) || PLATFORM(GTK)
+#if PLATFORM(MAC) || PLATFORM(GTK) || (PLATFORM(WIN) && !OS(WINCE) && !PLATFORM(WIN_CAIRO))
+#define WTF_USE_REQUEST_ANIMATION_FRAME_TIMER 1
 #define WTF_USE_REQUEST_ANIMATION_FRAME_TIMER 1
 #endif
 
index 8a45986..d3bb827 100644 (file)
 #include "JSRange.cpp"
 #include "JSRangeException.cpp"
 #include "JSRect.cpp"
+#include "JSRequestAnimationFrameCallback.cpp"
 #include "JSRGBColor.cpp"
 #include "JSScreen.cpp"
 #include "JSScriptProfile.cpp"
index 581518b..a98309e 100755 (executable)
                                >
                        </File>
                        <File
+                               RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSRequestAnimationFrameCallback.cpp"
+                               >
+                               <FileConfiguration
+                                       Name="Debug|Win32"
+                                       ExcludedFromBuild="true"
+                                       >
+                                       <Tool
+                                               Name="VCCLCompilerTool"
+                                       />
+                               </FileConfiguration>
+                               <FileConfiguration
+                                       Name="Release|Win32"
+                                       ExcludedFromBuild="true"
+                                       >
+                                       <Tool
+                                               Name="VCCLCompilerTool"
+                                       />
+                               </FileConfiguration>
+                               <FileConfiguration
+                                       Name="Debug_Cairo_CFLite|Win32"
+                                       ExcludedFromBuild="true"
+                                       >
+                                       <Tool
+                                               Name="VCCLCompilerTool"
+                                       />
+                               </FileConfiguration>
+                               <FileConfiguration
+                                       Name="Release_Cairo_CFLite|Win32"
+                                       ExcludedFromBuild="true"
+                                       >
+                                       <Tool
+                                               Name="VCCLCompilerTool"
+                                       />
+                               </FileConfiguration>
+                               <FileConfiguration
+                                       Name="Debug_All|Win32"
+                                       ExcludedFromBuild="true"
+                                       >
+                                       <Tool
+                                               Name="VCCLCompilerTool"
+                                       />
+                               </FileConfiguration>
+                               <FileConfiguration
+                                       Name="Production|Win32"
+                                       ExcludedFromBuild="true"
+                                       >
+                                       <Tool
+                                               Name="VCCLCompilerTool"
+                                       />
+                               </FileConfiguration>
+                       </File>
+                       <File
+                               RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSRequestAnimationFrameCallback.h"
+                               >
+                       </File>
+                       <File
                                RelativePath="$(ConfigurationBuildDir)\obj\$(ProjectName)\DerivedSources\JSRGBColor.cpp"
                                >
                                <FileConfiguration
                                >
                        </File>
                        <File
+                               RelativePath="..\dom\ScriptedAnimationController.cpp"
+                               >
+                       </File>
+                       <File
+                               RelativePath="..\dom\ScriptedAnimationController.h"
+                               >
+                       </File>
+                       <File
                                RelativePath="..\dom\ScriptElement.cpp"
                                >
                                <FileConfiguration
                                        </FileConfiguration>
                                </File>
                                <File
+                                       RelativePath="..\bindings\js\JSRequestAnimationFrameCallbackCustom.cpp"
+                                       >
+                                       <FileConfiguration
+                                               Name="Debug|Win32"
+                                               ExcludedFromBuild="true"
+                                               >
+                                               <Tool
+                                                       Name="VCCLCompilerTool"
+                                               />
+                                       </FileConfiguration>
+                               </File>
+                               <File
                                        RelativePath="..\bindings\js\JSScriptProfileNodeCustom.cpp"
                                        >
                                        <FileConfiguration
                                        >
                                </File>
                                <File
-                                       RelativePath="..\inspector\front-end\UglifyJS\JavaScriptFormatter.js"
+                                       RelativePath="..\inspector\front-end\JavaScriptFormatter.js"
                                        >
                                </File>
                                <File
-                                       RelativePath="..\inspector\front-end\JavaScriptFormatter.js"
+                                       RelativePath="..\inspector\front-end\UglifyJS\JavaScriptFormatter.js"
                                        >
                                </File>
                                <File
index af34774..ea957a6 100644 (file)
 #include "JSPeerConnectionCustom.cpp"
 #include "JSPluginElementFunctions.cpp"
 #include "JSProcessingInstructionCustom.cpp"
+#include "JSRequestAnimationFrameCallbackCustom.cpp"
 #include "JSSQLResultSetRowListCustom.cpp"
 #include "JSSQLTransactionCustom.cpp"
 #include "JSSQLTransactionSyncCustom.cpp"
index 18c29b4..ff39e0f 100644 (file)
@@ -1,3 +1,14 @@
+2011-09-26  Chris Marrin  <cmarrin@apple.com>
+
+        Enable requestAnimationFrame on Windows
+        https://bugs.webkit.org/show_bug.cgi?id=68397
+
+        Reviewed by Simon Fraser.
+
+        Enable REQUEST_ANIMATION_FRAME for Windows
+
+        * win/tools/vsprops/FeatureDefines.vsprops:
+
 2011-09-24  Adam Barth  <abarth@webkit.org>
 
         Always enable ENABLE(OFFLINE_WEB_APPLICATIONS)
index f949d87..434b708 100644 (file)
@@ -9,9 +9,14 @@
        >
   <Tool
                Name="VCCLCompilerTool"
-               PreprocessorDefinitions="$(ENABLE_3D_CANVAS);$(ENABLE_3D_RENDERING);$(ENABLE_ACCELERATED_2D_CANVAS);$(ENABLE_BLOB);$(ENABLE_CHANNEL_MESSAGING);$(ENABLE_CLIENT_BASED_GEOLOCATION);$(ENABLE_CSS_FILTERS);$(ENABLE_CSS_REGIONS);$(ENABLE_CSS_EXCLUSIONS);$(ENABLE_SQL_DATABASE);$(ENABLE_DATAGRID);$(ENABLE_DATALIST);$(ENABLE_DATA_TRANSFER_ITEMS);$(ENABLE_DETAILS);$(ENABLE_DEVICE_ORIENTATION);$(ENABLE_DIRECTORY_UPLOAD);$(ENABLE_DOM_STORAGE);$(ENABLE_FILTERS);$(ENABLE_FILE_SYSTEM);$(ENABLE_CSS3_FLEXBOX);$(ENABLE_FULLSCREEN_API);$(ENABLE_GEOLOCATION);$(ENABLE_ICONDATABASE);$(ENABLE_INDEXED_DATABASE);$(ENABLE_INPUT_COLOR);$(ENABLE_INPUT_SPEECH);$(ENABLE_JAVASCRIPT_DEBUGGER);$(ENABLE_LINK_PREFETCH);$(ENABLE_MATHML);$(ENABLE_METER_TAG);$(ENABLE_MUTATION_OBSERVERS);$(ENABLE_NOTIFICATIONS);$(ENABLE_PAGE_VISIBILITY_API);$(ENABLE_PROGRESS_TAG);$(ENABLE_QUOTA);$(ENABLE_REGISTER_PROTOCOL_HANDLER);$(ENABLE_SHARED_WORKERS);$(ENABLE_SVG);$(ENABLE_SVG_DOM_OBJC_BINDINGS);$(ENABLE_SVG_FONTS);$(ENABLE_VIDEO);$(ENABLE_MEDIA_SOURCE);$(ENABLE_MEDIA_STATISTICS);$(ENABLE_WEB_SOCKETS);$(ENABLE_WEB_TIMING);$(ENABLE_WORKERS);$(ENABLE_XHTMLMP);$(ENABLE_XPATH);$(ENABLE_XSLT)"
+               PreprocessorDefinitions="$(ENABLE_REQUEST_ANIMATION_FRAME);$(ENABLE_3D_CANVAS);$(ENABLE_3D_RENDERING);$(ENABLE_ACCELERATED_2D_CANVAS);$(ENABLE_BLOB);$(ENABLE_CHANNEL_MESSAGING);$(ENABLE_CLIENT_BASED_GEOLOCATION);$(ENABLE_CSS_FILTERS);$(ENABLE_CSS_REGIONS);$(ENABLE_CSS_EXCLUSIONS);$(ENABLE_SQL_DATABASE);$(ENABLE_DATAGRID);$(ENABLE_DATALIST);$(ENABLE_DATA_TRANSFER_ITEMS);$(ENABLE_DETAILS);$(ENABLE_DEVICE_ORIENTATION);$(ENABLE_DIRECTORY_UPLOAD);$(ENABLE_DOM_STORAGE);$(ENABLE_FILTERS);$(ENABLE_FILE_SYSTEM);$(ENABLE_CSS3_FLEXBOX);$(ENABLE_FULLSCREEN_API);$(ENABLE_GEOLOCATION);$(ENABLE_ICONDATABASE);$(ENABLE_INDEXED_DATABASE);$(ENABLE_INPUT_COLOR);$(ENABLE_INPUT_SPEECH);$(ENABLE_JAVASCRIPT_DEBUGGER);$(ENABLE_LINK_PREFETCH);$(ENABLE_MATHML);$(ENABLE_METER_TAG);$(ENABLE_MUTATION_OBSERVERS);$(ENABLE_NOTIFICATIONS);$(ENABLE_PAGE_VISIBILITY_API);$(ENABLE_PROGRESS_TAG);$(ENABLE_QUOTA);$(ENABLE_REGISTER_PROTOCOL_HANDLER);$(ENABLE_SHARED_WORKERS);$(ENABLE_SVG);$(ENABLE_SVG_DOM_OBJC_BINDINGS);$(ENABLE_SVG_FONTS);$(ENABLE_VIDEO);$(ENABLE_MEDIA_SOURCE);$(ENABLE_MEDIA_STATISTICS);$(ENABLE_WEB_SOCKETS);$(ENABLE_WEB_TIMING);$(ENABLE_WORKERS);$(ENABLE_XHTMLMP);$(ENABLE_XPATH);$(ENABLE_XSLT)"
        />
   <UserMacro
+               Name="ENABLE_REQUEST_ANIMATION_FRAME"
+               Value="ENABLE_REQUEST_ANIMATION_FRAME"
+               PerformEnvironmentSet="true"
+       />
+    <UserMacro
                Name="ENABLE_3D_CANVAS"
                Value=""
                PerformEnvironmentSet="true"