[chromium] Add gl_tests to flakiness dashboard.
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 18 Jul 2012 23:23:30 +0000 (23:23 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 18 Jul 2012 23:23:30 +0000 (23:23 +0000)
https://bugs.webkit.org/show_bug.cgi?id=91680

Patch by Dave Tu <dtu@chromium.org> on 2012-07-18
Reviewed by Dirk Pranke.

* TestResultServer/static-dashboards/builders.js:
(loadBuildersList):
* TestResultServer/static-dashboards/dashboard_base.js:
(currentBuilderGroupCategory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/TestResultServer/static-dashboards/builders.js
Tools/TestResultServer/static-dashboards/dashboard_base.js

index 905c372..d538aa4 100644 (file)
@@ -1,3 +1,15 @@
+2012-07-18  Dave Tu  <dtu@chromium.org>
+
+        [chromium] Add gl_tests to flakiness dashboard.
+        https://bugs.webkit.org/show_bug.cgi?id=91680
+
+        Reviewed by Dirk Pranke.
+
+        * TestResultServer/static-dashboards/builders.js:
+        (loadBuildersList):
+        * TestResultServer/static-dashboards/dashboard_base.js:
+        (currentBuilderGroupCategory):
+
 2012-07-18  Dirk Pranke  <dpranke@chromium.org>
 
         fix python unit tests failing under cygwin
index 9d35674..f6dbdf5 100644 (file)
@@ -217,7 +217,9 @@ function onErrorLoadingBuilderList(url, builderGroups, groupName)
 }
 
 function loadBuildersList(groupName, testType) {
-    if (testType == 'gpu_tests') {
+    switch (testType) {
+    case 'gl_tests':
+    case 'gpu_tests':
         switch(groupName) {
         case '@DEPS - chromium.org':
             var builderGroup = new BuilderGroup(BuilderGroup.DEPS_WEBKIT);
@@ -234,7 +236,9 @@ function loadBuildersList(groupName, testType) {
             requestBuilderList(CHROMIUM_GPU_TESTS_BUILDER_GROUPS, isChromiumTipOfTreeGpuTestRunner, CHROMIUM_WEBKIT_BUILDER_MASTER, groupName, BuilderGroup.TOT_WEBKIT, builderGroup);
             break;
         }
-    } else if (testType == 'layout-tests') {
+        break;
+
+    case 'layout-tests':
         switch(groupName) {
         case '@ToT - chromium.org':
             var builderGroup = new BuilderGroup(BuilderGroup.TOT_WEBKIT);
@@ -251,7 +255,9 @@ function loadBuildersList(groupName, testType) {
             requestBuilderList(LAYOUT_TESTS_BUILDER_GROUPS, isChromiumWebkitDepsTestRunner, CHROMIUM_WEBKIT_BUILDER_MASTER, groupName, BuilderGroup.DEPS_WEBKIT, builderGroup);
             break;
         }
-    } else {
+        break;
+
+    default:
         switch(groupName) {
         case '@DEPS - chromium.org':
             var builderGroup = new BuilderGroup(BuilderGroup.DEPS_WEBKIT);
@@ -271,6 +277,7 @@ function loadBuildersList(groupName, testType) {
             requestBuilderList(CHROMIUM_GTESTS_BUILDER_GROUPS, isChromiumTipOfTreeGTestRunner, CHROMIUM_WEBKIT_BUILDER_MASTER, groupName, BuilderGroup.TOT_WEBKIT, builderGroup);
             break;
         }
+        break;
     }
 }
 
index 9d47a8f..dd43905 100644 (file)
@@ -124,6 +124,7 @@ var TEST_TYPES = [
     'crypto_unittests',
     'googleurl_unittests',
     'gfx_unittests',
+    'gl_tests',
     'gpu_tests',
     'gpu_unittests',
     'installer_util_unittests',
@@ -448,11 +449,15 @@ function isGPUTestResults()
 
 function currentBuilderGroupCategory()
 {
-    if (g_crossDashboardState.testType == 'layout-tests')
-        return LAYOUT_TESTS_BUILDER_GROUPS;
-    if (g_crossDashboardState.testType == 'gpu_tests')
+    switch (g_crossDashboardState.testType) {
+    case 'gl_tests':
+    case 'gpu_tests':
         return CHROMIUM_GPU_TESTS_BUILDER_GROUPS;
-    return CHROMIUM_GTESTS_BUILDER_GROUPS;
+    case 'layout-tests':
+        return LAYOUT_TESTS_BUILDER_GROUPS;
+    default:
+        return CHROMIUM_GTESTS_BUILDER_GROUPS;
+    }
 }
 
 function currentBuilderGroup()