Unreviewed, rolling out r244228.
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 25 Apr 2019 00:03:10 +0000 (00:03 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 25 Apr 2019 00:03:10 +0000 (00:03 +0000)
https://bugs.webkit.org/show_bug.cgi?id=197262

Causes compat issues (Requested by smfr on #webkit).

Reverted changeset:

"Unreviewed test gardening for Windows."
https://trac.webkit.org/changeset/244228

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

28 files changed:
LayoutTests/ChangeLog
LayoutTests/compositing/overflow/scrolling-content-clip-to-viewport.html
LayoutTests/compositing/rtl/rtl-scrolling-with-transformed-descendants-expected.txt
LayoutTests/compositing/rtl/rtl-scrolling-with-transformed-descendants.html
LayoutTests/fast/scrolling/ios/change-scrollability-on-content-resize-nested.html
LayoutTests/fast/scrolling/ios/overflow-scroll-inherited-expected.txt
LayoutTests/fast/scrolling/ios/overflow-scrolling-ancestor-clip-size.html
LayoutTests/fast/scrolling/ios/overflow-scrolling-ancestor-clip.html
LayoutTests/fast/scrolling/ios/reconcile-layer-position-recursive-expected.txt
LayoutTests/fast/scrolling/ios/reconcile-layer-position-recursive.html
LayoutTests/fast/scrolling/ios/scrolling-content-clip-to-viewport.html
LayoutTests/fast/scrolling/ios/subpixel-overflow-scrolling-with-ancestor.html
LayoutTests/fast/scrolling/ios/touch-scroll-pointer-events-none.html
LayoutTests/fast/scrolling/ios/touch-scroll-visibility-hidden.html
LayoutTests/platform/ios/compositing/overflow/scrolling-content-clip-to-viewport-expected.txt
LayoutTests/platform/ios/fast/scrolling/ios/scrolling-content-clip-to-viewport-expected.txt
LayoutTests/platform/mac-wk1/compositing/rtl/rtl-scrolling-with-transformed-descendants-expected.txt
LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame-expected.txt
LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor-expected.txt
LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame-gain-scrolling-ancestor.html
LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed-expected.txt
LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame-in-fixed.html
LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor-expected.txt
LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame-lose-scrolling-ancestor.html
LayoutTests/scrollingcoordinator/scrolling-tree/coordinated-frame.html
LayoutTests/scrollingcoordinator/scrolling-tree/resources/doc-with-sticky.html
Source/WebKit/ChangeLog
Source/WebKit/Shared/WebPreferences.yaml

index f8123ec..4a07d4a 100644 (file)
@@ -1,3 +1,15 @@
+2019-04-24  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r244228.
+        https://bugs.webkit.org/show_bug.cgi?id=197262
+
+        Causes compat issues (Requested by smfr on #webkit).
+
+        Reverted changeset:
+
+        "Unreviewed test gardening for Windows."
+        https://trac.webkit.org/changeset/244228
+
 2019-04-24  John Wilander  <wilander@apple.com>
 
         Age out unconverted Ad Click Attributions after one week.
index 4c798be..ae33193 100644 (file)
@@ -6,7 +6,7 @@
     (GraphicsLayer
       (bounds 800.00 600.00)
       (contentsOpaque 1)
-      (children 1
+      (children 4
         (GraphicsLayer
           (position 8.00 8.00)
           (bounds 404.00 223.00)
                   (anchor 0.00 0.00)
                   (bounds 766.00 204.00)
                   (drawsContent 1)
-                  (children 1
-                    (GraphicsLayer
-                      (position 462.00 0.00)
-                      (anchor 0.00 0.00)
-                      (bounds 150.00 200.00)
-                      (contentsOpaque 1)
-                    )
-                  )
                 )
               )
             )
           )
         )
+        (GraphicsLayer
+          (offsetFromRenderer width=-250 height=0)
+          (position 10.00 10.00)
+          (bounds 400.00 204.00)
+          (children 1
+            (GraphicsLayer
+              (position 250.00 0.00)
+              (bounds 150.00 200.00)
+              (contentsOpaque 1)
+            )
+          )
+        )
+        (GraphicsLayer
+          (offsetFromRenderer width=-96 height=0)
+          (position 10.00 10.00)
+          (bounds 400.00 204.00)
+          (children 1
+            (GraphicsLayer
+              (position 96.00 0.00)
+              (anchor 0.00 0.00)
+              (bounds 150.00 200.00)
+              (contentsOpaque 1)
+            )
+          )
+        )
+        (GraphicsLayer
+          (offsetFromRenderer width=58 height=0)
+          (position 10.00 10.00)
+          (bounds 400.00 204.00)
+          (children 1
+            (GraphicsLayer
+              (position -58.00 0.00)
+              (bounds 150.00 200.00)
+              (contentsOpaque 1)
+            )
+          )
+        )
       )
     )
   )
index ffdc694..9f1c191 100644 (file)
@@ -3,11 +3,10 @@
   <head>
     <style type="text/css">
         #scroller {
-            position: relative;
-            z-index: 0;
             overflow-x: auto;
             width: 400px;
             white-space: nowrap;
+            -webkit-overflow-scrolling: touch;
             border: 2px solid black;
         }
 
index d9e9b6c..ba48599 100644 (file)
@@ -14,8 +14,8 @@
             height: 100%;
             overflow-x: hidden;
             overflow-y: scroll;
+            -webkit-overflow-scrolling: touch;
             position: relative;
-            z-index: 0;
         }
         #content {
             background-color: yellow;
index 757a9be..b4db592 100644 (file)
@@ -1,5 +1,5 @@
-test1 -webkit-overflow-scrolling: auto
+test1 -webkit-overflow-scrolling: touch
 test2 -webkit-overflow-scrolling: auto
-test3 -webkit-overflow-scrolling: auto
-test4 -webkit-overflow-scrolling: auto
+test3 -webkit-overflow-scrolling: touch
+test4 -webkit-overflow-scrolling: touch
 
index 36cf8ce..8dfaf90 100644 (file)
@@ -19,9 +19,8 @@
   </script>
   <style>
     #scroller {
-      position: relative;
-      z-index: 0;
       overflow: scroll;
+      -webkit-overflow-scrolling: touch;
       width: 300px;
       height: 400px;
       border: 11px solid black;
index 5c42ce9..466beb4 100644 (file)
@@ -19,9 +19,8 @@
   </script>
   <style>
     #scroller {
-      position: relative;
-      z-index: 0;
       overflow: scroll;
+      -webkit-overflow-scrolling: touch;
       width: 300px;
       height: 400px;
       border: 1px solid black;
index eeed071..fb10f4e 100644 (file)
@@ -17,7 +17,7 @@
       (tile size 800 x 512)
       (top left tile 0, 1 tiles grid 1 x 3)
       (in window 1)
-      (children 3
+      (children 1
         (GraphicsLayer
           (position 8.00 1008.00)
           (bounds 300.00 300.00)
                               (coverage rect 0.00, 0.00 200.00 x 245.00)
                               (intersects coverage rect 1)
                               (contentsScale 2.00)
+                              (children 2
+                                (GraphicsLayer
+                                  (position 7.00 28.00)
+                                  (approximate position 7.00 28.00)
+                                  (bounds 110.00 110.00)
+                                  (contentsOpaque 1)
+                                  (drawsContent 1)
+                                  (visible rect 0.00, 0.00 110.00 x 110.00)
+                                  (coverage rect -7.00, -28.00 200.00 x 245.00)
+                                  (intersects coverage rect 1)
+                                  (contentsScale 2.00)
+                                  (children 1
+                                    (GraphicsLayer
+                                      (position 55.00 55.00)
+                                      (approximate position 55.00 55.00)
+                                      (bounds 110.00 110.00)
+                                      (contentsOpaque 1)
+                                      (drawsContent 1)
+                                      (visible rect 0.00, 0.00 110.00 x 110.00)
+                                      (coverage rect -62.00, -83.00 200.00 x 245.00)
+                                      (intersects coverage rect 1)
+                                      (contentsScale 2.00)
+                                    )
+                                  )
+                                )
+                                (GraphicsLayer
+                                  (position 105.00 395.00)
+                                  (approximate position 105.00 395.00)
+                                  (bounds 110.00 110.00)
+                                  (contentsOpaque 1)
+                                  (drawsContent 1)
+                                  (visible rect 0.00, 0.00 0.00 x 0.00)
+                                  (coverage rect -105.00, -395.00 200.00 x 245.00)
+                                  (intersects coverage rect 1)
+                                  (contentsScale 2.00)
+                                  (children 1
+                                    (GraphicsLayer
+                                      (position 55.00 55.00)
+                                      (approximate position 55.00 55.00)
+                                      (bounds 110.00 110.00)
+                                      (contentsOpaque 1)
+                                      (drawsContent 1)
+                                      (visible rect 0.00, 0.00 0.00 x 0.00)
+                                      (coverage rect -160.00, -450.00 200.00 x 245.00)
+                                      (intersects coverage rect 1)
+                                      (contentsScale 2.00)
+                                    )
+                                  )
+                                )
+                              )
                             )
                           )
                         )
             )
           )
         )
-        (GraphicsLayer
-          (position 70.00 1091.00)
-          (approximate position 70.00 1091.00)
-          (bounds 110.00 110.00)
-          (contentsOpaque 1)
-          (drawsContent 1)
-          (visible rect 0.00, 0.00 110.00 x 110.00)
-          (coverage rect -70.00, -326.00 1056.00 x 856.00)
-          (intersects coverage rect 1)
-          (contentsScale 2.00)
-          (children 1
-            (GraphicsLayer
-              (position 55.00 55.00)
-              (approximate position 55.00 55.00)
-              (bounds 110.00 110.00)
-              (contentsOpaque 1)
-              (drawsContent 1)
-              (visible rect 0.00, 0.00 110.00 x 110.00)
-              (coverage rect -125.00, -381.00 1056.00 x 856.00)
-              (intersects coverage rect 1)
-              (contentsScale 2.00)
-            )
-          )
-        )
-        (GraphicsLayer
-          (offsetFromRenderer width=-105 height=-105)
-          (position 63.00 1063.00)
-          (bounds 200.00 245.00)
-          (visible rect 0.00, 0.00 200.00 x 245.00)
-          (coverage rect 0.00, 0.00 200.00 x 245.00)
-          (intersects coverage rect 1)
-          (contentsScale 2.00)
-          (children 1
-            (GraphicsLayer
-              (position 105.00 395.00)
-              (approximate position 105.00 395.00)
-              (bounds 110.00 110.00)
-              (contentsOpaque 1)
-              (drawsContent 1)
-              (visible rect 0.00, 0.00 0.00 x 0.00)
-              (coverage rect -105.00, -395.00 200.00 x 245.00)
-              (intersects coverage rect 1)
-              (contentsScale 2.00)
-              (children 1
-                (GraphicsLayer
-                  (position 55.00 55.00)
-                  (approximate position 55.00 55.00)
-                  (bounds 110.00 110.00)
-                  (contentsOpaque 1)
-                  (drawsContent 1)
-                  (visible rect 0.00, 0.00 0.00 x 0.00)
-                  (coverage rect -160.00, -450.00 200.00 x 245.00)
-                  (intersects coverage rect 1)
-                  (contentsScale 2.00)
-                )
-              )
-            )
-          )
-        )
       )
     )
   )
index beea64e..845efbb 100644 (file)
@@ -11,6 +11,7 @@
       .scrollable {
          background: linear-gradient(135deg, cyan, green);
          overflow: auto;
+         -webkit-overflow-scrolling: touch;
       }
       .fixed {
          position: fixed;
index 4ee609b..5394842 100644 (file)
@@ -6,6 +6,7 @@
   <style>
     body {
       margin: 0;
+      -webkit-overflow-scrolling: touch;
     }
 
     .scroller {
index f565e4f..131d686 100644 (file)
@@ -19,9 +19,8 @@
   </script>
   <style>
     #scroller {
-      position: relative;
-      z-index: 0;
       overflow: scroll;
+      -webkit-overflow-scrolling: touch;
       width: 300px;
       height: 400px;
     }
index abc90a4..a47f69c 100644 (file)
         
         .container {
             position: absolute;
-            z-index: 0;
             top: 50px;
             left: 50px;
             height: 300px;
             width: 300px;
             overflow: scroll;
+            -webkit-overflow-scrolling: touch;
             border: 1px solid black;
             pointer-events: none;
             box-shadow: 0 0 10px black;
index b0fd8e3..9817be6 100644 (file)
@@ -1,4 +1,5 @@
-<!DOCTYPE html> <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->
+<!DOCTYPE html>
+
 <html>
 <head>
     <meta name="viewport" content="initial-scale=1.0">
         
         .container {
             position: absolute;
-            z-index: 0;
             top: 50px;
             left: 50px;
             height: 300px;
             width: 300px;
             overflow: scroll;
+            -webkit-overflow-scrolling: touch;
             border: 1px solid black;
             visibility: hidden;
             box-shadow: 0 0 10px black;
index 324e0c5..bb66841 100644 (file)
@@ -5,7 +5,7 @@
     (GraphicsLayer
       (bounds 800.00 600.00)
       (contentsOpaque 1)
-      (children 2
+      (children 1
         (GraphicsLayer
           (bounds 320.00 340.00)
           (children 1
                 (GraphicsLayer
                   (anchor 0.00 0.00)
                   (bounds 320.00 1224.00)
+                  (drawsContent 1)
                 )
               )
             )
           )
         )
-        (GraphicsLayer
-          (offsetFromRenderer width=-10 height=-10)
-          (bounds 320.00 340.00)
-          (children 1
-            (GraphicsLayer
-              (position 10.00 10.00)
-              (bounds 284.00 1204.00)
-              (contentsOpaque 1)
-              (drawsContent 1)
-            )
-          )
-        )
       )
     )
   )
index 5dec864..1bb2bf8 100644 (file)
@@ -5,7 +5,7 @@
     (GraphicsLayer
       (bounds 320.00 548.00)
       (contentsOpaque 1)
-      (children 2
+      (children 1
         (GraphicsLayer
           (bounds 320.00 340.00)
           (children 1
                 (GraphicsLayer
                   (anchor 0.00 0.00)
                   (bounds 320.00 1224.00)
+                  (drawsContent 1)
                 )
               )
             )
           )
         )
-        (GraphicsLayer
-          (offsetFromRenderer width=-10 height=-10)
-          (bounds 320.00 340.00)
-          (children 1
-            (GraphicsLayer
-              (position 10.00 10.00)
-              (bounds 284.00 1204.00)
-              (contentsOpaque 1)
-              (drawsContent 1)
-            )
-          )
-        )
       )
     )
   )
index 6942502..ad1cc6a 100644 (file)
@@ -8,21 +8,15 @@
       (contentsOpaque 1)
       (children 1
         (GraphicsLayer
-          (position 8.00 8.00)
-          (bounds 404.00 223.00)
+          (offsetFromRenderer width=-96 height=0)
+          (position 10.00 10.00)
+          (bounds 400.00 204.00)
           (children 1
             (GraphicsLayer
-              (offsetFromRenderer width=2 height=2)
-              (position 2.00 2.00)
-              (bounds 400.00 204.00)
-              (children 1
-                (GraphicsLayer
-                  (position 96.00 0.00)
-                  (anchor 0.00 0.00)
-                  (bounds 150.00 200.00)
-                  (contentsOpaque 1)
-                )
-              )
+              (position 96.00 0.00)
+              (anchor 0.00 0.00)
+              (bounds 150.00 200.00)
+              (contentsOpaque 1)
             )
           )
         )
index 0a13f54..042dd1b 100644 (file)
@@ -12,6 +12,8 @@
   (layout viewport at (0,0) size 785x600)
   (min layout viewport origin (0,0))
   (max layout viewport origin (0,416))
+  (synchronous event dispatch region for event wheel
+    at (45,47) size 404x304)
   (behavior for fixed 0)
   (children 1
     (Frame hosting node
           (min layout viewport origin (0,0))
           (max layout viewport origin (0,120))
           (behavior for fixed 0)
-          (children 2
-            (Overflow scrolling node
-              (scrollable area size 385 285)
-              (contents size 385 1760)
-              (parent relative scrollable rect at (10,10) size 385x285)
-              (scrollable area parameters 
-                (horizontal scroll elasticity 0)
-                (vertical scroll elasticity 0)
-                (horizontal scrollbar mode 0)
-                (vertical scrollbar mode 0)
-                (has enabled vertical scrollbar 1))
-              (children 1
-                (Sticky node
-                  (anchor edges: AnchorEdgeTop AnchorEdgeBottom)
-                  (top offset 10.00)
-                  (bottom offset 10.00)
-                  (containing block rect at (2,2) size 385x1760)
-                  (sticky box rect at (0,830) size 100x100)
-                  (constraining rect at (0,0) size 385x285)
-                  (sticky offset at last layout width=0 height=-655)
-                  (layer position at last layout (0,175))
-                )
-              )
-            )
+          (children 1
             (Sticky node
               (anchor edges: AnchorEdgeTop AnchorEdgeBottom)
               (top offset 10.00)
index 1615384..fd1691d 100644 (file)
@@ -12,6 +12,8 @@
   (layout viewport at (0,0) size 785x600)
   (min layout viewport origin (0,0))
   (max layout viewport origin (0,416))
+  (synchronous event dispatch region for event wheel
+    at (45,47) size 404x304)
   (behavior for fixed 0)
   (children 1
     (Fixed node
               (min layout viewport origin (0,0))
               (max layout viewport origin (0,120))
               (behavior for fixed 0)
-              (children 2
-                (Overflow scrolling node
-                  (scrollable area size 385 285)
-                  (contents size 385 1760)
-                  (parent relative scrollable rect at (10,10) size 385x285)
-                  (scrollable area parameters 
-                    (horizontal scroll elasticity 0)
-                    (vertical scroll elasticity 0)
-                    (horizontal scrollbar mode 0)
-                    (vertical scrollbar mode 0)
-                    (has enabled vertical scrollbar 1))
-                  (children 1
-                    (Sticky node
-                      (anchor edges: AnchorEdgeTop AnchorEdgeBottom)
-                      (top offset 10.00)
-                      (bottom offset 10.00)
-                      (containing block rect at (2,2) size 385x1760)
-                      (sticky box rect at (0,830) size 100x100)
-                      (constraining rect at (0,0) size 385x285)
-                      (sticky offset at last layout width=0 height=-655)
-                      (layer position at last layout (0,175))
-                    )
-                  )
-                )
+              (children 1
                 (Sticky node
                   (anchor edges: AnchorEdgeTop AnchorEdgeBottom)
                   (top offset 10.00)
index f7799af..42aecb0 100644 (file)
@@ -12,6 +12,8 @@
   (layout viewport at (0,0) size 785x600)
   (min layout viewport origin (0,0))
   (max layout viewport origin (0,416))
+  (synchronous event dispatch region for event wheel
+    at (45,37) size 404x304)
   (behavior for fixed 0)
   (children 1
     (Fixed node
               (min layout viewport origin (0,0))
               (max layout viewport origin (0,120))
               (behavior for fixed 0)
-              (children 2
-                (Overflow scrolling node
-                  (scrollable area size 385 285)
-                  (contents size 385 1760)
-                  (parent relative scrollable rect at (10,10) size 385x285)
-                  (scrollable area parameters 
-                    (horizontal scroll elasticity 0)
-                    (vertical scroll elasticity 0)
-                    (horizontal scrollbar mode 0)
-                    (vertical scrollbar mode 0)
-                    (has enabled vertical scrollbar 1))
-                  (children 1
-                    (Sticky node
-                      (anchor edges: AnchorEdgeTop AnchorEdgeBottom)
-                      (top offset 10.00)
-                      (bottom offset 10.00)
-                      (containing block rect at (2,2) size 385x1760)
-                      (sticky box rect at (0,830) size 100x100)
-                      (constraining rect at (0,0) size 385x285)
-                      (sticky offset at last layout width=0 height=-655)
-                      (layer position at last layout (0,175))
-                    )
-                  )
-                )
+              (children 1
                 (Sticky node
                   (anchor edges: AnchorEdgeTop AnchorEdgeBottom)
                   (top offset 10.00)
index 4d94da3..797508d 100644 (file)
@@ -12,6 +12,8 @@
   (layout viewport at (0,0) size 785x600)
   (min layout viewport origin (0,0))
   (max layout viewport origin (0,416))
+  (synchronous event dispatch region for event wheel
+    at (45,47) size 404x304)
   (behavior for fixed 0)
   (children 1
     (Frame hosting node
           (min layout viewport origin (0,0))
           (max layout viewport origin (0,120))
           (behavior for fixed 0)
-          (children 2
-            (Overflow scrolling node
-              (scrollable area size 385 285)
-              (contents size 385 1760)
-              (parent relative scrollable rect at (10,10) size 385x285)
-              (scrollable area parameters 
-                (horizontal scroll elasticity 0)
-                (vertical scroll elasticity 0)
-                (horizontal scrollbar mode 0)
-                (vertical scrollbar mode 0)
-                (has enabled vertical scrollbar 1))
-              (children 1
-                (Sticky node
-                  (anchor edges: AnchorEdgeTop AnchorEdgeBottom)
-                  (top offset 10.00)
-                  (bottom offset 10.00)
-                  (containing block rect at (2,2) size 385x1760)
-                  (sticky box rect at (0,830) size 100x100)
-                  (constraining rect at (0,0) size 385x285)
-                  (sticky offset at last layout width=0 height=-655)
-                  (layer position at last layout (0,175))
-                )
-              )
-            )
+          (children 1
             (Sticky node
               (anchor edges: AnchorEdgeTop AnchorEdgeBottom)
               (top offset 10.00)
index f0429c3..8fd0f6d 100644 (file)
@@ -1,4 +1,4 @@
-<!DOCTYPE html> <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->\r
+<!DOCTYPE html>\r
 <html>\r
 <head>\r
     <style>\r
index 9b4bc09..ebb54f6 100644 (file)
@@ -9,11 +9,10 @@
         }
         
         .scrolling {
-            position: relative;
-            z-index: 0;
             height: 300px;
             width: 400px;
             overflow: scroll;
+            -webkit-overflow-scrolling: touch;
             border: 2px solid black;
         }
         
index 4d10ae4..d53ec2b 100644 (file)
@@ -1,3 +1,15 @@
+2019-04-24  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r244228.
+        https://bugs.webkit.org/show_bug.cgi?id=197262
+
+        Causes compat issues (Requested by smfr on #webkit).
+
+        Reverted changeset:
+
+        "Unreviewed test gardening for Windows."
+        https://trac.webkit.org/changeset/244228
+
 2019-04-24  Eric Carlson  <eric.carlson@apple.com>
 
         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
index e42d923..ff9da3b 100644 (file)
@@ -1467,7 +1467,7 @@ AsyncOverflowScrollingEnabled:
 
 LegacyOverflowScrollingTouchEnabled:
   type: bool
-  defaultValue: false
+  defaultValue: true
   humanReadableName: "Legacy -webkit-overflow-scrolling property"
   humanReadableDescription: "Support the legacy -webkit-overflow-scrolling CSS property"
   condition: ENABLE(OVERFLOW_SCROLLING_TOUCH)