Remove speculative workaround for upload crash
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 7 Aug 2019 23:36:27 +0000 (23:36 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 7 Aug 2019 23:36:27 +0000 (23:36 +0000)
https://bugs.webkit.org/show_bug.cgi?id=200514

Patch by Alex Christensen <achristensen@webkit.org> on 2019-08-07
Reviewed by Geoffrey Garen.

This workaround didn't help anyways, and the crash has been resolved.  Let's clean up.

* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(-[WKNetworkSessionDelegate URLSession:task:needNewBodyStream:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/ChangeLog
Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm

index 9c07c9c..e93cd2b 100644 (file)
@@ -1,3 +1,15 @@
+2019-08-07  Alex Christensen  <achristensen@webkit.org>
+
+        Remove speculative workaround for upload crash
+        https://bugs.webkit.org/show_bug.cgi?id=200514
+
+        Reviewed by Geoffrey Garen.
+
+        This workaround didn't help anyways, and the crash has been resolved.  Let's clean up.
+
+        * NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+        (-[WKNetworkSessionDelegate URLSession:task:needNewBodyStream:]):
+
 2019-08-07  Chris Dumez  <cdumez@apple.com>
 
         Regression(r247784) ResourceLoadStatisticsMemoryStore / ResourceLoadStatisticsPersistentStorage may get destroyed on the wrong thread
index d82eefb..1f8d4cb 100644 (file)
@@ -394,10 +394,7 @@ static String stringForSSLCipher(SSLCipherSuite cipher)
         return;
     }
 
-    // FIXME: Call the completionHandler immediately once rdar://problem/28233746 is fixed.
-    RunLoop::main().dispatch([body = makeRef(*body), completionHandler = makeBlockPtr(completionHandler)] {
-        completionHandler(WebCore::createHTTPBodyNSInputStream(body.get()).get());
-    });
+    completionHandler(WebCore::createHTTPBodyNSInputStream(*body).get());
 }
 
 #if HAVE(CFNETWORK_WITH_IGNORE_HSTS) && ENABLE(RESOURCE_LOAD_STATISTICS)