Make TestFailures's list of flaky tests look more like the list of non-flaky tests
authoraroben@apple.com <aroben@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 8 Jul 2011 23:35:46 +0000 (23:35 +0000)
committeraroben@apple.com <aroben@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 8 Jul 2011 23:35:46 +0000 (23:35 +0000)
Fixes <http://webkit.org/b/64204> TestFailures page's flaky tests list is ugly!

Reviewed by Daniel Bates.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
(#failure-history, #possibly-flaky-tests): Expanded this rule to apply to the list of flaky
tests.
(#failure-history > li, #possibly-flaky-tests > li): Ditto, but moved the 50px left padding
from here...
(#failure-history > li): ...to here.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
(ViewController.prototype._domForPossiblyFlakyTests): Give the list an id attribute for
styling purposes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js
Tools/ChangeLog

index 4b69133..4fff569 100644 (file)
@@ -24,17 +24,21 @@ dt::after {
     content: ':';
 }
 
-#failure-history {
+#failure-history, #possibly-flaky-tests {
     margin: 0;
     padding: 0 0 0 15px;
 }
 
-#failure-history > li {
+#failure-history > li, #possibly-flaky-tests > li {
     background-color: #f0f0f0;
-    padding: 10px 10px 10px 50px;
+    padding: 10px;
     margin-bottom: 10px;
 }
 
+#failure-history > li {
+    padding-left: 50px;
+}
+
 .test-list {
     margin: 0 0 0 -40px;
     padding: 0;
index 6dd27a1..d9cf3b2 100644 (file)
@@ -501,6 +501,8 @@ ViewController.prototype = {
         var flakyList = document.createElement('ol');
         result.appendChild(flakyList);
 
+        flakyList.id = 'possibly-flaky-tests';
+
         var self = this;
         flakyList.appendChildren(sorted(flakyTests).map(function(testName) {
             var item = document.createElement('li');
index d05ec68..c70d3d2 100644 (file)
@@ -1,3 +1,22 @@
+2011-07-08  Adam Roben  <aroben@apple.com>
+
+        Make TestFailures's list of flaky tests look more like the list of non-flaky tests
+
+        Fixes <http://webkit.org/b/64204> TestFailures page's flaky tests list is ugly!
+
+        Reviewed by Daniel Bates.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
+        (#failure-history, #possibly-flaky-tests): Expanded this rule to apply to the list of flaky
+        tests.
+        (#failure-history > li, #possibly-flaky-tests > li): Ditto, but moved the 50px left padding
+        from here...
+        (#failure-history > li): ...to here.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
+        (ViewController.prototype._domForPossiblyFlakyTests): Give the list an id attribute for
+        styling purposes.
+
 2011-07-08  Jeffrey Pfau  <jpfau@apple.com>
 
         Unreviewed, add myself as committer.