Re-word the "Attach Debugger" overlay to never say "Attach". The new
authortimothy@apple.com <timothy@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 22 May 2008 22:48:38 +0000 (22:48 +0000)
committertimothy@apple.com <timothy@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 22 May 2008 22:48:38 +0000 (22:48 +0000)
wording is "Start Debugging". This makes the overlay consistent with
other wording used for starting the debugger. Also fixes the tooltips
for the Pause on Exceptions button.

Reviewed by Adam Roben and Dan Bernstein.

* English.lproj/localizedStrings.js: Adds new strings.
* page/inspector/ScriptsPanel.js: Changes the wording. Flips the
tooltips for the Pause on Exceptions buttons so the tooltip says
what will happen when the button is pressed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@34039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog
WebCore/English.lproj/localizedStrings.js
WebCore/page/inspector/ScriptsPanel.js

index 173d6cd..8af79d9 100644 (file)
@@ -1,5 +1,19 @@
 2008-05-22  Timothy Hatcher  <timothy@apple.com>
 
 2008-05-22  Timothy Hatcher  <timothy@apple.com>
 
+        Re-word the "Attach Debugger" overlay to never say "Attach". The new
+        wording is "Start Debugging". This makes the overlay consistent with
+        other wording used for starting the debugger. Also fixes the tooltips
+        for the Pause on Exceptions button.
+
+        Reviewed by Adam Roben and Dan Bernstein.
+
+        * English.lproj/localizedStrings.js: Adds new strings.
+        * page/inspector/ScriptsPanel.js: Changes the wording. Flips the
+        tooltips for the Pause on Exceptions buttons so the tooltip says
+        what will happen when the button is pressed.
+
+2008-05-22  Timothy Hatcher  <timothy@apple.com>
+
         Remove some non-functional elements from the Scripts panel
         so they don't confuse users why they aren't working.
 
         Remove some non-functional elements from the Scripts panel
         so they don't confuse users why they aren't working.
 
index 29c3d30..6224323 100644 (file)
Binary files a/WebCore/English.lproj/localizedStrings.js and b/WebCore/English.lproj/localizedStrings.js differ
index efbd125..d012cff 100644 (file)
@@ -146,18 +146,13 @@ WebInspector.ScriptsPanel = function()
     this.attachOverlayElement.id = "scripts-attach-overlay";
 
     var headerElement = document.createElement("h1");
     this.attachOverlayElement.id = "scripts-attach-overlay";
 
     var headerElement = document.createElement("h1");
-    headerElement.textContent = WebInspector.UIString("Debugging scripts requires you to attach the debugger.");
+    headerElement.textContent = WebInspector.UIString("Starting debugging will reload the inspected page.");
     this.attachOverlayElement.appendChild(headerElement);
 
     this.attachOverlayElement.appendChild(headerElement);
 
-    var infoElement = document.createElement("span");
-    infoElement.textContent = WebInspector.UIString("Attaching will reload the inspected page.");
-    this.attachOverlayElement.appendChild(infoElement);
-
-    this.attachOverlayElement.appendChild(document.createElement("br"));
     this.attachOverlayElement.appendChild(document.createElement("br"));
 
     var attachButton = document.createElement("button");
     this.attachOverlayElement.appendChild(document.createElement("br"));
 
     var attachButton = document.createElement("button");
-    attachButton.textContent = WebInspector.UIString("Attach Debugger");
+    attachButton.textContent = WebInspector.UIString("Start Debugging");
     attachButton.addEventListener("click", this._toggleDebugging.bind(this), false);
     this.attachOverlayElement.appendChild(attachButton);
 
     attachButton.addEventListener("click", this._toggleDebugging.bind(this), false);
     this.attachOverlayElement.appendChild(attachButton);
 
@@ -545,10 +540,10 @@ WebInspector.ScriptsPanel.prototype = {
     _updatePauseOnExceptionsButton: function()
     {
         if (InspectorController.pauseOnExceptions()) {
     _updatePauseOnExceptionsButton: function()
     {
         if (InspectorController.pauseOnExceptions()) {
-            this.pauseOnExceptionButtons.title = WebInspector.UIString("Pause on exceptions.");
+            this.pauseOnExceptionButtons.title = WebInspector.UIString("Don't pause on exceptions.");
             this.pauseOnExceptionButtons.addStyleClass("toggled-on");
         } else {
             this.pauseOnExceptionButtons.addStyleClass("toggled-on");
         } else {
-            this.pauseOnExceptionButtons.title = WebInspector.UIString("Don't pause on exceptions.");
+            this.pauseOnExceptionButtons.title = WebInspector.UIString("Pause on exceptions.");
             this.pauseOnExceptionButtons.removeStyleClass("toggled-on");
         }
     },
             this.pauseOnExceptionButtons.removeStyleClass("toggled-on");
         }
     },