REGRESSION(r221017): Quip stuck in a perpetual loading loop
authorbfulgham@apple.com <bfulgham@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 25 Aug 2017 20:10:51 +0000 (20:10 +0000)
committerbfulgham@apple.com <bfulgham@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 25 Aug 2017 20:10:51 +0000 (20:10 +0000)
https://bugs.webkit.org/show_bug.cgi?id=175991
<rdar://problem/34044445>

Reviewed by Daniel Bates.

This is a quick fix to return proper function to WebKit. I'll relate a follow-up fix that
addresses WebSockets more completely.

* platform/network/mac/CookieJarMac.mm:
(WebCore::cookieRequestHeaderFieldValue): Don't hard code a value of 'No' for returning secure
cookies. HTTPS connection should get secure cookies.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/platform/network/mac/CookieJarMac.mm

index ed1a13c..87a77bf 100644 (file)
@@ -1,3 +1,18 @@
+2017-08-25  Brent Fulgham  <bfulgham@apple.com>
+
+        REGRESSION(r221017): Quip stuck in a perpetual loading loop
+        https://bugs.webkit.org/show_bug.cgi?id=175991
+        <rdar://problem/34044445>
+
+        Reviewed by Daniel Bates.
+
+        This is a quick fix to return proper function to WebKit. I'll relate a follow-up fix that
+        addresses WebSockets more completely.
+
+        * platform/network/mac/CookieJarMac.mm:
+        (WebCore::cookieRequestHeaderFieldValue): Don't hard code a value of 'No' for returning secure
+        cookies. HTTPS connection should get secure cookies.
+
 2017-08-25  Youenn Fablet  <youenn@apple.com>
 
         Add support for ReadableStream storage in FetchBody
index 6d13b2f..c2b5690 100644 (file)
@@ -178,7 +178,8 @@ std::pair<String, bool> cookiesForDOM(const NetworkStorageSession& session, cons
 String cookieRequestHeaderFieldValue(const NetworkStorageSession& session, const URL& firstParty, const URL& url)
 {
     bool ignore = false;
-    return cookiesForSession(session, firstParty, url, IncludeHTTPOnly, IncludeSecureCookies::No, ignore);
+    auto includeSecureCookies = url.protocolIs("https") ? IncludeSecureCookies::Yes : IncludeSecureCookies::No;
+    return cookiesForSession(session, firstParty, url, IncludeHTTPOnly, includeSecureCookies, ignore);
 }
 
 void setCookiesFromDOM(const NetworkStorageSession& session, const URL& firstParty, const URL& url, const String& cookieStr)