storage/indexeddb/intversion-open-in-upgradeneeded.html is flaky on mac.
authorbeidson@apple.com <beidson@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 3 Jun 2016 19:28:34 +0000 (19:28 +0000)
committerbeidson@apple.com <beidson@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 3 Jun 2016 19:28:34 +0000 (19:28 +0000)
https://bugs.webkit.org/show_bug.cgi?id=155050

Reviewed by Alex Christensen.

The test no longer crashes/times out, but it does have text failures.
Resolve them by removing a race in the test itself.

* platform/mac-wk2/TestExpectations:
* storage/indexeddb/intversion-open-in-upgradeneeded-expected.txt:
* storage/indexeddb/intversion-open-in-upgradeneeded-private-expected.txt:
* storage/indexeddb/resources/intversion-open-in-upgradeneeded.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@201652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/mac-wk2/TestExpectations
LayoutTests/storage/indexeddb/intversion-open-in-upgradeneeded-expected.txt
LayoutTests/storage/indexeddb/intversion-open-in-upgradeneeded-private-expected.txt
LayoutTests/storage/indexeddb/resources/intversion-open-in-upgradeneeded.js

index b020694..517be6b 100644 (file)
@@ -1,3 +1,18 @@
+2016-06-03  Brady Eidson  <beidson@apple.com>
+
+        storage/indexeddb/intversion-open-in-upgradeneeded.html is flaky on mac.
+        https://bugs.webkit.org/show_bug.cgi?id=155050
+
+        Reviewed by Alex Christensen.
+
+        The test no longer crashes/times out, but it does have text failures.
+        Resolve them by removing a race in the test itself.
+        
+        * platform/mac-wk2/TestExpectations:
+        * storage/indexeddb/intversion-open-in-upgradeneeded-expected.txt:
+        * storage/indexeddb/intversion-open-in-upgradeneeded-private-expected.txt:
+        * storage/indexeddb/resources/intversion-open-in-upgradeneeded.js:
+
 2016-06-03  Antoine Quint  <graouts@apple.com>
 
         Reflection of element does not respect backdrop-filter property
index 56bc326..b18f706 100644 (file)
@@ -298,8 +298,6 @@ webkit.org/b/152025 [ Debug ] inspector/console/messagesCleared.html [ Pass Time
 
 webkit.org/b/152492 [ Debug ] inspector/debugger/break-on-exception-catch.html [ Pass Timeout ]
 
-webkit.org/b/155050 storage/indexeddb/intversion-open-in-upgradeneeded.html [ Pass Crash Failure ]
-
 webkit.org/b/155138 [ Yosemite ElCapitan ] inspector/console/addInspectedNode.html [ Pass Timeout ]
 
 webkit.org/b/154606 [ Release Yosemite ] imported/w3c/web-platform-tests/IndexedDB/idbcursor-advance-continue-async.htm [ Pass Timeout ]
index 76e89df..38d5ba5 100644 (file)
@@ -19,7 +19,6 @@ db.onversionchange = onVersionChange
 request = indexedDB.open(dbname, 3)
 request.onupgradeneeded = upgradeNeeded2
 request.onsuccess = openSuccess2
-request.onblocked = onBlocked
 
 transactionOnComplete():
 sawTransactionComplete = true
@@ -34,8 +33,6 @@ transaction = db.transaction('os')
 onVersionChange():
 db.close()
 
-onBlocked():
-
 upgradeNeeded2():
 db = event.target.result
 PASS event.newVersion is 3
index 76e89df..38d5ba5 100644 (file)
@@ -19,7 +19,6 @@ db.onversionchange = onVersionChange
 request = indexedDB.open(dbname, 3)
 request.onupgradeneeded = upgradeNeeded2
 request.onsuccess = openSuccess2
-request.onblocked = onBlocked
 
 transactionOnComplete():
 sawTransactionComplete = true
@@ -34,8 +33,6 @@ transaction = db.transaction('os')
 onVersionChange():
 db.close()
 
-onBlocked():
-
 upgradeNeeded2():
 db = event.target.result
 PASS event.newVersion is 3
index 2c2380f..271a016 100644 (file)
@@ -44,7 +44,6 @@ function upgradeNeeded1(evt)
     evalAndLog("request = indexedDB.open(dbname, 3)");
     evalAndLog("request.onupgradeneeded = upgradeNeeded2");
     evalAndLog("request.onsuccess = openSuccess2");
-    evalAndLog("request.onblocked = onBlocked");
     request.onerror = unexpectedErrorCallback;
 }
 
@@ -64,11 +63,6 @@ function onVersionChange(evt)
     evalAndLog("db.close()");
 }
 
-function onBlocked(evt)
-{
-    preamble(evt);
-}
-
 function upgradeNeeded2(evt)
 {
     preamble(evt);