Web Inspector: Elements: remove ellipses from "Break on" context menu item title
authormattbaker@apple.com <mattbaker@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 18 Jun 2019 04:32:41 +0000 (04:32 +0000)
committermattbaker@apple.com <mattbaker@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 18 Jun 2019 04:32:41 +0000 (04:32 +0000)
https://bugs.webkit.org/show_bug.cgi?id=198944

Reviewed by Devin Rousso.

Update context menu title to comply with Apple HI guidelines.

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Views/ContextMenuUtilities.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@246532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js

index ba8a7f7..d8a0087 100644 (file)
@@ -1,3 +1,15 @@
+2019-06-17  Matt Baker  <mattbaker@apple.com>
+
+        Web Inspector: Elements: remove ellipses from "Break on" context menu item title
+        https://bugs.webkit.org/show_bug.cgi?id=198944
+
+        Reviewed by Devin Rousso.
+
+        Update context menu title to comply with Apple HI guidelines.
+
+        * Localizations/en.lproj/localizedStrings.js:
+        * UserInterface/Views/ContextMenuUtilities.js:
+
 2019-06-17  Devin Rousso  <drousso@apple.com>
 
         Web Inspector: Debugger: adding a DOM/Event/URL breakpoint should enable breakpoints
index de79b54..29c1ebd 100644 (file)
@@ -166,9 +166,9 @@ localizedStrings["Block Variables"] = "Block Variables";
 localizedStrings["Body:"] = "Body:";
 localizedStrings["Boundary"] = "Boundary";
 localizedStrings["Box Model"] = "Box Model";
+localizedStrings["Break on"] = "Break on";
 localizedStrings["Break on events with name:"] = "Break on events with name:";
 localizedStrings["Break on request with URL:"] = "Break on request with URL:";
-localizedStrings["Break on\u2026"] = "Break on\u2026";
 localizedStrings["Breakdown"] = "Breakdown";
 localizedStrings["Breakdown of each memory category at the end of the selected time range"] = "Breakdown of each memory category at the end of the selected time range";
 localizedStrings["Breakdown of time spent on the main thread"] = "Breakdown of time spent on the main thread";
index da3dc63..3e395c5 100644 (file)
@@ -291,7 +291,7 @@ WI.appendContextMenuItemsForDOMNodeBreakpoints = function(contextMenu, domNode,
 
     contextMenu.__domBreakpointItemsAdded = true;
 
-    let subMenu = contextMenu.appendSubMenuItem(WI.UIString("Break on\u2026"));
+    let subMenu = contextMenu.appendSubMenuItem(WI.UIString("Break on"));
 
     let breakpoints = WI.domDebuggerManager.domBreakpointsForNode(domNode);
     let keyValuePairs = breakpoints.map((breakpoint) => [breakpoint.type, breakpoint]);