Stop using hyphenationFactor
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 16 Apr 2019 01:43:30 +0000 (01:43 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 16 Apr 2019 01:43:30 +0000 (01:43 +0000)
https://bugs.webkit.org/show_bug.cgi?id=196949
<rdar://problem/49779594>

Patch by Alex Christensen <achristensen@webkit.org> on 2019-04-15
Reviewed by Geoffrey Garen.

* UIProcess/Cocoa/WKSafeBrowsingWarning.mm:
(-[WKSafeBrowsingTextView initWithAttributedString:forWarning:]):
I added this use of hyphenationFactor in r241124 but the other changes in that revision make the use of hyphenationFactor redundant.
There is a reason to remove it in the radar.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/ChangeLog
Source/WebKit/UIProcess/Cocoa/WKSafeBrowsingWarning.mm

index 44044cd..c21de30 100644 (file)
@@ -1,5 +1,18 @@
 2019-04-15  Alex Christensen  <achristensen@webkit.org>
 
 2019-04-15  Alex Christensen  <achristensen@webkit.org>
 
+        Stop using hyphenationFactor
+        https://bugs.webkit.org/show_bug.cgi?id=196949
+        <rdar://problem/49779594>
+
+        Reviewed by Geoffrey Garen.
+
+        * UIProcess/Cocoa/WKSafeBrowsingWarning.mm:
+        (-[WKSafeBrowsingTextView initWithAttributedString:forWarning:]):
+        I added this use of hyphenationFactor in r241124 but the other changes in that revision make the use of hyphenationFactor redundant.
+        There is a reason to remove it in the radar.
+
+2019-04-15  Alex Christensen  <achristensen@webkit.org>
+
         Forward declare WKWebView in _WKDiagnosticLoggingDelegate.h
 
         * UIProcess/API/Cocoa/_WKDiagnosticLoggingDelegate.h:
         Forward declare WKWebView in _WKDiagnosticLoggingDelegate.h
 
         * UIProcess/API/Cocoa/_WKDiagnosticLoggingDelegate.h:
index 9c10958..ee85bc4 100644 (file)
@@ -562,9 +562,6 @@ static void setBackground(ViewType *view, ColorType *color)
 #if !PLATFORM(MAC)
     self.scrollEnabled = NO;
 #endif
 #if !PLATFORM(MAC)
     self.scrollEnabled = NO;
 #endif
-#if PLATFORM(WATCHOS)
-    self.layoutManager.hyphenationFactor = 1;
-#endif
 
     return self;
 }
 
     return self;
 }