REEGRESSION(r217459): testapi fails in JSExportTest's wrapperForNSObjectisObject().

https://bugs.webkit.org/show_bug.cgi?id=172654

Reviewed by Mark Lam.

The test's intent is to assert that an exception has not been
thrown (as indicated by the message string), but the test was
erroneously checking for ! the right condition. This is now fixed.

* API/tests/JSExportTests.mm:
(wrapperForNSObjectisObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@217517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Source/JavaScriptCore/API/tests/JSExportTests.mm b/Source/JavaScriptCore/API/tests/JSExportTests.mm
index c8aa0f9..8476f1f 100644 (file)
--- a/Source/JavaScriptCore/API/tests/JSExportTests.mm
+++ b/Source/JavaScriptCore/API/tests/JSExportTests.mm
@@ -161,8 +161,7 @@ static void wrapperForNSObjectisObject()
         context.exception = nil;
 
         context[@"A"] = NSObject.class;
-        // FIXME: https://bugs.webkit.org/show_bug.cgi?id=172654
-        // checkResult(@"Should not throw an exception when wrapping NSObject and Object has been changed", [context exception]);
+        checkResult(@"Should not throw an exception when wrapping NSObject and Object has been changed", ![context exception]);
     }
 }
 

diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
index e5ec4e9..9c30895 100644 (file)
--- a/Source/JavaScriptCore/ChangeLog
+++ b/Source/JavaScriptCore/ChangeLog
@@ -1,3 +1,17 @@
+2017-05-26  Keith Miller  <keith_miller@apple.com>
+
+        REEGRESSION(r217459): testapi fails in JSExportTest's wrapperForNSObjectisObject().
+        https://bugs.webkit.org/show_bug.cgi?id=172654
+
+        Reviewed by Mark Lam.
+
+        The test's intent is to assert that an exception has not been
+        thrown (as indicated by the message string), but the test was
+        erroneously checking for ! the right condition. This is now fixed.
+
+        * API/tests/JSExportTests.mm:
+        (wrapperForNSObjectisObject):
+
 2017-05-26  Joseph Pecoraro  <pecoraro@apple.com>
 
         JSContext Inspector: Improve the reliability of automatically pausing in auto-attach