Add null check for drawing area in WebPage::didCompletePageTransition() after r235867
authorcdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 13 Sep 2018 19:18:13 +0000 (19:18 +0000)
committercdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 13 Sep 2018 19:18:13 +0000 (19:18 +0000)
https://bugs.webkit.org/show_bug.cgi?id=189587

Reviewed by Geoffrey Garen.

Add null check for drawing area in WebPage::didCompletePageTransition() after r235867
as this is causing crashes on the bots.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didCompletePageTransition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@235984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/ChangeLog
Source/WebKit/WebProcess/WebPage/WebPage.cpp

index f4b2485..2520b31 100644 (file)
@@ -1,3 +1,16 @@
+2018-09-13  Chris Dumez  <cdumez@apple.com>
+
+        Add null check for drawing area in WebPage::didCompletePageTransition() after r235867
+        https://bugs.webkit.org/show_bug.cgi?id=189587
+
+        Reviewed by Geoffrey Garen.
+
+        Add null check for drawing area in WebPage::didCompletePageTransition() after r235867
+        as this is causing crashes on the bots.
+
+        * WebProcess/WebPage/WebPage.cpp:
+        (WebKit::WebPage::didCompletePageTransition):
+
 2018-09-13  Ryan Haddad  <ryanhaddad@apple.com>
 
         Unreviewed, rolling out r235953.
index 0559674..14769b8 100644 (file)
@@ -2870,7 +2870,8 @@ void WebPage::didStartPageTransition()
 
 void WebPage::didCompletePageTransition()
 {
-    m_drawingArea->setLayerTreeStateIsFrozen(false);
+    if (m_drawingArea)
+        m_drawingArea->setLayerTreeStateIsFrozen(false);
 }
 
 void WebPage::show()