Remove extraneous includes (HTMLElement, SVGElement, GlyphBuffer, Clipboard)
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 6 Sep 2012 17:13:48 +0000 (17:13 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 6 Sep 2012 17:13:48 +0000 (17:13 +0000)
https://bugs.webkit.org/show_bug.cgi?id=95780

Patch by Nikhil Bhargava <nbhargava@google.com> on 2012-09-06
Reviewed by Eric Seidel.

Removes extraneous includes of type HTMLElement, SVGElement, GlyphBuffer,
and Clipboard. There is a minor compile-time performance boost.

* Modules/mediastream/MediaStreamEvent.h:
* dom/Event.cpp:
* dom/Event.h:
(WebCore):
* dom/EventDispatchMediator.cpp:
* dom/EventListenerMap.cpp:
* dom/MouseRelatedEvent.h:
* dom/UIEvent.cpp:
* html/FormAssociatedElement.h:
(WebCore):
* inspector/TimelineRecordFactory.cpp:
* platform/graphics/FontPlatformData.h:
* rendering/RenderLineBoxList.h:
* rendering/style/RenderStyle.h:
(WebCore):
* svg/SVGAnimatedType.h:
* svg/SVGExternalResourcesRequired.cpp:
* svg/SVGExternalResourcesRequired.h:
(WebCore):
* svg/SVGURIReference.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@127752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

21 files changed:
Source/WebCore/ChangeLog
Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.cpp
Source/WebCore/Modules/mediastream/MediaStreamEvent.h
Source/WebCore/dom/Event.cpp
Source/WebCore/dom/Event.h
Source/WebCore/dom/EventDispatchMediator.cpp
Source/WebCore/dom/EventListenerMap.cpp
Source/WebCore/dom/MouseRelatedEvent.h
Source/WebCore/dom/UIEvent.cpp
Source/WebCore/html/FormAssociatedElement.h
Source/WebCore/inspector/TimelineRecordFactory.cpp
Source/WebCore/platform/graphics/FontPlatformData.h
Source/WebCore/rendering/RenderLineBoxList.h
Source/WebCore/rendering/style/RenderStyle.h
Source/WebCore/svg/SVGAnimatedType.h
Source/WebCore/svg/SVGExternalResourcesRequired.cpp
Source/WebCore/svg/SVGExternalResourcesRequired.h
Source/WebCore/svg/SVGURIReference.h
Source/WebKit2/WebProcess/Plugins/PluginView.h
Source/WebKit2/WebProcess/WebPage/WebFrame.h
Source/WebKit2/WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp

index b8ac4f7..b9b1b47 100644 (file)
@@ -1,3 +1,35 @@
+2012-09-06  Nikhil Bhargava  <nbhargava@google.com>
+
+        Remove extraneous includes (HTMLElement, SVGElement, GlyphBuffer, Clipboard)
+        https://bugs.webkit.org/show_bug.cgi?id=95780
+
+        Reviewed by Eric Seidel.
+
+        Removes extraneous includes of type HTMLElement, SVGElement, GlyphBuffer,
+        and Clipboard. There is a minor compile-time performance boost.
+
+        * Modules/mediastream/MediaStreamEvent.h:
+        * dom/Event.cpp:
+        * dom/Event.h:
+        (WebCore):
+        * dom/EventDispatchMediator.cpp:
+        * dom/EventListenerMap.cpp:
+        * dom/MouseRelatedEvent.h:
+        * dom/UIEvent.cpp:
+        * html/FormAssociatedElement.h:
+        (WebCore):
+        * inspector/TimelineRecordFactory.cpp:
+        * platform/graphics/FontPlatformData.h:
+        * rendering/RenderLineBoxList.h:
+        * rendering/style/RenderStyle.h:
+        (WebCore):
+        * svg/SVGAnimatedType.h:
+        * svg/SVGExternalResourcesRequired.cpp:
+        * svg/SVGExternalResourcesRequired.h:
+        (WebCore):
+        * svg/SVGURIReference.h:
+        (WebCore):
+
 2012-09-06  Dan Bernstein  <mitz@apple.com>
 
         REGRESSION(r127712): It broke http/tests/xmlhttprequest/basic-auth.html on JSC platforms
index 0e0bf48..14898a1 100644 (file)
@@ -43,6 +43,7 @@
 #include "IDBTracing.h"
 #include "IDBTransactionBackendImpl.h"
 #include "ScriptExecutionContext.h"
+#include <wtf/MathExtras.h>
 
 namespace WebCore {
 
index 01b0656..ec7015e 100644 (file)
@@ -28,6 +28,7 @@
 #if ENABLE(MEDIA_STREAM)
 
 #include "Event.h"
+#include "MediaStream.h"
 #include <wtf/text/AtomicString.h>
 
 namespace WebCore {
index 30d3cea..161acfe 100644 (file)
@@ -26,6 +26,7 @@
 #include "EventDispatcher.h"
 #include "EventNames.h"
 #include "EventTarget.h"
+#include "MemoryInstrumentation.h"
 #include "UserGestureIndicator.h"
 #include <wtf/CurrentTime.h>
 #include <wtf/text/AtomicString.h>
index 06c8b97..6fd34a7 100644 (file)
 #ifndef Event_h
 #define Event_h
 
-#include "Clipboard.h"
 #include "DOMTimeStamp.h"
+#include "EventNames.h"
+#include <wtf/HashMap.h>
+#include <wtf/ListHashSet.h>
 #include <wtf/RefCounted.h>
 #include <wtf/text/AtomicString.h>
 
 namespace WebCore {
 
+class Clipboard;
 class EventTarget;
 class EventDispatcher;
 class HTMLIFrameElement;
 class MemoryInstrumentation;
+class MemoryObjectInfo;
 
 struct EventInit {
     EventInit();
index b2474cb..8db3cb1 100644 (file)
@@ -33,6 +33,7 @@
 
 #include "Event.h"
 #include "EventDispatcher.h"
+#include "Node.h"
 
 namespace WebCore {
 
index c1fd4d7..cc5bf94 100644 (file)
@@ -35,6 +35,7 @@
 
 #include "Event.h"
 #include "EventException.h"
+#include "EventTarget.h"
 #include <wtf/MainThread.h>
 #include <wtf/StdLibExtras.h>
 #include <wtf/Vector.h>
index 0bb8a26..249b833 100644 (file)
@@ -24,7 +24,7 @@
 #ifndef MouseRelatedEvent_h
 #define MouseRelatedEvent_h
 
-#include "LayoutTypes.h"
+#include "LayoutTypesInlineMethods.h"
 #include "UIEventWithKeyState.h"
 
 namespace WebCore {
index 9e73316..3673726 100644 (file)
@@ -26,6 +26,7 @@
 #include "Console.h"
 #include "DOMWindow.h"
 #include "EventDispatcher.h"
+#include "Node.h"
 
 namespace WebCore {
 
index f981063..390e0ee 100644 (file)
 #ifndef FormAssociatedElement_h
 #define FormAssociatedElement_h
 
-#include "HTMLElement.h"
+#include <wtf/text/WTFString.h>
 
 namespace WebCore {
 
+class ContainerNode;
+class Document;
 class FormAttributeTargetObserver;
 class FormDataList;
+class HTMLElement;
 class HTMLFormElement;
+class Node;
+class ShadowRoot;
 class ValidationMessage;
 class ValidityState;
 class VisibleSelection;
index e8527b6..4af5f02 100644 (file)
@@ -37,6 +37,7 @@
 #include "Event.h"
 #include "InspectorValues.h"
 #include "IntRect.h"
+#include "LayoutTypesInlineMethods.h"
 #include "ResourceRequest.h"
 #include "ResourceResponse.h"
 #include "ScriptCallStack.h"
index 984f58c..f7af706 100644 (file)
@@ -42,7 +42,6 @@
 
 #include "FontOrientation.h"
 #include "FontWidthVariant.h"
-#include "GlyphBuffer.h"
 #include "TextOrientation.h"
 
 #if PLATFORM(WIN)
index e391f25..e5b085e 100644 (file)
@@ -30,7 +30,7 @@
 #ifndef RenderLineBoxList_h
 #define RenderLineBoxList_h
 
-#include "RenderBox.h"
+#include "RenderObject.h"
 
 namespace WebCore {
 
index 14163ef..8a184e6 100644 (file)
@@ -34,7 +34,6 @@
 #include "ColorSpace.h"
 #include "CounterDirectives.h"
 #include "DataRef.h"
-#include "FillLayer.h"
 #include "FontBaseline.h"
 #include "FontDescription.h"
 #include "GraphicsTypes.h"
@@ -75,7 +74,6 @@
 #include <wtf/Vector.h>
 
 #if ENABLE(CSS_FILTERS)
-#include "FilterOperations.h"
 #include "StyleFilterData.h"
 #endif
 
@@ -102,6 +100,10 @@ namespace WebCore {
 
 using std::max;
 
+#if ENABLE(CSS_FILTERS)
+class FilterOperations;
+#endif
+
 class BorderData;
 class CounterContent;
 class CursorList;
index cb19e7c..5376b8f 100644 (file)
 #include "FloatRect.h"
 #include "SVGAngle.h"
 #include "SVGColor.h"
-#include "SVGElement.h"
 #include "SVGLength.h"
 #include "SVGLengthList.h"
 #include "SVGNumberList.h"
 #include "SVGPointList.h"
 #include "SVGPreserveAspectRatio.h"
+#include "SVGPropertyInfo.h"
 #include "SVGTransformList.h"
 
 namespace WebCore {
index e186c53..09d7102 100644 (file)
@@ -24,6 +24,7 @@
 #include "SVGExternalResourcesRequired.h"
 
 #include "Attr.h"
+#include "SVGElement.h"
 #include "SVGNames.h"
 
 namespace WebCore {
index 5b0bf8f..2b79225 100644 (file)
 
 #if ENABLE(SVG)
 #include "QualifiedName.h"
-#include "SVGElement.h"
 #include <wtf/HashSet.h>
 
 namespace WebCore {
 
 class Attribute;
+class SVGElement;
 
 // Notes on a SVG 1.1 spec discrepancy:
 // The SVG DOM defines the attribute externalResourcesRequired as being of type SVGAnimatedBoolean, whereas the 
index a6dcb44..c87a174 100755 (executable)
 #define SVGURIReference_h
 
 #if ENABLE(SVG)
-#include "SVGElement.h"
+#include "Document.h"
 #include "XLinkNames.h"
 
 namespace WebCore {
 
 class Attribute;
-class Document;
 class Element;
 
 class SVGURIReference {
index a6a056c..d1d9853 100644 (file)
@@ -40,8 +40,9 @@
 // FIXME: Eventually this should move to WebCore.
 
 namespace WebCore {
-    class Frame;
-    class HTMLPlugInElement;
+class Frame;
+class HTMLPlugInElement;
+class RenderBoxModelObject;
 }
 
 namespace WebKit {
index eea09b7..bd53637 100644 (file)
 #include <wtf/RetainPtr.h>
 
 namespace WebCore {
-    class Frame;
-    class HTMLFrameOwnerElement;
+class Frame;
+class HTMLFrameOwnerElement;
+class IntRect;
 #if ENABLE(WEB_INTENTS)
-    class Intent;
+class Intent;
 #endif
-    class KURL;
+class KURL;
 }
 
 namespace WebKit {
index 095f773..29f8932 100644 (file)
@@ -34,6 +34,7 @@
 #include <WebCore/NotImplemented.h>
 #include <WebCore/PlatformContextCairo.h>
 #include <WebCore/PrintContext.h>
+#include <WebCore/ResourceError.h>
 #include <gtk/gtk.h>
 #include <wtf/Vector.h>
 #include <wtf/gobject/GOwnPtr.h>