[Mac] Disable QTKit by default on future OS X.
authorjer.noble@apple.com <jer.noble@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 23 Apr 2015 22:43:38 +0000 (22:43 +0000)
committerjer.noble@apple.com <jer.noble@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 23 Apr 2015 22:43:38 +0000 (22:43 +0000)
https://bugs.webkit.org/show_bug.cgi?id=144082

Reviewed by Darin Adler.

Source/WebCore:

Settings::gQTKitEnabled defaults to false.

* page/Settings.cpp:

Source/WebKit/mac:

Default WebKitQTKitEnabledPreferenceKey to NO.

* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):

Source/WebKit2:

QTKitEnabled defaults to false.

* Shared/WebPreferencesDefinitions.h:

LayoutTests:

Add a required BANDWIDTH field to the alternate playlist.

* http/tests/media/resources/hls/playlist-with-cookie.m3u8:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@183221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/http/tests/media/resources/hls/playlist-with-cookie.m3u8
Source/WebCore/ChangeLog
Source/WebCore/page/Settings.cpp
Source/WebCore/page/Settings.h
Source/WebKit/mac/ChangeLog
Source/WebKit/mac/WebView/WebPreferences.mm
Source/WebKit2/ChangeLog
Source/WebKit2/Shared/WebPreferencesDefinitions.h

index e75be875a990bf841728beb31473fc7d329ca61e..3fbcd07a3af0c66e08c069e0f2a9c83ebc735e4a 100644 (file)
@@ -1,3 +1,14 @@
+2015-04-23  Jer Noble  <jer.noble@apple.com>
+
+        [Mac] Disable QTKit by default on future OS X.
+        https://bugs.webkit.org/show_bug.cgi?id=144082
+
+        Reviewed by Darin Adler.
+
+        Add a required BANDWIDTH field to the alternate playlist.
+
+        * http/tests/media/resources/hls/playlist-with-cookie.m3u8:
+
 2015-04-23  Tim Horton  <timothy_horton@apple.com>
 
         Make the linter stop complaining by fixing the order of fields in TestExpectations
index 0a667808324cad82b097a8dc4c69fee21e22d9c5..2f04d7968b2139d79b563ca76ebf0d72b8129127 100644 (file)
@@ -1,5 +1,5 @@
 #EXTM3U
 
-#EXT-X-STREAM-INF:PROGRAM-ID=1
+#EXT-X-STREAM-INF:PROGRAM-ID=1,BANDWIDTH=34000
 sub-playlist-with-cookie.php
 
index dce57cfdd8eb4d81773f1e88d3be8f84a962ccb4..c9c1db976a0f05383d86b16a47c36da2e523dd07 100644 (file)
@@ -1,3 +1,14 @@
+2015-04-23  Jer Noble  <jer.noble@apple.com>
+
+        [Mac] Disable QTKit by default on future OS X.
+        https://bugs.webkit.org/show_bug.cgi?id=144082
+
+        Reviewed by Darin Adler.
+
+        Settings::gQTKitEnabled defaults to false.
+
+        * page/Settings.cpp:
+
 2015-04-23  Daniel Bates  <dabates@apple.com>
 
         Clean up: Use references instead of pointers in more SVG files
index 0a5f3d407ec70d332193f6e46bf61346582dedf0..efd56256d98967d4244864da5d3636e3d731e2f3 100644 (file)
@@ -74,7 +74,11 @@ bool Settings::gAVFoundationEnabled = false;
 #endif
 
 #if PLATFORM(COCOA)
+#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED <= 101000
 bool Settings::gQTKitEnabled = true;
+#else
+bool Settings::gQTKitEnabled = false;
+#endif
 #endif
 
 bool Settings::gMockScrollbarsEnabled = false;
index 4419ec2e806b1f7000d6e78e6ced7cd29a261d02..546efd690004eb8c001507a26a2ac78143682b8c 100644 (file)
@@ -205,6 +205,8 @@ public:
 #if PLATFORM(COCOA)
     WEBCORE_EXPORT static void setQTKitEnabled(bool flag);
     static bool isQTKitEnabled() { return gQTKitEnabled; }
+#else
+    static bool isQTKitEnabled() { return false; }
 #endif
 
     static const unsigned defaultMaximumHTMLParserDOMTreeDepth = 512;
index 8e6b96f8944dcdee211c8870d652761060f51bca..6ea5c90c15011fe86d7b9b295e44cc4a9d9d9bad 100644 (file)
@@ -1,3 +1,15 @@
+2015-04-23  Jer Noble  <jer.noble@apple.com>
+
+        [Mac] Disable QTKit by default on future OS X.
+        https://bugs.webkit.org/show_bug.cgi?id=144082
+
+        Reviewed by Darin Adler.
+
+        Default WebKitQTKitEnabledPreferenceKey to NO.
+
+        * WebView/WebPreferences.mm:
+        (+[WebPreferences initialize]):
+
 2015-04-23  Andreas Kling  <akling@apple.com>
 
         There should only be one way to get the system memory size.
index 3825a0d0f35d08a2a53bd652208cd8d6877d7425..d4fc21833ee01f9babc6f9d0ba1d39b540ee7425 100644 (file)
@@ -45,6 +45,7 @@
 #import <WebCore/NetworkStorageSession.h>
 #import <WebCore/PlatformCookieJar.h>
 #import <WebCore/ResourceHandle.h>
+#import <WebCore/Settings.h>
 #import <WebCore/TextEncodingRegistry.h>
 #import <runtime/InitializeThreading.h>
 #import <wtf/MainThread.h>
@@ -567,7 +568,7 @@ public:
 #endif
         [NSNumber numberWithLongLong:ApplicationCacheStorage::noQuota()], WebKitApplicationCacheTotalQuota,
         [NSNumber numberWithLongLong:ApplicationCacheStorage::noQuota()], WebKitApplicationCacheDefaultOriginQuota,
-        [NSNumber numberWithBool:YES],  WebKitQTKitEnabledPreferenceKey,
+        [NSNumber numberWithBool:Settings::isQTKitEnabled()], WebKitQTKitEnabledPreferenceKey,
         [NSNumber numberWithBool:NO], WebKitHiddenPageDOMTimerThrottlingEnabledPreferenceKey,
         [NSNumber numberWithBool:NO], WebKitHiddenPageCSSAnimationSuspensionEnabledPreferenceKey,
         [NSNumber numberWithBool:NO], WebKitLowPowerVideoAudioBufferSizeEnabledPreferenceKey,
index 542e91a741160e2223e93461413cb3bae18e46de..1b6fa8a2719f1438620985531e71240db989e7a4 100644 (file)
@@ -1,3 +1,14 @@
+2015-04-23  Jer Noble  <jer.noble@apple.com>
+
+        [Mac] Disable QTKit by default on future OS X.
+        https://bugs.webkit.org/show_bug.cgi?id=144082
+
+        Reviewed by Darin Adler.
+
+        QTKitEnabled defaults to false.
+
+        * Shared/WebPreferencesDefinitions.h:
+
 2015-04-23  Jer Noble  <jer.noble@apple.com>
 
         [WK2][Mac] Tweak the timing curve of the WebKit Fullscreen animation
index 67142c5c128514d03a4ac28ba21fa13b8efa67ec..31e9df9f8ef309e95aa0296793cc18aa1bb4c471 100644 (file)
     macro(TextAutosizingEnabled, textAutosizingEnabled, Bool, bool, false) \
     macro(AggressiveTileRetentionEnabled, aggressiveTileRetentionEnabled, Bool, bool, false) \
     macro(TemporaryTileCohortRetentionEnabled, temporaryTileCohortRetentionEnabled, Bool, bool, DEFAULT_TEMPORARY_TILE_COHORT_RETENTION_ENABLED) \
-    macro(QTKitEnabled, isQTKitEnabled, Bool, bool, true) \
+    macro(QTKitEnabled, isQTKitEnabled, Bool, bool, WebCore::Settings::isQTKitEnabled()) \
     macro(PageVisibilityBasedProcessSuppressionEnabled, pageVisibilityBasedProcessSuppressionEnabled, Bool, bool, true) \
     macro(SmartInsertDeleteEnabled, smartInsertDeleteEnabled, Bool, bool, true) \
     macro(SelectTrailingWhitespaceEnabled, selectTrailingWhitespaceEnabled, Bool, bool, false) \